This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-io.git
commit 146f0dbb23a09d75bae2cdcc9851b34d4dfd036a Author: Gary Gregory <gardgreg...@gmail.com> AuthorDate: Sun Feb 6 17:37:04 2022 -0500 Update tests to use Files.createSymbolicLink() instead of Runtime.getRuntime().exec() to create symbolic link fixtures. Also fixes two CodeQL issues. --- src/test/java/org/apache/commons/io/FileUtilsTest.java | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/src/test/java/org/apache/commons/io/FileUtilsTest.java b/src/test/java/org/apache/commons/io/FileUtilsTest.java index f64451c..b59ba30 100644 --- a/src/test/java/org/apache/commons/io/FileUtilsTest.java +++ b/src/test/java/org/apache/commons/io/FileUtilsTest.java @@ -190,19 +190,8 @@ public class FileUtilsTest extends AbstractTempDirTest { } } - private void createCircularOsSymLink(final String linkName, final String targetName) throws IOException { - if (FilenameUtils.isSystemWindows()) { - // Windows - try { - Runtime.getRuntime().exec("mklink /D " + linkName + " " + targetName); - } catch (final IOException ioe) { - // So that tests run in FAT filesystems don't fail - ioe.printStackTrace(); - } - } else { - // Not Windows, assume Linux - Runtime.getRuntime().exec("ln -s " + targetName + " " + linkName); - } + private Path createCircularOsSymLink(final String linkName, final String targetName) throws IOException { + return Files.createSymbolicLink(Paths.get(linkName), Paths.get(targetName)); } /**