This is an automated email from the ASF dual-hosted git repository. aherbert pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-statistics.git
commit c174f7d350c56c2fd4aa17c2e577f2fd3f326ef3 Author: Alex Herbert <aherb...@apache.org> AuthorDate: Wed Oct 27 12:43:05 2021 +0100 Sonar fix: rename var for temporary variance variables var is a restricted identifier. --- .../commons/statistics/distribution/TDistribution.java | 6 +++--- .../statistics/distribution/TruncatedNormalDistribution.java | 12 ++++++------ 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/TDistribution.java b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/TDistribution.java index 11dce96..6985dca 100644 --- a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/TDistribution.java +++ b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/TDistribution.java @@ -248,11 +248,11 @@ public abstract class TDistribution extends AbstractContinuousDistribution { } // If the variance converges to 1 use a NormalDistribution. // Occurs at 2^55 = 3.60e16 - final double var = StudentsTDistribution.computeVariance(degreesOfFreedom); - if (var == 1) { + final double variance = StudentsTDistribution.computeVariance(degreesOfFreedom); + if (variance == 1) { return new NormalTDistribution(degreesOfFreedom); } - return new StudentsTDistribution(degreesOfFreedom, var); + return new StudentsTDistribution(degreesOfFreedom, variance); } /** diff --git a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/TruncatedNormalDistribution.java b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/TruncatedNormalDistribution.java index 97a781b..a921b81 100644 --- a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/TruncatedNormalDistribution.java +++ b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/TruncatedNormalDistribution.java @@ -80,25 +80,25 @@ public final class TruncatedNormalDistribution extends AbstractContinuousDistrib // lower or upper may be infinite or the density is zero. double mu; - double var; + double v; if (lower == Double.NEGATIVE_INFINITY || pdfAlpha == 0) { if (upper == Double.POSITIVE_INFINITY || pdfBeta == 0) { // No truncation mu = mean; - var = sd * sd; + v = sd * sd; } else { // One sided truncation (of upper tail) final double betaRatio = pdfBeta / cdfDelta; mu = mean - sd * betaRatio; - var = sd * sd * (1 - beta * betaRatio - betaRatio * betaRatio); + v = sd * sd * (1 - beta * betaRatio - betaRatio * betaRatio); } } else { if (upper == Double.POSITIVE_INFINITY || pdfBeta == 0) { // One sided truncation (of lower tail) final double alphaRatio = pdfAlpha / cdfDelta; mu = mean + sd * alphaRatio; - var = sd * sd * (1 + alpha * alphaRatio - alphaRatio * alphaRatio); + v = sd * sd * (1 + alpha * alphaRatio - alphaRatio * alphaRatio); } else { // Two-sided truncation // Note: @@ -110,14 +110,14 @@ public final class TruncatedNormalDistribution extends AbstractContinuousDistrib final double pdfCdfDelta = (pdfAlpha - pdfBeta) / z; final double alphaBetaDelta = (alpha * pdfAlpha - beta * pdfBeta) / z; mu = mean + pdfCdfDelta * sd; - var = sd * sd * (1 + alphaBetaDelta - pdfCdfDelta * pdfCdfDelta); + v = sd * sd * (1 + alphaBetaDelta - pdfCdfDelta * pdfCdfDelta); } } // The mean should be clipped to the range [lower, upper]. // The variance should be less than the variance of the parent normal distribution. this.mean = clipToRange(mu); - variance = Math.min(var, sd * sd); + variance = Math.min(v, sd * sd); } /**