This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-cli.git


The following commit(s) were added to refs/heads/master by this push:
     new 234062c  updated unit tests (#76)
234062c is described below

commit 234062c7d9e7917e2ff01ac3b534e053759c5c6c
Author: Waldemar Sojka <waldemar.so...@gmail.com>
AuthorDate: Sat Oct 23 14:22:29 2021 +0200

    updated unit tests (#76)
---
 src/changes/changes.xml                              |  2 +-
 src/test/java/org/apache/commons/cli/OptionTest.java | 20 ++++++++++++++++++++
 2 files changed, 21 insertions(+), 1 deletion(-)

diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 517cb70..cf380a7 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -62,7 +62,7 @@
       <action type="add" dev="ggregory" due-to="Alex Nordlund" issue="CLI-282">
         TypeHandler should throw ParseException for an unsupported class.
       </action>
-      <action type="add" dev="ggregory" due-to="waso, Gary Gregory">
+      <action type="add" dev="ggregory" due-to="Waldemar Sojka, Gary Gregory">
         Added setter for Builder.option #33.
       </action>
       <!-- UPDATE -->
diff --git a/src/test/java/org/apache/commons/cli/OptionTest.java 
b/src/test/java/org/apache/commons/cli/OptionTest.java
index 643cbd9..14542d9 100644
--- a/src/test/java/org/apache/commons/cli/OptionTest.java
+++ b/src/test/java/org/apache/commons/cli/OptionTest.java
@@ -81,6 +81,26 @@ public class OptionTest {
         Option.builder(null).desc("desc").build();
     }
 
+    @Test(expected = IllegalArgumentException.class)
+    public void testBuilderInvalidOptionName1() {
+        Option.builder().option("invalid?");
+    }
+
+    @Test(expected = IllegalArgumentException.class)
+    public void testBuilderInvalidOptionName2() {
+        Option.builder().option("invalid@");
+    }
+
+    @Test(expected = IllegalArgumentException.class)
+    public void testBuilderInvalidOptionName3() {
+        Option.builder("invalid?");
+    }
+
+    @Test(expected = IllegalArgumentException.class)
+    public void testBuilderInvalidOptionName4() {
+        Option.builder("invalid@");
+    }
+
     @Test
     public void testBuilderMethods() {
         final char defaultSeparator = (char) 0;

Reply via email to