This is an automated email from the ASF dual-hosted git repository.

aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git

commit 134710705b01c62371427eabd17a7c01cd166350
Author: Alex Herbert <aherb...@apache.org>
AuthorDate: Wed Oct 20 21:48:54 2021 +0100

    Update test tolerances for Erf and Erfc tests
    
    Tolerances can be made stricter following the accuracy improvement of
    the error functions in NUMBERS-172.
---
 .../src/test/java/org/apache/commons/numbers/gamma/ErfTest.java      | 2 +-
 .../src/test/java/org/apache/commons/numbers/gamma/ErfcTest.java     | 5 ++---
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git 
a/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/ErfTest.java
 
b/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/ErfTest.java
index a37d36a..bd8a01d 100644
--- 
a/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/ErfTest.java
+++ 
b/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/ErfTest.java
@@ -103,7 +103,7 @@ class ErfTest {
 
         double x = -10;
         for (int i = 0; i < 41; i++) {
-            Assertions.assertEquals(gnuValues[i], Erf.value(x), tol);
+            Assertions.assertEquals(gnuValues[i], Erf.value(x), 
Math.abs(gnuValues[i]) * tol);
             x += 0.5d;
         }
     }
diff --git 
a/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/ErfcTest.java
 
b/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/ErfcTest.java
index 81be557..65621f9 100644
--- 
a/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/ErfcTest.java
+++ 
b/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/ErfcTest.java
@@ -45,7 +45,7 @@ class ErfcTest {
 
         double x = -10;
         for (int i = 0; i < 41; i++) {
-            Assertions.assertEquals(gnuValues[i], Erfc.value(x), tol);
+            Assertions.assertEquals(gnuValues[i], Erfc.value(x), gnuValues[i] 
* tol);
             x += 0.5d;
         }
     }
@@ -78,8 +78,7 @@ class ErfcTest {
 
         for (int i = 0; i < 15; i++) {
             final double result = 0.5 * Erfc.value(ref[i][0] / Math.sqrt(2));
-            Assertions.assertEquals(ref[i][1], result, 1e-15);
-            Assertions.assertEquals(1, ref[i][1] / result, 1e-13);
+            Assertions.assertEquals(ref[i][1], result, ref[i][1] * 1e-13);
         }
     }
 }

Reply via email to