This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-dbcp.git


The following commit(s) were added to refs/heads/master by this push:
     new 653a6e2  Use try-with-resources.
653a6e2 is described below

commit 653a6e2f63608db6cf1a0e8f60b7493de5e634c8
Author: Gary Gregory <gardgreg...@gmail.com>
AuthorDate: Wed Aug 18 18:35:06 2021 -0400

    Use try-with-resources.
---
 src/test/java/org/apache/commons/dbcp2/StackMessageLog.java | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/test/java/org/apache/commons/dbcp2/StackMessageLog.java 
b/src/test/java/org/apache/commons/dbcp2/StackMessageLog.java
index acdaaa6..9a98dd3 100644
--- a/src/test/java/org/apache/commons/dbcp2/StackMessageLog.java
+++ b/src/test/java/org/apache/commons/dbcp2/StackMessageLog.java
@@ -109,14 +109,14 @@ public class StackMessageLog extends SimpleLog {
         try {
             final StringBuilder buf = new StringBuilder();
             buf.append(message.toString());
-            if(t != null) {
+            if (t != null) {
                 buf.append(" <");
                 buf.append(t.toString());
                 buf.append(">");
                 final java.io.StringWriter sw = new java.io.StringWriter(1024);
-                final java.io.PrintWriter pw = new java.io.PrintWriter(sw);
-                t.printStackTrace(pw);
-                pw.close();
+                try (final java.io.PrintWriter pw = new 
java.io.PrintWriter(sw)) {
+                    t.printStackTrace(pw);
+                }
                 buf.append(sw.toString());
             }
             messageStack.push(buf.toString());

Reply via email to