This is an automated email from the ASF dual-hosted git repository.

aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-statistics.git

commit 4333ab84232347c8cc0c26d2548e17c5f796776e
Author: aherbert <aherb...@apache.org>
AuthorDate: Fri Jul 30 16:23:19 2021 +0100

    Add empty arrays to the abstract tests
---
 .../distribution/ContinuousDistributionAbstractTest.java   | 14 ++++++++------
 .../distribution/DiscreteDistributionAbstractTest.java     | 12 ++++++++----
 2 files changed, 16 insertions(+), 10 deletions(-)

diff --git 
a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ContinuousDistributionAbstractTest.java
 
b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ContinuousDistributionAbstractTest.java
index 148086a..b7e380b 100644
--- 
a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ContinuousDistributionAbstractTest.java
+++ 
b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ContinuousDistributionAbstractTest.java
@@ -77,6 +77,8 @@ import org.junit.jupiter.api.BeforeEach;
  * for examples.
  */
 abstract class ContinuousDistributionAbstractTest {
+    /** A zero length double[] array. */
+    private static final double[] EMPTY_DOUBLE_ARRAY = {};
 
     //-------------------- Private test instance data -------------------------
 
@@ -143,12 +145,12 @@ abstract class ContinuousDistributionAbstractTest {
      * define points to test.
      */
     public double[] makeProbabilityTestPoints() {
-        return new double[0];
+        return EMPTY_DOUBLE_ARRAY;
     }
 
     /** Creates the default probability test expected values. */
     public double[] makeProbabilityTestValues() {
-        return new double[0];
+        return EMPTY_DOUBLE_ARRAY;
     }
 
     /** Creates the default logarithmic probability density test expected 
values.
@@ -184,7 +186,7 @@ abstract class ContinuousDistributionAbstractTest {
 
     /** Creates the default cumulative probability precision test input 
values. */
     public double[] makeCumulativePrecisionTestPoints() {
-        return new double[0];
+        return EMPTY_DOUBLE_ARRAY;
     }
 
     /**
@@ -193,12 +195,12 @@ abstract class ContinuousDistributionAbstractTest {
      *       not test the desired results without increasing precision 
threshold.
      */
     public double[] makeCumulativePrecisionTestValues() {
-        return new double[0];
+        return EMPTY_DOUBLE_ARRAY;
     }
 
     /** Creates the default survival probability precision test input values. 
*/
     public double[] makeSurvivalPrecisionTestPoints() {
-        return new double[0];
+        return EMPTY_DOUBLE_ARRAY;
     }
 
     /**
@@ -207,7 +209,7 @@ abstract class ContinuousDistributionAbstractTest {
      *       not test the desired results without increasing precision 
threshold.
      */
     public double[] makeSurvivalPrecisionTestValues() {
-        return new double[0];
+        return EMPTY_DOUBLE_ARRAY;
     }
 
     //---- Default implementations of inverse test data generation methods ----
diff --git 
a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/DiscreteDistributionAbstractTest.java
 
b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/DiscreteDistributionAbstractTest.java
index 1f0994d..03273f9 100644
--- 
a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/DiscreteDistributionAbstractTest.java
+++ 
b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/DiscreteDistributionAbstractTest.java
@@ -72,6 +72,10 @@ import org.junit.jupiter.api.Test;
  * for examples.
  */
 abstract class DiscreteDistributionAbstractTest {
+    /** A zero length int[] array. */
+    private static final int[] EMPTY_INT_ARRAY = {};
+    /** A zero length double[] array. */
+    private static final double[] EMPTY_DOUBLE_ARRAY = {};
 
     //-------------------- Private test instance data -------------------------
 
@@ -147,7 +151,7 @@ abstract class DiscreteDistributionAbstractTest {
 
     /** Creates the default cumulative probability precision test input 
values. */
     public int[] makeCumulativePrecisionTestPoints() {
-        return new int[0];
+        return EMPTY_INT_ARRAY;
     }
 
     /**
@@ -156,12 +160,12 @@ abstract class DiscreteDistributionAbstractTest {
      *       not test the desired results without increasing precision 
threshold.
      */
     public double[] makeCumulativePrecisionTestValues() {
-        return new double[0];
+        return EMPTY_DOUBLE_ARRAY;
     }
 
     /** Creates the default survival probability precision test input values. 
*/
     public int[] makeSurvivalPrecisionTestPoints() {
-        return new int[0];
+        return EMPTY_INT_ARRAY;
     }
 
     /**
@@ -170,7 +174,7 @@ abstract class DiscreteDistributionAbstractTest {
      *       not test the desired results without increasing precision 
threshold.
      */
     public double[] makeSurvivalPrecisionTestValues() {
-        return new double[0];
+        return EMPTY_DOUBLE_ARRAY;
     }
 
     //---- Default implementations of inverse test data generation methods ----

Reply via email to