This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-logging.git


The following commit(s) were added to refs/heads/master by this push:
     new d2a0dc8  Simplify expressions.
d2a0dc8 is described below

commit d2a0dc8d31b66cfab1c02c5b55fffc5a2677633e
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Sat Jul 10 09:53:06 2021 -0400

    Simplify expressions.
---
 src/main/java/org/apache/commons/logging/LogFactory.java          | 2 +-
 src/test/java/org/apache/commons/logging/PathableClassLoader.java | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/main/java/org/apache/commons/logging/LogFactory.java 
b/src/main/java/org/apache/commons/logging/LogFactory.java
index fc6c514..da0cac7 100644
--- a/src/main/java/org/apache/commons/logging/LogFactory.java
+++ b/src/main/java/org/apache/commons/logging/LogFactory.java
@@ -458,7 +458,7 @@ public abstract class LogFactory {
             final String useTCCLStr = props.getProperty(TCCL_KEY);
             // The Boolean.valueOf(useTCCLStr).booleanValue() formulation
             // is required for Java 1.2 compatibility.
-            if ((useTCCLStr != null) && (Boolean.parseBoolean(useTCCLStr) == 
false)) {
+            if ((useTCCLStr != null) && !Boolean.parseBoolean(useTCCLStr)) {
                 // Don't use current context classloader when locating any
                 // LogFactory or Log classes, just use the class that loaded
                 // this abstract class. When this class is deployed in a shared
diff --git a/src/test/java/org/apache/commons/logging/PathableClassLoader.java 
b/src/test/java/org/apache/commons/logging/PathableClassLoader.java
index 0efd2e1..f985a11 100644
--- a/src/test/java/org/apache/commons/logging/PathableClassLoader.java
+++ b/src/test/java/org/apache/commons/logging/PathableClassLoader.java
@@ -252,7 +252,7 @@ public class PathableClassLoader extends URLClassLoader {
      */
     private URL libFromClasspath(final String logicalLib) {
         final ClassLoader cl = this.getClass().getClassLoader();
-        if (cl instanceof URLClassLoader == false) {
+        if (!(cl instanceof URLClassLoader)) {
             return null;
         }
 
@@ -302,7 +302,7 @@ public class PathableClassLoader extends URLClassLoader {
             for (final Object element : lookasides.entrySet()) {
                 final Map.Entry entry = (Map.Entry) element;
                 final String prefix = (String) entry.getKey();
-                if (name.startsWith(prefix) == true) {
+                if (name.startsWith(prefix)) {
                     final ClassLoader loader = (ClassLoader) entry.getValue();
                     final Class clazz = Class.forName(name, resolve, loader);
                     return clazz;

Reply via email to