This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-dbcp.git
The following commit(s) were added to refs/heads/master by this push:
new 9b0f473 Use final.
9b0f473 is described below
commit 9b0f4738dccc4e54c1ea42bbce1478f36bd18569
Author: Gary Gregory <[email protected]>
AuthorDate: Sat Jul 10 09:46:29 2021 -0400
Use final.
---
src/main/java/org/apache/commons/dbcp2/datasources/CharArray.java | 2 +-
src/test/java/org/apache/commons/dbcp2/TestConnectionPool.java | 4 ++--
.../org/apache/commons/dbcp2/transaction/TransactionAdapter.java | 6 +++---
.../apache/commons/dbcp2/transaction/TransactionManagerAdapter.java | 4 ++--
.../transaction/TransactionSynchronizationRegistryAdapter.java | 6 +++---
5 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/src/main/java/org/apache/commons/dbcp2/datasources/CharArray.java
b/src/main/java/org/apache/commons/dbcp2/datasources/CharArray.java
index d9f0929..f948f8b 100644
--- a/src/main/java/org/apache/commons/dbcp2/datasources/CharArray.java
+++ b/src/main/java/org/apache/commons/dbcp2/datasources/CharArray.java
@@ -46,7 +46,7 @@ final class CharArray {
@Override
public int hashCode() {
final int prime = 31;
- int result = 1;
+ final int result = 1;
return prime * result + Arrays.hashCode(chars);
}
diff --git a/src/test/java/org/apache/commons/dbcp2/TestConnectionPool.java
b/src/test/java/org/apache/commons/dbcp2/TestConnectionPool.java
index 6141547..2ea0b5b 100644
--- a/src/test/java/org/apache/commons/dbcp2/TestConnectionPool.java
+++ b/src/test/java/org/apache/commons/dbcp2/TestConnectionPool.java
@@ -852,8 +852,8 @@ public abstract class TestConnectionPool {
assertEquals(0, failed, "Did not expect any threads to
fail");
}
}
-
- void println(String string) {
+
+ void println(final String string) {
if (Boolean.getBoolean(getClass().getSimpleName() + ".debug"))
{
System.out.println(string);
}
diff --git
a/src/test/java/org/apache/commons/dbcp2/transaction/TransactionAdapter.java
b/src/test/java/org/apache/commons/dbcp2/transaction/TransactionAdapter.java
index 4df889e..cee42ae 100644
--- a/src/test/java/org/apache/commons/dbcp2/transaction/TransactionAdapter.java
+++ b/src/test/java/org/apache/commons/dbcp2/transaction/TransactionAdapter.java
@@ -37,12 +37,12 @@ public class TransactionAdapter implements Transaction {
}
@Override
- public boolean delistResource(XAResource arg0, int arg1) throws
IllegalStateException, SystemException {
+ public boolean delistResource(final XAResource arg0, final int arg1)
throws IllegalStateException, SystemException {
return false;
}
@Override
- public boolean enlistResource(XAResource arg0) throws
IllegalStateException, RollbackException, SystemException {
+ public boolean enlistResource(final XAResource arg0) throws
IllegalStateException, RollbackException, SystemException {
return false;
}
@@ -52,7 +52,7 @@ public class TransactionAdapter implements Transaction {
}
@Override
- public void registerSynchronization(Synchronization arg0)
+ public void registerSynchronization(final Synchronization arg0)
throws IllegalStateException, RollbackException, SystemException {
// Noop
}
diff --git
a/src/test/java/org/apache/commons/dbcp2/transaction/TransactionManagerAdapter.java
b/src/test/java/org/apache/commons/dbcp2/transaction/TransactionManagerAdapter.java
index b6a3b10..0fd9ef7 100644
---
a/src/test/java/org/apache/commons/dbcp2/transaction/TransactionManagerAdapter.java
+++
b/src/test/java/org/apache/commons/dbcp2/transaction/TransactionManagerAdapter.java
@@ -53,7 +53,7 @@ public class TransactionManagerAdapter implements
TransactionManager {
}
@Override
- public void resume(Transaction arg0) throws IllegalStateException,
InvalidTransactionException, SystemException {
+ public void resume(final Transaction arg0) throws IllegalStateException,
InvalidTransactionException, SystemException {
// Noop
}
@@ -68,7 +68,7 @@ public class TransactionManagerAdapter implements
TransactionManager {
}
@Override
- public void setTransactionTimeout(int arg0) throws SystemException {
+ public void setTransactionTimeout(final int arg0) throws SystemException {
// Noop
}
diff --git
a/src/test/java/org/apache/commons/dbcp2/transaction/TransactionSynchronizationRegistryAdapter.java
b/src/test/java/org/apache/commons/dbcp2/transaction/TransactionSynchronizationRegistryAdapter.java
index 460068e..cc138ac 100644
---
a/src/test/java/org/apache/commons/dbcp2/transaction/TransactionSynchronizationRegistryAdapter.java
+++
b/src/test/java/org/apache/commons/dbcp2/transaction/TransactionSynchronizationRegistryAdapter.java
@@ -26,7 +26,7 @@ import javax.transaction.TransactionSynchronizationRegistry;
public class TransactionSynchronizationRegistryAdapter implements
TransactionSynchronizationRegistry {
@Override
- public Object getResource(Object arg0) {
+ public Object getResource(final Object arg0) {
return null;
}
@@ -46,12 +46,12 @@ public class TransactionSynchronizationRegistryAdapter
implements TransactionSyn
}
@Override
- public void putResource(Object arg0, Object arg1) {
+ public void putResource(final Object arg0, final Object arg1) {
// Noop
}
@Override
- public void registerInterposedSynchronization(Synchronization arg0) {
+ public void registerInterposedSynchronization(final Synchronization arg0) {
// Noop
}