This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-pool.git
The following commit(s) were added to refs/heads/master by this push: new f89b263 Javadoc tweaks. Remove dead whitespace and inline comments. f89b263 is described below commit f89b26358abf547b9cc0f54ffbd1a67265bf9a98 Author: Gary Gregory <gardgreg...@gmail.com> AuthorDate: Wed Jun 23 09:09:42 2021 -0400 Javadoc tweaks. Remove dead whitespace and inline comments. --- .../java/org/apache/commons/pool2/KeyedObjectPool.java | 4 ++-- src/main/java/org/apache/commons/pool2/ObjectPool.java | 4 ++-- src/main/java/org/apache/commons/pool2/PoolUtils.java | 2 +- .../commons/pool2/impl/BaseGenericObjectPool.java | 8 ++++---- .../commons/pool2/impl/DefaultPooledObjectInfo.java | 2 +- .../commons/pool2/impl/GenericKeyedObjectPool.java | 18 +++++++++--------- .../pool2/impl/GenericKeyedObjectPoolConfig.java | 2 +- .../apache/commons/pool2/impl/GenericObjectPool.java | 2 -- .../commons/pool2/impl/InterruptibleReentrantLock.java | 2 +- .../apache/commons/pool2/impl/LinkedBlockingDeque.java | 4 ++-- .../commons/pool2/impl/SecurityManagerCallStack.java | 2 +- .../commons/pool2/impl/SoftReferenceObjectPool.java | 2 +- .../apache/commons/pool2/proxy/BaseProxyHandler.java | 4 ++-- .../apache/commons/pool2/proxy/CglibProxyHandler.java | 2 +- .../apache/commons/pool2/proxy/CglibProxySource.java | 2 +- .../apache/commons/pool2/proxy/JdkProxyHandler.java | 2 +- .../org/apache/commons/pool2/proxy/JdkProxySource.java | 2 +- .../commons/pool2/proxy/ProxiedKeyedObjectPool.java | 2 +- .../apache/commons/pool2/proxy/ProxiedObjectPool.java | 6 +----- .../org/apache/commons/pool2/proxy/ProxySource.java | 4 ++-- .../org/apache/commons/pool2/TestKeyedObjectPool.java | 8 ++++---- .../pool2/impl/TestAbandonedKeyedObjectPool.java | 2 +- .../commons/pool2/impl/TestAbandonedObjectPool.java | 2 +- .../commons/pool2/impl/TestGenericKeyedObjectPool.java | 2 +- .../pool2/impl/TestGenericObjectPoolClassLoaders.java | 1 - .../impl/TestSynchronizedPooledObjectFactory.java | 2 +- 26 files changed, 43 insertions(+), 50 deletions(-) diff --git a/src/main/java/org/apache/commons/pool2/KeyedObjectPool.java b/src/main/java/org/apache/commons/pool2/KeyedObjectPool.java index 2a1acd4..ab52908 100644 --- a/src/main/java/org/apache/commons/pool2/KeyedObjectPool.java +++ b/src/main/java/org/apache/commons/pool2/KeyedObjectPool.java @@ -36,14 +36,14 @@ import java.util.NoSuchElementException; * <code style="color:#00C">try</code> { * obj = pool.borrowObject(key); * <code style="color:#0C0">//...use the object...</code> - * } <code style="color:#00C">catch</code>(Exception e) { + * } <code style="color:#00C">catch</code> (Exception e) { * <code style="color:#0C0">// invalidate the object</code> * pool.invalidateObject(key, obj); * <code style="color:#0C0">// do not return the object to the pool twice</code> * obj = <code style="color:#00C">null</code>; * } <code style="color:#00C">finally</code> { * <code style="color:#0C0">// make sure the object is returned to the pool</code> - * <code style="color:#00C">if</code>(<code style="color:#00C">null</code> != obj) { + * <code style="color:#00C">if</code> (<code style="color:#00C">null</code> != obj) { * pool.returnObject(key, obj); * } * }</pre> diff --git a/src/main/java/org/apache/commons/pool2/ObjectPool.java b/src/main/java/org/apache/commons/pool2/ObjectPool.java index 7a86141..8225d27 100644 --- a/src/main/java/org/apache/commons/pool2/ObjectPool.java +++ b/src/main/java/org/apache/commons/pool2/ObjectPool.java @@ -31,14 +31,14 @@ import java.util.NoSuchElementException; * obj = pool.borrowObject(); * <code style="color:#00C">try</code> { * <code style="color:#0C0">//...use the object...</code> - * } <code style="color:#00C">catch</code>(Exception e) { + * } <code style="color:#00C">catch</code> (Exception e) { * <code style="color:#0C0">// invalidate the object</code> * pool.invalidateObject(obj); * <code style="color:#0C0">// do not return the object to the pool twice</code> * obj = <code style="color:#00C">null</code>; * } <code style="color:#00C">finally</code> { * <code style="color:#0C0">// make sure the object is returned to the pool</code> - * <code style="color:#00C">if</code>(<code style="color:#00C">null</code> != obj) { + * <code style="color:#00C">if</code> (<code style="color:#00C">null</code> != obj) { * pool.returnObject(obj); * } * } diff --git a/src/main/java/org/apache/commons/pool2/PoolUtils.java b/src/main/java/org/apache/commons/pool2/PoolUtils.java index db510a8..bed3257 100644 --- a/src/main/java/org/apache/commons/pool2/PoolUtils.java +++ b/src/main/java/org/apache/commons/pool2/PoolUtils.java @@ -617,7 +617,7 @@ public final class PoolUtils { private final ObjectPool<T> pool; /** - * Create a new ObjectPoolMinIdleTimerTask for the given pool with the + * Constructs a new ObjectPoolMinIdleTimerTask for the given pool with the * given minIdle setting. * * @param pool diff --git a/src/main/java/org/apache/commons/pool2/impl/BaseGenericObjectPool.java b/src/main/java/org/apache/commons/pool2/impl/BaseGenericObjectPool.java index 8dfcfb7..edc8ab0 100644 --- a/src/main/java/org/apache/commons/pool2/impl/BaseGenericObjectPool.java +++ b/src/main/java/org/apache/commons/pool2/impl/BaseGenericObjectPool.java @@ -65,8 +65,8 @@ public abstract class BaseGenericObjectPool<T> extends BaseObject { private final Iterator<PooledObject<T>> idleObjectIterator; /** - * Create an EvictionIterator for the provided idle instance deque. - * @param idleObjects underlying deque + * Constructs an EvictionIterator for the provided idle instance deque. + * @param idleObjects underlying deque. */ EvictionIterator(final Deque<PooledObject<T>> idleObjects) { this.idleObjects = idleObjects; @@ -197,7 +197,7 @@ public abstract class BaseGenericObjectPool<T> extends BaseObject { private final T instance; /** - * Create a wrapper for an instance. + * Constructs a wrapper for an instance. * * @param instance object to wrap */ @@ -244,7 +244,7 @@ public abstract class BaseGenericObjectPool<T> extends BaseObject { private int index; /** - * Create a StatsStore with the given cache size. + * Constructs a StatsStore with the given cache size. * * @param size number of values to maintain in the cache. */ diff --git a/src/main/java/org/apache/commons/pool2/impl/DefaultPooledObjectInfo.java b/src/main/java/org/apache/commons/pool2/impl/DefaultPooledObjectInfo.java index a0e1e36..0087676 100644 --- a/src/main/java/org/apache/commons/pool2/impl/DefaultPooledObjectInfo.java +++ b/src/main/java/org/apache/commons/pool2/impl/DefaultPooledObjectInfo.java @@ -33,7 +33,7 @@ public class DefaultPooledObjectInfo implements DefaultPooledObjectInfoMBean { private final PooledObject<?> pooledObject; /** - * Create a new instance for the given pooled object. + * Constructs a new instance for the given pooled object. * * @param pooledObject The pooled object that this instance will represent */ diff --git a/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java b/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java index 5ee96e1..9774657 100644 --- a/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java +++ b/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java @@ -124,7 +124,7 @@ public class GenericKeyedObjectPool<K, T> extends BaseGenericObjectPool<T> private final AtomicLong numInterested = new AtomicLong(0); /** - * Create a new ObjecDeque with the given fairness policy. + * Constructs a new ObjecDeque with the given fairness policy. * @param fairness true means client threads waiting to borrow / return instances * will be served as if waiting in a FIFO queue. */ @@ -133,7 +133,7 @@ public class GenericKeyedObjectPool<K, T> extends BaseGenericObjectPool<T> } /** - * Obtain all the objects for the current key. + * Gets all the objects for the current key. * * @return All the objects */ @@ -142,7 +142,7 @@ public class GenericKeyedObjectPool<K, T> extends BaseGenericObjectPool<T> } /** - * Obtain the count of the number of objects created for the current + * Gets the count of the number of objects created for the current * key. * * @return The number of objects created for this key @@ -152,7 +152,7 @@ public class GenericKeyedObjectPool<K, T> extends BaseGenericObjectPool<T> } /** - * Obtain the idle objects for the current key. + * Gets the idle objects for the current key. * * @return The idle objects */ @@ -161,7 +161,7 @@ public class GenericKeyedObjectPool<K, T> extends BaseGenericObjectPool<T> } /** - * Obtain the number of threads with an interest registered in this key. + * Gets the number of threads with an interest registered in this key. * * @return The number of threads with a registered interest in this key */ @@ -242,7 +242,7 @@ public class GenericKeyedObjectPool<K, T> extends BaseGenericObjectPool<T> private volatile AbandonedConfig abandonedConfig; /** - * Create a new {@code GenericKeyedObjectPool} using defaults from + * Constructs a new {@code GenericKeyedObjectPool} using defaults from * {@link GenericKeyedObjectPoolConfig}. * @param factory the factory to be used to create entries */ @@ -251,7 +251,7 @@ public class GenericKeyedObjectPool<K, T> extends BaseGenericObjectPool<T> } /** - * Create a new {@code GenericKeyedObjectPool} using a specific + * Constructs a new {@code GenericKeyedObjectPool} using a specific * configuration. * * @param factory the factory to be used to create entries @@ -707,7 +707,7 @@ public class GenericKeyedObjectPool<K, T> extends BaseGenericObjectPool<T> } /** - * Create a new pooled object. + * Creates a new pooled object. * * @param key Key associated with new pooled object * @@ -1084,7 +1084,7 @@ public class GenericKeyedObjectPool<K, T> extends BaseGenericObjectPool<T> } /** - * Obtain a reference to the factory used to create, destroy and validate + * Gets a reference to the factory used to create, destroy and validate * the objects used by this pool. * * @return the factory diff --git a/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPoolConfig.java b/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPoolConfig.java index 827210a..d0a74dc 100644 --- a/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPoolConfig.java +++ b/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPoolConfig.java @@ -64,7 +64,7 @@ public class GenericKeyedObjectPoolConfig<T> extends BaseObjectPoolConfig<T> { private int maxTotal = DEFAULT_MAX_TOTAL; /** - * Create a new configuration with default settings. + * Constructs a new configuration with default settings. */ public GenericKeyedObjectPoolConfig() { } diff --git a/src/main/java/org/apache/commons/pool2/impl/GenericObjectPool.java b/src/main/java/org/apache/commons/pool2/impl/GenericObjectPool.java index ca0af35..d9fe585 100644 --- a/src/main/java/org/apache/commons/pool2/impl/GenericObjectPool.java +++ b/src/main/java/org/apache/commons/pool2/impl/GenericObjectPool.java @@ -1020,8 +1020,6 @@ public class GenericObjectPool<T> extends BaseGenericObjectPool<T> ensureIdle(1, false); } - // --- configuration attributes -------------------------------------------- - /** * Gets whether or not abandoned object removal is configured for this pool. * diff --git a/src/main/java/org/apache/commons/pool2/impl/InterruptibleReentrantLock.java b/src/main/java/org/apache/commons/pool2/impl/InterruptibleReentrantLock.java index ac0120b..1f1b322 100644 --- a/src/main/java/org/apache/commons/pool2/impl/InterruptibleReentrantLock.java +++ b/src/main/java/org/apache/commons/pool2/impl/InterruptibleReentrantLock.java @@ -35,7 +35,7 @@ class InterruptibleReentrantLock extends ReentrantLock { private static final long serialVersionUID = 1L; /** - * Create a new InterruptibleReentrantLock with the given fairness policy. + * Constructs a new InterruptibleReentrantLock with the given fairness policy. * * @param fairness true means threads should acquire contended locks as if * waiting in a FIFO queue diff --git a/src/main/java/org/apache/commons/pool2/impl/LinkedBlockingDeque.java b/src/main/java/org/apache/commons/pool2/impl/LinkedBlockingDeque.java index 00f4b18..69b69cb 100644 --- a/src/main/java/org/apache/commons/pool2/impl/LinkedBlockingDeque.java +++ b/src/main/java/org/apache/commons/pool2/impl/LinkedBlockingDeque.java @@ -116,7 +116,7 @@ class LinkedBlockingDeque<E> extends AbstractQueue<E> private Node<E> lastRet; /** - * Create a new iterator. Sets the initial position. + * Constructs a new iterator. Sets the initial position. */ AbstractItr() { // set to initial position @@ -263,7 +263,7 @@ class LinkedBlockingDeque<E> extends AbstractQueue<E> Node<E> next; /** - * Create a new list node. + * Constructs a new list node. * * @param x The list item * @param p Previous item diff --git a/src/main/java/org/apache/commons/pool2/impl/SecurityManagerCallStack.java b/src/main/java/org/apache/commons/pool2/impl/SecurityManagerCallStack.java index 8a9ce42..5c586a2 100644 --- a/src/main/java/org/apache/commons/pool2/impl/SecurityManagerCallStack.java +++ b/src/main/java/org/apache/commons/pool2/impl/SecurityManagerCallStack.java @@ -64,7 +64,7 @@ public class SecurityManagerCallStack implements CallStack { private final List<WeakReference<Class<?>>> stack; /** - * Create a new snapshot with a class stack. + * Constructs a new snapshot with a class stack. * * @param stack class stack */ diff --git a/src/main/java/org/apache/commons/pool2/impl/SoftReferenceObjectPool.java b/src/main/java/org/apache/commons/pool2/impl/SoftReferenceObjectPool.java index 1b771e1..de18fc2 100644 --- a/src/main/java/org/apache/commons/pool2/impl/SoftReferenceObjectPool.java +++ b/src/main/java/org/apache/commons/pool2/impl/SoftReferenceObjectPool.java @@ -70,7 +70,7 @@ public class SoftReferenceObjectPool<T> extends BaseObjectPool<T> { new ArrayList<>(); /** - * Create a {@code SoftReferenceObjectPool} with the specified factory. + * Constructs a {@code SoftReferenceObjectPool} with the specified factory. * * @param factory object factory to use. */ diff --git a/src/main/java/org/apache/commons/pool2/proxy/BaseProxyHandler.java b/src/main/java/org/apache/commons/pool2/proxy/BaseProxyHandler.java index 26c571a..c22798d 100644 --- a/src/main/java/org/apache/commons/pool2/proxy/BaseProxyHandler.java +++ b/src/main/java/org/apache/commons/pool2/proxy/BaseProxyHandler.java @@ -35,7 +35,7 @@ class BaseProxyHandler<T> { /** - * Create a new wrapper for the given pooled object. + * Constructs a new wrapper for the given pooled object. * * @param pooledObject The object to wrap * @param usageTracking The instance, if any (usually the object pool) to @@ -81,7 +81,7 @@ class BaseProxyHandler<T> { /** - * Obtain the wrapped, pooled object. + * Gets the wrapped, pooled object. * * @return the underlying pooled object */ diff --git a/src/main/java/org/apache/commons/pool2/proxy/CglibProxyHandler.java b/src/main/java/org/apache/commons/pool2/proxy/CglibProxyHandler.java index 1ff3891..63ce61b 100644 --- a/src/main/java/org/apache/commons/pool2/proxy/CglibProxyHandler.java +++ b/src/main/java/org/apache/commons/pool2/proxy/CglibProxyHandler.java @@ -35,7 +35,7 @@ class CglibProxyHandler<T> extends BaseProxyHandler<T> /** - * Create a CGLib proxy instance. + * Constructs a CGLib proxy instance. * * @param pooledObject The object to wrap * @param usageTracking The instance, if any (usually the object pool) to diff --git a/src/main/java/org/apache/commons/pool2/proxy/CglibProxySource.java b/src/main/java/org/apache/commons/pool2/proxy/CglibProxySource.java index 15592be..d825e8b 100644 --- a/src/main/java/org/apache/commons/pool2/proxy/CglibProxySource.java +++ b/src/main/java/org/apache/commons/pool2/proxy/CglibProxySource.java @@ -33,7 +33,7 @@ public class CglibProxySource<T> implements ProxySource<T> { private final Class<? extends T> superclass; /** - * Create a new proxy source for the given class. + * Constructs a new proxy source for the given class. * * @param superclass The class to proxy */ diff --git a/src/main/java/org/apache/commons/pool2/proxy/JdkProxyHandler.java b/src/main/java/org/apache/commons/pool2/proxy/JdkProxyHandler.java index b1f8636..451a6b7 100644 --- a/src/main/java/org/apache/commons/pool2/proxy/JdkProxyHandler.java +++ b/src/main/java/org/apache/commons/pool2/proxy/JdkProxyHandler.java @@ -32,7 +32,7 @@ class JdkProxyHandler<T> extends BaseProxyHandler<T> implements InvocationHandler { /** - * Create a Java reflection proxy instance. + * Constructs a Java reflection proxy instance. * * @param pooledObject The object to wrap * @param usageTracking The instance, if any (usually the object pool) to diff --git a/src/main/java/org/apache/commons/pool2/proxy/JdkProxySource.java b/src/main/java/org/apache/commons/pool2/proxy/JdkProxySource.java index b2036c9..f56620f 100644 --- a/src/main/java/org/apache/commons/pool2/proxy/JdkProxySource.java +++ b/src/main/java/org/apache/commons/pool2/proxy/JdkProxySource.java @@ -35,7 +35,7 @@ public class JdkProxySource<T> implements ProxySource<T> { /** - * Create a new proxy source for the given interfaces. + * Constructs a new proxy source for the given interfaces. * * @param classLoader The class loader with which to create the proxy * @param interfaces The interfaces to proxy diff --git a/src/main/java/org/apache/commons/pool2/proxy/ProxiedKeyedObjectPool.java b/src/main/java/org/apache/commons/pool2/proxy/ProxiedKeyedObjectPool.java index 58ba10d..e87ee74 100644 --- a/src/main/java/org/apache/commons/pool2/proxy/ProxiedKeyedObjectPool.java +++ b/src/main/java/org/apache/commons/pool2/proxy/ProxiedKeyedObjectPool.java @@ -39,7 +39,7 @@ public class ProxiedKeyedObjectPool<K, V> implements KeyedObjectPool<K, V> { /** - * Create a new proxied object pool. + * Constructs a new proxied object pool. * * @param pool The object pool to wrap * @param proxySource The source of the proxy objects diff --git a/src/main/java/org/apache/commons/pool2/proxy/ProxiedObjectPool.java b/src/main/java/org/apache/commons/pool2/proxy/ProxiedObjectPool.java index cadb180..60785b3 100644 --- a/src/main/java/org/apache/commons/pool2/proxy/ProxiedObjectPool.java +++ b/src/main/java/org/apache/commons/pool2/proxy/ProxiedObjectPool.java @@ -38,7 +38,7 @@ public class ProxiedObjectPool<T> implements ObjectPool<T> { /** - * Create a new proxied object pool. + * Constructs a new proxied object pool. * * @param pool The object pool to wrap * @param proxySource The source of the proxy objects @@ -48,9 +48,6 @@ public class ProxiedObjectPool<T> implements ObjectPool<T> { this.proxySource = proxySource; } - - // --------------------------------------------------- ObjectPool<T> methods - @Override public void addObject() throws Exception, IllegalStateException, UnsupportedOperationException { @@ -108,7 +105,6 @@ public class ProxiedObjectPool<T> implements ObjectPool<T> { pool.returnObject(pooledObject); } - /** * @since 2.4.3 */ diff --git a/src/main/java/org/apache/commons/pool2/proxy/ProxySource.java b/src/main/java/org/apache/commons/pool2/proxy/ProxySource.java index 000884f..e756857 100644 --- a/src/main/java/org/apache/commons/pool2/proxy/ProxySource.java +++ b/src/main/java/org/apache/commons/pool2/proxy/ProxySource.java @@ -29,7 +29,7 @@ import org.apache.commons.pool2.UsageTracking; interface ProxySource<T> { /** - * Create a new proxy object, wrapping the given pooled object. + * Creates a new proxy object, wrapping the given pooled object. * * @param pooledObject The object to wrap * @param usageTracking The instance, if any (usually the object pool) to @@ -41,7 +41,7 @@ interface ProxySource<T> { T createProxy(T pooledObject, UsageTracking<T> usageTracking); /** - * Obtain the wrapped object from the given proxy. + * Resolves the wrapped object from the given proxy. * * @param proxy The proxy object * diff --git a/src/test/java/org/apache/commons/pool2/TestKeyedObjectPool.java b/src/test/java/org/apache/commons/pool2/TestKeyedObjectPool.java index bfc35f5..9d9eee4 100644 --- a/src/test/java/org/apache/commons/pool2/TestKeyedObjectPool.java +++ b/src/test/java/org/apache/commons/pool2/TestKeyedObjectPool.java @@ -202,7 +202,7 @@ public abstract class TestKeyedObjectPool { protected abstract boolean isLifo(); /** - * Create an {@link KeyedObjectPool} instance + * Creates an {@link KeyedObjectPool} instance * that can contain at least <i>minCapacity</i> * idle and active objects, or * throw {@link IllegalArgumentException} @@ -212,8 +212,9 @@ public abstract class TestKeyedObjectPool { * @return the newly created keyed object pool */ protected abstract KeyedObjectPool<Object,Object> makeEmptyPool(int minCapacity); + /** - * Create an {@code KeyedObjectPool} with the specified factory. + * Creates an {@code KeyedObjectPool} with the specified factory. * The pool should be in a default configuration and conform to the expected * behaviors described in {@link KeyedObjectPool}. * Generally speaking there should be no limits on the various object counts. @@ -221,8 +222,7 @@ public abstract class TestKeyedObjectPool { * @param factory Factory to use to associate with the pool * @return The newly created empty pool */ - protected abstract KeyedObjectPool<Object,Object> makeEmptyPool( - KeyedPooledObjectFactory<Object,Object> factory); + protected abstract KeyedObjectPool<Object, Object> makeEmptyPool(KeyedPooledObjectFactory<Object, Object> factory); protected abstract Object makeKey(int n); diff --git a/src/test/java/org/apache/commons/pool2/impl/TestAbandonedKeyedObjectPool.java b/src/test/java/org/apache/commons/pool2/impl/TestAbandonedKeyedObjectPool.java index 2af1dec..01a6265 100644 --- a/src/test/java/org/apache/commons/pool2/impl/TestAbandonedKeyedObjectPool.java +++ b/src/test/java/org/apache/commons/pool2/impl/TestAbandonedKeyedObjectPool.java @@ -144,7 +144,7 @@ public class TestAbandonedKeyedObjectPool { public void setUp() throws Exception { abandonedConfig = new AbandonedConfig(); - // -- Uncomment the following line to enable logging -- + // Uncomment the following line to enable logging: // abandonedConfig.setLogAbandoned(true); abandonedConfig.setRemoveAbandonedOnBorrow(true); diff --git a/src/test/java/org/apache/commons/pool2/impl/TestAbandonedObjectPool.java b/src/test/java/org/apache/commons/pool2/impl/TestAbandonedObjectPool.java index 4e198c7..14b264c 100644 --- a/src/test/java/org/apache/commons/pool2/impl/TestAbandonedObjectPool.java +++ b/src/test/java/org/apache/commons/pool2/impl/TestAbandonedObjectPool.java @@ -224,7 +224,7 @@ public class TestAbandonedObjectPool { public void setUp() throws Exception { abandonedConfig = new AbandonedConfig(); - // -- Uncomment the following line to enable logging -- + // Uncomment the following line to enable logging: // abandonedConfig.setLogAbandoned(true); abandonedConfig.setRemoveAbandonedOnBorrow(true); diff --git a/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java b/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java index 62a1f0a..39e898c 100644 --- a/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java +++ b/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java @@ -324,7 +324,7 @@ public class TestGenericKeyedObjectPool extends TestKeyedObjectPool { private final long delay; /** - * Create SlowEvictionPolicy with the given delay in ms + * Constructs SlowEvictionPolicy with the given delay in ms * * @param delay number of ms of latency to inject in evict */ diff --git a/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPoolClassLoaders.java b/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPoolClassLoaders.java index aa1ec99..c7731f0 100644 --- a/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPoolClassLoaders.java +++ b/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPoolClassLoaders.java @@ -96,7 +96,6 @@ public class TestGenericObjectPoolClassLoaders { } assertEquals( 1, pool1.getNumIdle(),"Wrong number of idle objects in pool1"); - // --------------- final CustomClassLoader cl2 = new CustomClassLoader(2); Thread.currentThread().setContextClassLoader(cl2); final CustomClassLoaderObjectFactory factory2 = diff --git a/src/test/java/org/apache/commons/pool2/impl/TestSynchronizedPooledObjectFactory.java b/src/test/java/org/apache/commons/pool2/impl/TestSynchronizedPooledObjectFactory.java index 5ab5dc0..53d7fe3 100644 --- a/src/test/java/org/apache/commons/pool2/impl/TestSynchronizedPooledObjectFactory.java +++ b/src/test/java/org/apache/commons/pool2/impl/TestSynchronizedPooledObjectFactory.java @@ -43,7 +43,7 @@ final class TestSynchronizedPooledObjectFactory<T> implements PooledObjectFactor private final PooledObjectFactory<T> factory; /** - * Create a SynchronizedPoolableObjectFactory wrapping the given factory. + * Constructs a SynchronizedPoolableObjectFactory wrapping the given factory. * * @param factory * underlying factory to wrap