This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-vfs.git
commit 721ad0345eaa0082b49386b1c6eaa741a63319ba Author: Gary Gregory <garydgreg...@gmail.com> AuthorDate: Sat Mar 27 16:06:36 2021 -0400 Better private name, add @SuppressWarnings with comment, comment empty block. --- .../org/apache/commons/vfs2/provider/AbstractFileName.java | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/AbstractFileName.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/AbstractFileName.java index ec0c101..8490685 100644 --- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/AbstractFileName.java +++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/AbstractFileName.java @@ -46,8 +46,8 @@ public abstract class AbstractFileName implements FileName { private final String absPath; private FileType type; - // Cached stuff - private String uri; + // Cached attributes + private String uriString; private String baseName; private String rootUri; private String extension; @@ -233,10 +233,10 @@ public abstract class AbstractFileName implements FileName { */ @Override public String getURI() { - if (uri == null) { - uri = createURI(); + if (uriString == null) { + uriString = createURI(); } - return uri; + return uriString; } protected String createURI() { @@ -314,6 +314,7 @@ public abstract class AbstractFileName implements FileName { final int maxlen = Math.min(basePathLen, pathLen); int pos = 0; for (; pos < maxlen && getPath().charAt(pos) == path.charAt(pos); pos++) { + // empty } if (pos == basePathLen && pos == pathLen) {