This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-compress.git

commit 6082d6448ca1b3e922e0298707b33642ee90c587
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Fri Mar 5 15:55:32 2021 -0500

    Fix test leaking file handles.
---
 .../commons/compress/DetectArchiverTestCase.java   | 42 ++++++++++++----------
 1 file changed, 24 insertions(+), 18 deletions(-)

diff --git 
a/src/test/java/org/apache/commons/compress/DetectArchiverTestCase.java 
b/src/test/java/org/apache/commons/compress/DetectArchiverTestCase.java
index 8257dce..1212271 100644
--- a/src/test/java/org/apache/commons/compress/DetectArchiverTestCase.java
+++ b/src/test/java/org/apache/commons/compress/DetectArchiverTestCase.java
@@ -67,29 +67,35 @@ public final class DetectArchiverTestCase extends 
AbstractTestCase {
     @Test
     public void testDetection() throws Exception {
 
-        final ArchiveInputStream ar = getStreamFor("bla.ar");
-        assertNotNull(ar);
-        assertTrue(ar instanceof ArArchiveInputStream);
+        try (final ArchiveInputStream ar = getStreamFor("bla.ar")) {
+            assertNotNull(ar);
+            assertTrue(ar instanceof ArArchiveInputStream);
+        }
 
-        final ArchiveInputStream tar = getStreamFor("bla.tar");
-        assertNotNull(tar);
-        assertTrue(tar instanceof TarArchiveInputStream);
+        try (final ArchiveInputStream tar = getStreamFor("bla.tar")) {
+            assertNotNull(tar);
+            assertTrue(tar instanceof TarArchiveInputStream);
+        }
 
-        final ArchiveInputStream zip = getStreamFor("bla.zip");
-        assertNotNull(zip);
-        assertTrue(zip instanceof ZipArchiveInputStream);
+        try (final ArchiveInputStream zip = getStreamFor("bla.zip")) {
+            assertNotNull(zip);
+            assertTrue(zip instanceof ZipArchiveInputStream);
+        }
 
-        final ArchiveInputStream jar = getStreamFor("bla.jar");
-        assertNotNull(jar);
-        assertTrue(jar instanceof ZipArchiveInputStream);
+        try (final ArchiveInputStream jar = getStreamFor("bla.jar")) {
+            assertNotNull(jar);
+            assertTrue(jar instanceof ZipArchiveInputStream);
+        }
 
-        final ArchiveInputStream cpio = getStreamFor("bla.cpio");
-        assertNotNull(cpio);
-        assertTrue(cpio instanceof CpioArchiveInputStream);
+        try (final ArchiveInputStream cpio = getStreamFor("bla.cpio")) {
+            assertNotNull(cpio);
+            assertTrue(cpio instanceof CpioArchiveInputStream);
+        }
 
-        final ArchiveInputStream arj = getStreamFor("bla.arj");
-        assertNotNull(arj);
-        assertTrue(arj instanceof ArjArchiveInputStream);
+        try (final ArchiveInputStream arj = getStreamFor("bla.arj")) {
+            assertNotNull(arj);
+            assertTrue(arj instanceof ArjArchiveInputStream);
+        }
 
 // Not yet implemented
 //        final ArchiveInputStream tgz = getStreamFor("bla.tgz");

Reply via email to