This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-email.git

commit 4c10370ac86c1bf78548b9f39e8158a21d6796c9
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Fri Mar 5 13:59:59 2021 -0500

    No need to nest in else.
---
 src/main/java/org/apache/commons/mail/Email.java | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/main/java/org/apache/commons/mail/Email.java 
b/src/main/java/org/apache/commons/mail/Email.java
index cbc23a1..16a8ac2 100644
--- a/src/main/java/org/apache/commons/mail/Email.java
+++ b/src/main/java/org/apache/commons/mail/Email.java
@@ -1558,7 +1558,7 @@ public abstract class Email
         {
             return this.session.getProperty(EmailConstants.MAIL_HOST);
         }
-        else if (EmailUtils.isNotEmpty(this.hostName))
+        if (EmailUtils.isNotEmpty(this.hostName))
         {
             return this.hostName;
         }
@@ -1576,7 +1576,7 @@ public abstract class Email
         {
             return this.session.getProperty(EmailConstants.MAIL_PORT);
         }
-        else if (EmailUtils.isNotEmpty(this.smtpPort))
+        if (EmailUtils.isNotEmpty(this.smtpPort))
         {
             return this.smtpPort;
         }
@@ -1746,7 +1746,7 @@ public abstract class Email
         {
             return 
this.session.getProperty(EmailConstants.MAIL_SMTP_SOCKET_FACTORY_PORT);
         }
-        else if (EmailUtils.isNotEmpty(this.sslSmtpPort))
+        if (EmailUtils.isNotEmpty(this.sslSmtpPort))
         {
             return this.sslSmtpPort;
         }

Reply via email to