[commons-ognl] branch master updated: Remove use of redundant String.substring() parameter.

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-ognl.git


The following commit(s) were added to refs/heads/master by this push:
     new 45fc593  Remove use of redundant String.substring() parameter.
45fc593 is described below

commit 45fc59324c101d4ab7c7339282f8b23d08c829ca
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Sun Feb 28 09:40:10 2021 -0500

    Remove use of redundant String.substring() parameter.
---
 src/main/java/org/apache/commons/ognl/ASTAdd.java                     | 4 ++--
 .../org/apache/commons/ognl/internal/ConcurrentHashMapCacheTest.java  | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/main/java/org/apache/commons/ognl/ASTAdd.java 
b/src/main/java/org/apache/commons/ognl/ASTAdd.java
index f0d7777..b7aaae8 100644
--- a/src/main/java/org/apache/commons/ognl/ASTAdd.java
+++ b/src/main/java/org/apache/commons/ognl/ASTAdd.java
@@ -215,7 +215,7 @@ class ASTAdd
                         // dirty fix for overly aggressive casting dot 
operations
                         if ( rootExpr.endsWith( "." ) && chain != null && 
chain.startsWith( ")." ) )
                         {
-                            chain = chain.substring( 1, chain.length() );
+                            chain = chain.substring( 1 );
                         }
 
                         expr = rootExpr + ( chain != null ? chain + "." : "" ) 
+ expr;
@@ -235,7 +235,7 @@ class ASTAdd
                         if ( !ASTProperty.class.isInstance( 
children[i].jjtGetChild( 0 ) ) && rootExpr.endsWith( ")" )
                             && expr.startsWith( ")" ) )
                         {
-                            expr = expr.substring( 1, expr.length() );
+                            expr = expr.substring( 1 );
                         }
 
                         expr = rootExpr + expr;
diff --git 
a/src/test/java/org/apache/commons/ognl/internal/ConcurrentHashMapCacheTest.java
 
b/src/test/java/org/apache/commons/ognl/internal/ConcurrentHashMapCacheTest.java
index 9614c34..a7861d1 100644
--- 
a/src/test/java/org/apache/commons/ognl/internal/ConcurrentHashMapCacheTest.java
+++ 
b/src/test/java/org/apache/commons/ognl/internal/ConcurrentHashMapCacheTest.java
@@ -89,7 +89,7 @@ public class ConcurrentHashMapCacheTest
             for ( Method method : methods )
             {
                 String name = method.getName( );
-                boolean isGet = name.substring( 3, name.length( ) 
).equalsIgnoreCase( key.getMethodName( ) );
+                boolean isGet = name.substring( 3 ).equalsIgnoreCase( 
key.getMethodName( ) );
                 if ( isGet )
                 {
                     list.add( method );