This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-jcs.git
The following commit(s) were added to refs/heads/master by this push: new 0bc464c Remove use of redundant String.substring() parameter. 0bc464c is described below commit 0bc464c496f96c47c29f206d39b7db3b66345fb9 Author: Gary Gregory <garydgreg...@gmail.com> AuthorDate: Sun Feb 28 09:32:46 2021 -0500 Remove use of redundant String.substring() parameter. --- .../apache/commons/jcs3/utils/config/OptionConverter.java | 2 +- .../org/apache/commons/jcs3/access/TestCacheAccess.java | 14 +++++++------- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/commons-jcs-core/src/main/java/org/apache/commons/jcs3/utils/config/OptionConverter.java b/commons-jcs-core/src/main/java/org/apache/commons/jcs3/utils/config/OptionConverter.java index 535cba3..1cde26b 100644 --- a/commons-jcs-core/src/main/java/org/apache/commons/jcs3/utils/config/OptionConverter.java +++ b/commons-jcs-core/src/main/java/org/apache/commons/jcs3/utils/config/OptionConverter.java @@ -393,7 +393,7 @@ public class OptionConverter { return val; } - sbuf.append( val.substring( i, val.length() ) ); + sbuf.append( val.substring( i ) ); return sbuf.toString(); } sbuf.append( val.substring( i, j ) ); diff --git a/commons-jcs-core/src/test/java/org/apache/commons/jcs3/access/TestCacheAccess.java b/commons-jcs-core/src/test/java/org/apache/commons/jcs3/access/TestCacheAccess.java index 779d5ea..4617b49 100644 --- a/commons-jcs-core/src/test/java/org/apache/commons/jcs3/access/TestCacheAccess.java +++ b/commons-jcs-core/src/test/java/org/apache/commons/jcs3/access/TestCacheAccess.java @@ -166,7 +166,7 @@ public class TestCacheAccess } else if ( message.startsWith( "putm" ) ) { - final String numS = message.substring( message.indexOf( " " ) + 1, message.length() ); + final String numS = message.substring( message.indexOf( " " ) + 1 ); if ( numS == null ) { p( "usage: putm numbertoput" ); @@ -179,7 +179,7 @@ public class TestCacheAccess } else if ( message.startsWith( "pute" ) ) { - final String numS = message.substring( message.indexOf( " " ) + 1, message.length() ); + final String numS = message.substring( message.indexOf( " " ) + 1 ); if ( numS == null ) { p( "usage: putme numbertoput" ); @@ -205,7 +205,7 @@ public class TestCacheAccess } else if ( message.startsWith( "removem" ) ) { - final String numS = message.substring( message.indexOf( " " ) + 1, message.length() ); + final String numS = message.substring( message.indexOf( " " ) + 1 ); if ( numS == null ) { p( "usage: removem numbertoremove" ); @@ -223,7 +223,7 @@ public class TestCacheAccess } else if ( message.startsWith( "remove" ) ) { - final String key = message.substring( message.indexOf( " " ) + 1, message.length() ); + final String key = message.substring( message.indexOf( " " ) + 1 ); cache_control.remove( key ); p( "removed " + key ); } @@ -234,7 +234,7 @@ public class TestCacheAccess } else if ( message.startsWith( "cloneattr" ) ) { - final String numS = message.substring( message.indexOf( " " ) + 1, message.length() ); + final String numS = message.substring( message.indexOf( " " ) + 1 ); if ( numS == null ) { p( "usage: put numbertoput" ); @@ -254,7 +254,7 @@ public class TestCacheAccess } else if ( message.startsWith( "switch" ) ) { - final String name = message.substring( message.indexOf( " " ) + 1, message.length() ); + final String name = message.substring( message.indexOf( " " ) + 1 ); setRegion( name ); p( "switched to cache = " + name ); @@ -582,7 +582,7 @@ public class TestCacheAccess } } - final String numS = message.substring( message.indexOf( " " ) + 1, message.length() ); + final String numS = message.substring( message.indexOf( " " ) + 1 ); int range = 0; int numOps = 0;