This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-bsf.git


The following commit(s) were added to refs/heads/master by this push:
     new 5176e34  Remove use of redundant String.substring() parameter.
5176e34 is described below

commit 5176e34e3128923ced0e32bd318c1845fda4d740
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Sun Feb 28 09:25:41 2021 -0500

    Remove use of redundant String.substring() parameter.
---
 src/main/java/org/apache/bsf/BSFManager.java           | 2 +-
 src/test/java/org/apache/bsf/BSFEngineTestTmpl.java    | 2 --
 src/test/java/org/apache/bsf/FakeEngine.java           | 1 -
 src/test/java/org/apache/bsf/util/EngineUtilsTest.java | 2 --
 src/test/java/org/apache/bsf/util/IOUtilsTest.java     | 2 --
 src/test/java/org/apache/bsf/util/StringUtilsTest.java | 2 --
 6 files changed, 1 insertion(+), 10 deletions(-)

diff --git a/src/main/java/org/apache/bsf/BSFManager.java 
b/src/main/java/org/apache/bsf/BSFManager.java
index 647008a..7584cc9 100644
--- a/src/main/java/org/apache/bsf/BSFManager.java
+++ b/src/main/java/org/apache/bsf/BSFManager.java
@@ -184,7 +184,7 @@ public class BSFManager {
 
 
                     // get the extensions for this language
-                    final String exts = value.substring(value.indexOf(",")+1, 
value.length());
+                    final String exts = value.substring(value.indexOf(",")+1);
                     final StringTokenizer st = new StringTokenizer(exts, "|");
                     final String[] extensions = new String[st.countTokens()];
 
diff --git a/src/test/java/org/apache/bsf/BSFEngineTestTmpl.java 
b/src/test/java/org/apache/bsf/BSFEngineTestTmpl.java
index 496d6c5..00ff53a 100644
--- a/src/test/java/org/apache/bsf/BSFEngineTestTmpl.java
+++ b/src/test/java/org/apache/bsf/BSFEngineTestTmpl.java
@@ -22,8 +22,6 @@ import java.io.PrintStream;
 
 import junit.framework.TestCase;
 
-import org.apache.bsf.BSFManager;
-
 /**
  * Superclass for language engine tests.
  * @author   Victor J. Orlikowski <v...@us.ibm.com>
diff --git a/src/test/java/org/apache/bsf/FakeEngine.java 
b/src/test/java/org/apache/bsf/FakeEngine.java
index 4375a99..fb148a2 100644
--- a/src/test/java/org/apache/bsf/FakeEngine.java
+++ b/src/test/java/org/apache/bsf/FakeEngine.java
@@ -17,7 +17,6 @@
 
 package org.apache.bsf;
 
-import org.apache.bsf.BSFException;
 import org.apache.bsf.util.BSFEngineImpl;
 
 public class FakeEngine extends BSFEngineImpl {
diff --git a/src/test/java/org/apache/bsf/util/EngineUtilsTest.java 
b/src/test/java/org/apache/bsf/util/EngineUtilsTest.java
index 538ae3e..bce31ad 100644
--- a/src/test/java/org/apache/bsf/util/EngineUtilsTest.java
+++ b/src/test/java/org/apache/bsf/util/EngineUtilsTest.java
@@ -18,8 +18,6 @@
 package org.apache.bsf.util;
 
 import org.apache.bsf.BSFException;
-import org.apache.bsf.util.EngineUtils;
-
 import junit.framework.TestCase;
 
 /**
diff --git a/src/test/java/org/apache/bsf/util/IOUtilsTest.java 
b/src/test/java/org/apache/bsf/util/IOUtilsTest.java
index 94fdf15..ce0052b 100644
--- a/src/test/java/org/apache/bsf/util/IOUtilsTest.java
+++ b/src/test/java/org/apache/bsf/util/IOUtilsTest.java
@@ -27,8 +27,6 @@ import java.io.PrintWriter;
 import java.io.StringReader;
 import java.io.StringWriter;
 
-import org.apache.bsf.util.IOUtils;
-
 import junit.framework.TestCase;
 
 /**
diff --git a/src/test/java/org/apache/bsf/util/StringUtilsTest.java 
b/src/test/java/org/apache/bsf/util/StringUtilsTest.java
index 038049c..cd2c562 100644
--- a/src/test/java/org/apache/bsf/util/StringUtilsTest.java
+++ b/src/test/java/org/apache/bsf/util/StringUtilsTest.java
@@ -27,8 +27,6 @@ import java.io.Reader;
 import java.net.MalformedURLException;
 import java.util.Vector;
 
-import org.apache.bsf.util.StringUtils;
-
 import junit.framework.TestCase;
 
 /**

Reply via email to