This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-vfs.git
commit 5eaac898b4fa68634592b997cecaef3bd8e2670f Author: Gary Gregory <garydgreg...@gmail.com> AuthorDate: Fri Feb 19 09:59:05 2021 -0500 Use final and remove unused imports. --- .../java/org/apache/commons/vfs2/provider/http/HttpClientFactory.java | 2 -- .../commons/vfs2/provider/ftp/FtpFileSystemConfigBuilderTestCase.java | 4 ++-- .../apache/commons/vfs2/provider/ftp/FtpProviderMdtmOffTestCase.java | 2 +- .../org/apache/commons/vfs2/provider/ftp/FtpProviderTestCase.java | 4 ++-- .../vfs2/provider/sftp/SftpFileSystemConfigBuilderTestCase.java | 4 ++-- 5 files changed, 7 insertions(+), 9 deletions(-) diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/http/HttpClientFactory.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/http/HttpClientFactory.java index fabe2ae..20c5dc1 100644 --- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/http/HttpClientFactory.java +++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/http/HttpClientFactory.java @@ -16,8 +16,6 @@ */ package org.apache.commons.vfs2.provider.http; -import java.time.Duration; - import org.apache.commons.httpclient.Cookie; import org.apache.commons.httpclient.HostConfiguration; import org.apache.commons.httpclient.HttpClient; diff --git a/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/ftp/FtpFileSystemConfigBuilderTestCase.java b/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/ftp/FtpFileSystemConfigBuilderTestCase.java index e73f77b..7d2791e 100644 --- a/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/ftp/FtpFileSystemConfigBuilderTestCase.java +++ b/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/ftp/FtpFileSystemConfigBuilderTestCase.java @@ -32,7 +32,7 @@ public class FtpFileSystemConfigBuilderTestCase { @Test public void testControlKeepAliveReplyTimeout() { final FtpFileSystemConfigBuilder instance = FtpFileSystemConfigBuilder.getInstance(); - FileSystemOptions options = new FileSystemOptions(); + final FileSystemOptions options = new FileSystemOptions(); instance.setControlKeepAliveReplyTimeout(options, Duration.ofSeconds(10)); assertEquals(Duration.ofSeconds(10), instance.getControlKeepAliveReplyTimeout(options)); } @@ -40,7 +40,7 @@ public class FtpFileSystemConfigBuilderTestCase { @Test public void testControlKeepAliveTimeout() { final FtpFileSystemConfigBuilder instance = FtpFileSystemConfigBuilder.getInstance(); - FileSystemOptions options = new FileSystemOptions(); + final FileSystemOptions options = new FileSystemOptions(); instance.setControlKeepAliveTimeout(options, Duration.ofSeconds(10)); assertEquals(Duration.ofSeconds(10), instance.getControlKeepAliveTimeout(options)); } diff --git a/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/ftp/FtpProviderMdtmOffTestCase.java b/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/ftp/FtpProviderMdtmOffTestCase.java index c560428..f78a703 100644 --- a/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/ftp/FtpProviderMdtmOffTestCase.java +++ b/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/ftp/FtpProviderMdtmOffTestCase.java @@ -48,7 +48,7 @@ public class FtpProviderMdtmOffTestCase extends FtpProviderTestCase { factory.addCommand(commandName, new Command() { @Override - public void execute(FtpIoSession session, FtpServerContext context, FtpRequest request) + public void execute(final FtpIoSession session, final FtpServerContext context, final FtpRequest request) throws IOException, FtpException { session.resetState(); diff --git a/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/ftp/FtpProviderTestCase.java b/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/ftp/FtpProviderTestCase.java index 41f0f04..4aa7449 100644 --- a/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/ftp/FtpProviderTestCase.java +++ b/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/ftp/FtpProviderTestCase.java @@ -126,7 +126,7 @@ public class FtpProviderTestCase extends AbstractProviderTestConfig { * Creates the test suite for subclasses of the FTP file system. */ protected static Test suite(final FtpProviderTestCase testCase, - Class<? extends AbstractProviderTestCase>... testClasses) throws Exception { + final Class<? extends AbstractProviderTestCase>... testClasses) throws Exception { return new ProviderTestSuite(testCase) { @Override @@ -179,7 +179,7 @@ public class FtpProviderTestCase extends AbstractProviderTestConfig { this(false); } - public FtpProviderTestCase(boolean mdtmLastModifiedTime) { + public FtpProviderTestCase(final boolean mdtmLastModifiedTime) { this.mdtmLastModifiedTime = mdtmLastModifiedTime; } diff --git a/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/sftp/SftpFileSystemConfigBuilderTestCase.java b/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/sftp/SftpFileSystemConfigBuilderTestCase.java index a45cf17..97c95cb 100644 --- a/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/sftp/SftpFileSystemConfigBuilderTestCase.java +++ b/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/sftp/SftpFileSystemConfigBuilderTestCase.java @@ -33,7 +33,7 @@ public class SftpFileSystemConfigBuilderTestCase { @Test public void testConnectTimeout() { - FileSystemOptions options = new FileSystemOptions(); + final FileSystemOptions options = new FileSystemOptions(); final SftpFileSystemConfigBuilder builder = SftpFileSystemConfigBuilder.getInstance(); builder.setConnectTimeout(options, ONE_MINUTE); assertEquals(ONE_MINUTE, builder.getConnectTimeout(options)); @@ -46,7 +46,7 @@ public class SftpFileSystemConfigBuilderTestCase { @Test public void testSessionTimeout() { - FileSystemOptions options = new FileSystemOptions(); + final FileSystemOptions options = new FileSystemOptions(); final SftpFileSystemConfigBuilder builder = SftpFileSystemConfigBuilder.getInstance(); builder.setSessionTimeout(options, ONE_MINUTE); assertEquals(ONE_MINUTE, builder.getSessionTimeout(options));