This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-io.git
The following commit(s) were added to refs/heads/master by this push: new 49953ef [IO-706] Add TimestampedObserver. 49953ef is described below commit 49953ef7e671441aefc1890d743df3e1ba71e713 Author: Gary Gregory <gardgreg...@gmail.com> AuthorDate: Sun Jan 31 10:05:15 2021 -0500 [IO-706] Add TimestampedObserver. Add simplest toString(). --- src/main/java/org/apache/commons/io/input/TimestampedObserver.java | 5 +++++ .../java/org/apache/commons/io/input/TimestampedObserverTest.java | 7 ++++++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/src/main/java/org/apache/commons/io/input/TimestampedObserver.java b/src/main/java/org/apache/commons/io/input/TimestampedObserver.java index 390e402..25ad3b2 100644 --- a/src/main/java/org/apache/commons/io/input/TimestampedObserver.java +++ b/src/main/java/org/apache/commons/io/input/TimestampedObserver.java @@ -86,4 +86,9 @@ public class TimestampedObserver extends Observer { return openInstant; } + @Override + public String toString() { + return "TimestampedObserver [openInstant=" + openInstant + ", closeInstant=" + closeInstant + "]"; + } + } diff --git a/src/test/java/org/apache/commons/io/input/TimestampedObserverTest.java b/src/test/java/org/apache/commons/io/input/TimestampedObserverTest.java index 042563c..dca9e1d 100644 --- a/src/test/java/org/apache/commons/io/input/TimestampedObserverTest.java +++ b/src/test/java/org/apache/commons/io/input/TimestampedObserverTest.java @@ -18,6 +18,7 @@ package org.apache.commons.io.input; import static org.junit.jupiter.api.Assertions.assertNull; +import static org.junit.jupiter.api.Assertions.assertNotNull; import static org.junit.jupiter.api.Assertions.assertTrue; import java.io.ByteArrayInputStream; @@ -37,6 +38,8 @@ public class TimestampedObserverTest { final Instant before = Instant.now(); Thread.sleep(20); // Some OS' clock granularity may be high. final TimestampedObserver timestampedObserver = new TimestampedObserver(); + // toString() should not blow up before close(). + assertNotNull(timestampedObserver.toString()); assertTrue(timestampedObserver.getOpenInstant().isAfter(before)); assertTrue(timestampedObserver.getOpenToNowDuration().toNanos() > 0); assertNull(timestampedObserver.getCloseInstant()); @@ -51,6 +54,7 @@ public class TimestampedObserverTest { assertTrue(timestampedObserver.getOpenToNowDuration().toNanos() > 0); assertTrue(timestampedObserver.getCloseInstant().isAfter(timestampedObserver.getOpenInstant())); assertTrue(timestampedObserver.getOpenToCloseDuration().toNanos() > 0); + assertNotNull(timestampedObserver.toString()); } @Test @@ -62,7 +66,8 @@ public class TimestampedObserverTest { timestampedObserver)) { // } - System.out.printf("IO duration: %s%n", timestampedObserver.getOpenToCloseDuration()); + // System.out.printf("IO duration: %s%n", timestampedObserver); + // System.out.printf("IO duration: %s%n", timestampedObserver.getOpenToCloseDuration()); } }