This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-validator.git
commit e33ee2231ae705877a9b97dbda665fd70bce18e4
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Sun Jan 17 17:21:17 2021 -0500
Make private elements final where possible.
---
.../apache/commons/validator/routines/CreditCardValidator.java | 2 +-
.../validator/routines/checkdigit/CUSIPCheckDigitTest.java | 8 ++++----
.../commons/validator/routines/checkdigit/ISINCheckDigitTest.java | 4 ++--
.../routines/checkdigit/ModulusTenCUSIPCheckDigitTest.java | 8 ++++----
.../routines/checkdigit/ModulusTenSedolCheckDigitTest.java | 4 ++--
.../validator/routines/checkdigit/SedolCheckDigitTest.java | 4 ++--
6 files changed, 15 insertions(+), 15 deletions(-)
diff --git
a/src/main/java/org/apache/commons/validator/routines/CreditCardValidator.java
b/src/main/java/org/apache/commons/validator/routines/CreditCardValidator.java
index f15f307..932fe08 100644
---
a/src/main/java/org/apache/commons/validator/routines/CreditCardValidator.java
+++
b/src/main/java/org/apache/commons/validator/routines/CreditCardValidator.java
@@ -465,7 +465,7 @@ public class CreditCardValidator implements Serializable {
// must be numeric (rest of validation is done later)
new RegexValidator("(\\d+)") {
private static final long serialVersionUID = 1L;
- private CreditCardRange[] ccr = creditCardRanges.clone();
+ private final CreditCardRange[] ccr =
creditCardRanges.clone();
@Override
// must return full string
public String validate(String value) {
diff --git
a/src/test/java/org/apache/commons/validator/routines/checkdigit/CUSIPCheckDigitTest.java
b/src/test/java/org/apache/commons/validator/routines/checkdigit/CUSIPCheckDigitTest.java
index 700ad32..0c9e4b3 100644
---
a/src/test/java/org/apache/commons/validator/routines/checkdigit/CUSIPCheckDigitTest.java
+++
b/src/test/java/org/apache/commons/validator/routines/checkdigit/CUSIPCheckDigitTest.java
@@ -52,21 +52,21 @@ public class CUSIPCheckDigitTest extends
AbstractCheckDigitTest {
invalid = new String[] {"0378#3100"};
}
- private static String invalidCheckDigits[] = {"DUS0421CW",
+ private static final String[] INVALID_CHECK_DIGITS = {"DUS0421CW",
"DUS0421CN",
"DUS0421CE"
};
public void testVALIDATOR_336_InvalidCheckDigits() {
- for (String invalidCheckDigit : invalidCheckDigits) {
+ for (String invalidCheckDigit : INVALID_CHECK_DIGITS) {
assertFalse("Should fail: " + invalidCheckDigit,
routine.isValid(invalidCheckDigit));
}
}
- private static String validCheckDigits[] = {"DUS0421C5"};
+ private static final String[] VALID_CHECK_DIGITS = {"DUS0421C5"};
public void testVALIDATOR_336_ValidCheckDigits() {
- for (String validCheckDigit : validCheckDigits) {
+ for (String validCheckDigit : VALID_CHECK_DIGITS) {
assertTrue("Should fail: " + validCheckDigit,
routine.isValid(validCheckDigit));
}
}
diff --git
a/src/test/java/org/apache/commons/validator/routines/checkdigit/ISINCheckDigitTest.java
b/src/test/java/org/apache/commons/validator/routines/checkdigit/ISINCheckDigitTest.java
index 6d293c6..7d3baa0 100644
---
a/src/test/java/org/apache/commons/validator/routines/checkdigit/ISINCheckDigitTest.java
+++
b/src/test/java/org/apache/commons/validator/routines/checkdigit/ISINCheckDigitTest.java
@@ -56,7 +56,7 @@ public class ISINCheckDigitTest extends
AbstractCheckDigitTest {
invalid = new String[] {"0378#3100"};
}
- private static String invalidCheckDigits[] =
+ private static final String[] INVALID_CHECK_DIGITS =
{"US037833100O", // proper check digit is '5',
see above
"BMG8571G109D", // proper check digit is '6',
see above
"AU0000XVGZAD", // proper check digit is '3',
see above
@@ -66,7 +66,7 @@ public class ISINCheckDigitTest extends
AbstractCheckDigitTest {
};
public void testVALIDATOR_345() {
- for (String invalidCheckDigit : invalidCheckDigits) {
+ for (String invalidCheckDigit : INVALID_CHECK_DIGITS) {
assertFalse("Should fail: " + invalidCheckDigit,
routine.isValid(invalidCheckDigit));
}
}
diff --git
a/src/test/java/org/apache/commons/validator/routines/checkdigit/ModulusTenCUSIPCheckDigitTest.java
b/src/test/java/org/apache/commons/validator/routines/checkdigit/ModulusTenCUSIPCheckDigitTest.java
index 2834e08..1b89da5 100644
---
a/src/test/java/org/apache/commons/validator/routines/checkdigit/ModulusTenCUSIPCheckDigitTest.java
+++
b/src/test/java/org/apache/commons/validator/routines/checkdigit/ModulusTenCUSIPCheckDigitTest.java
@@ -51,21 +51,21 @@ public class ModulusTenCUSIPCheckDigitTest extends
AbstractCheckDigitTest {
invalid = new String[] {"0378#3100"};
}
- private static String invalidCheckDigits[] = {"DUS0421CW",
+ private static final String[] INVALID_CHECK_DIGITS = {"DUS0421CW",
"DUS0421CN",
"DUS0421CE"
};
public void testVALIDATOR_336_InvalidCheckDigits() {
- for (String invalidCheckDigit : invalidCheckDigits) {
+ for (String invalidCheckDigit : INVALID_CHECK_DIGITS) {
assertFalse("Should fail: " + invalidCheckDigit,
routine.isValid(invalidCheckDigit));
}
}
- private static String validCheckDigits[] = {"DUS0421C5"};
+ private static final String[] VALID_CHECK_DIGITS = {"DUS0421C5"};
public void testVALIDATOR_336_ValidCheckDigits() {
- for (String validCheckDigit : validCheckDigits) {
+ for (String validCheckDigit : VALID_CHECK_DIGITS) {
assertTrue("Should fail: " + validCheckDigit,
routine.isValid(validCheckDigit));
}
}
diff --git
a/src/test/java/org/apache/commons/validator/routines/checkdigit/ModulusTenSedolCheckDigitTest.java
b/src/test/java/org/apache/commons/validator/routines/checkdigit/ModulusTenSedolCheckDigitTest.java
index 12be5b8..a2cc21d 100644
---
a/src/test/java/org/apache/commons/validator/routines/checkdigit/ModulusTenSedolCheckDigitTest.java
+++
b/src/test/java/org/apache/commons/validator/routines/checkdigit/ModulusTenSedolCheckDigitTest.java
@@ -50,7 +50,7 @@ public class ModulusTenSedolCheckDigitTest extends
AbstractCheckDigitTest {
zeroSum = "0000000";
}
- private static String invalidCheckDigits[] = {
+ private static final String[] INVALID_CHECK_DIGITS = {
"026349E", // proper check digit is '4', see above
"087061C", // proper check digit is '2', see above
"B06LQ9H", // proper check digit is '7', see above
@@ -59,7 +59,7 @@ public class ModulusTenSedolCheckDigitTest extends
AbstractCheckDigitTest {
};
public void testVALIDATOR_346() {
- for (String invalidCheckDigit : invalidCheckDigits) {
+ for (String invalidCheckDigit : INVALID_CHECK_DIGITS) {
assertFalse("Should fail: " + invalidCheckDigit,
routine.isValid(invalidCheckDigit));
}
}
diff --git
a/src/test/java/org/apache/commons/validator/routines/checkdigit/SedolCheckDigitTest.java
b/src/test/java/org/apache/commons/validator/routines/checkdigit/SedolCheckDigitTest.java
index 4b921dd..b31ac94 100644
---
a/src/test/java/org/apache/commons/validator/routines/checkdigit/SedolCheckDigitTest.java
+++
b/src/test/java/org/apache/commons/validator/routines/checkdigit/SedolCheckDigitTest.java
@@ -51,7 +51,7 @@ public class SedolCheckDigitTest extends
AbstractCheckDigitTest {
zeroSum = "0000000";
}
- private static String invalidCheckDigits[] = {
+ private static final String[] INVALID_CHECK_DIGITS = {
"026349E", // proper check digit is '4', see above
"087061C", // proper check digit is '2', see above
"B06LQ9H", // proper check digit is '7', see above
@@ -60,7 +60,7 @@ public class SedolCheckDigitTest extends
AbstractCheckDigitTest {
};
public void testVALIDATOR_346() {
- for (String invalidCheckDigit : invalidCheckDigits) {
+ for (String invalidCheckDigit : INVALID_CHECK_DIGITS) {
assertFalse("Should fail: " + invalidCheckDigit,
routine.isValid(invalidCheckDigit));
}
}
