This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-exec.git


The following commit(s) were added to refs/heads/master by this push:
     new bbff531  Use isEmpty().
bbff531 is described below

commit bbff53160f71735df6394c24989926d31abec1a4
Author: Gary Gregory <[email protected]>
AuthorDate: Sun Jan 17 10:10:56 2021 -0500

    Use isEmpty().
---
 src/test/java/org/apache/commons/exec/DefaultExecutorTest.java          | 2 +-
 .../java/org/apache/commons/exec/environment/EnvironmentUtilsTest.java  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/test/java/org/apache/commons/exec/DefaultExecutorTest.java 
b/src/test/java/org/apache/commons/exec/DefaultExecutorTest.java
index 896de1b..7ebbece 100644
--- a/src/test/java/org/apache/commons/exec/DefaultExecutorTest.java
+++ b/src/test/java/org/apache/commons/exec/DefaultExecutorTest.java
@@ -675,7 +675,7 @@ public class DefaultExecutorTest {
     public void testEnvironmentVariables() throws Exception {
         exec.execute(new CommandLine(environmentSript));
         final String environment = baos.toString().trim();
-        assertTrue("Found no environment variables", environment.length() > 0);
+        assertFalse("Found no environment variables", environment.isEmpty());
         assertFalse(environment.indexOf("NEW_VAR") >= 0);
     }
 
diff --git 
a/src/test/java/org/apache/commons/exec/environment/EnvironmentUtilsTest.java 
b/src/test/java/org/apache/commons/exec/environment/EnvironmentUtilsTest.java
index 39c676c..1b3a423 100644
--- 
a/src/test/java/org/apache/commons/exec/environment/EnvironmentUtilsTest.java
+++ 
b/src/test/java/org/apache/commons/exec/environment/EnvironmentUtilsTest.java
@@ -76,7 +76,7 @@ public class EnvironmentUtilsTest {
         final String[] envArgs = EnvironmentUtils.toStrings(procEnvironment);
         for (int i=0; i<envArgs.length; i++) {
             assertNotNull("Entry "+i+" should not be null",envArgs[i]);
-            assertTrue("Entry "+i+" should not be empty",envArgs[i].length() > 
0);
+            assertFalse("Entry "+i+" should not be 
empty",envArgs[i].isEmpty());
             // System.out.println(envArgs[i]);
         }
     }

Reply via email to