This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-email.git


The following commit(s) were added to refs/heads/master by this push:
     new 1d79adc  Use isEmpty().
1d79adc is described below

commit 1d79adc84adbd8b02a5bbeb11145a6b9465a4be9
Author: Gary Gregory <[email protected]>
AuthorDate: Sun Jan 17 10:07:07 2021 -0500

    Use isEmpty().
---
 src/main/java/org/apache/commons/mail/EmailUtils.java                 | 4 ++--
 .../java/org/apache/commons/mail/resolver/DataSourceUrlResolver.java  | 2 +-
 src/main/java/org/apache/commons/mail/util/MimeMessageParser.java     | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/main/java/org/apache/commons/mail/EmailUtils.java 
b/src/main/java/org/apache/commons/mail/EmailUtils.java
index 4687614..7df8c42 100644
--- a/src/main/java/org/apache/commons/mail/EmailUtils.java
+++ b/src/main/java/org/apache/commons/mail/EmailUtils.java
@@ -120,7 +120,7 @@ final class EmailUtils
      */
     static boolean isEmpty(final String str)
     {
-        return str == null || str.length() == 0;
+        return str == null || str.isEmpty();
     }
 
     /**
@@ -134,7 +134,7 @@ final class EmailUtils
      */
     static boolean isNotEmpty(final String str)
     {
-        return str != null && str.length() > 0;
+        return str != null && !str.isEmpty();
     }
 
     /**
diff --git 
a/src/main/java/org/apache/commons/mail/resolver/DataSourceUrlResolver.java 
b/src/main/java/org/apache/commons/mail/resolver/DataSourceUrlResolver.java
index 98713d1..ca516f9 100644
--- a/src/main/java/org/apache/commons/mail/resolver/DataSourceUrlResolver.java
+++ b/src/main/java/org/apache/commons/mail/resolver/DataSourceUrlResolver.java
@@ -116,7 +116,7 @@ public class DataSourceUrlResolver extends 
DataSourceBaseResolver
         }
 
         // if we get an non-existing location what we shall do?
-        if (resourceLocation == null || resourceLocation.length() == 0)
+        if (resourceLocation == null || resourceLocation.isEmpty())
         {
             throw new IllegalArgumentException("No resource defined");
         }
diff --git a/src/main/java/org/apache/commons/mail/util/MimeMessageParser.java 
b/src/main/java/org/apache/commons/mail/util/MimeMessageParser.java
index 556c2b6..915c834 100644
--- a/src/main/java/org/apache/commons/mail/util/MimeMessageParser.java
+++ b/src/main/java/org/apache/commons/mail/util/MimeMessageParser.java
@@ -391,12 +391,12 @@ public class MimeMessageParser
     {
         String result = dataSource.getName();
 
-        if (result == null || result.length() == 0)
+        if (result == null || result.isEmpty())
         {
             result = part.getFileName();
         }
 
-        if (result != null && result.length() > 0)
+        if (result != null && !result.isEmpty())
         {
             result = MimeUtility.decodeText(result);
         }

Reply via email to