[commons-dbcp] branch master updated: Use isEmpty().

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-dbcp.git


The following commit(s) were added to refs/heads/master by this push:
     new 11233ec  Use isEmpty().
11233ec is described below

commit 11233ec808518d4eb8dc359eb03f57d6645e4fc5
Author: Gary Gregory <gardgreg...@gmail.com>
AuthorDate: Sun Jan 17 09:59:19 2021 -0500

    Use isEmpty().
---
 src/main/java/org/apache/commons/dbcp2/BasicDataSource.java          | 2 +-
 src/test/java/org/apache/commons/dbcp2/TestDelegatingConnection.java | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java 
b/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java
index bbcb885..a595439 100644
--- a/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java
+++ b/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java
@@ -1720,7 +1720,7 @@ public class BasicDataSource implements DataSource, 
BasicDataSourceMXBean, MBean
         final String[] entries = connectionProperties.split(";");
         final Properties properties = new Properties();
         for (final String entry : entries) {
-            if (entry.length() > 0) {
+            if (!entry.isEmpty()) {
                 final int index = entry.indexOf('=');
                 if (index > 0) {
                     final String name = entry.substring(0, index);
diff --git 
a/src/test/java/org/apache/commons/dbcp2/TestDelegatingConnection.java 
b/src/test/java/org/apache/commons/dbcp2/TestDelegatingConnection.java
index 449bf58..453b2d6 100644
--- a/src/test/java/org/apache/commons/dbcp2/TestDelegatingConnection.java
+++ b/src/test/java/org/apache/commons/dbcp2/TestDelegatingConnection.java
@@ -162,7 +162,7 @@ public class TestDelegatingConnection {
     public void testConnectionToString() throws Exception {
         final String s = delegatingConnection.toString();
         assertNotNull(s);
-        assertTrue(s.length() > 0);
+        assertFalse(s.isEmpty());
     }
 
     @Test