This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-compress.git


The following commit(s) were added to refs/heads/master by this push:
     new 67da739  Use isEmpty().
67da739 is described below

commit 67da7395ce0f1324c8754e7193a68084ff87f167
Author: Gary Gregory <[email protected]>
AuthorDate: Sun Jan 17 09:47:07 2021 -0500

    Use isEmpty().
---
 .../org/apache/commons/compress/archivers/tar/TarArchiveEntry.java    | 4 ++--
 .../apache/commons/compress/archivers/tar/TarArchiveOutputStream.java | 2 +-
 .../java/org/apache/commons/compress/archivers/tar/TarLister.java     | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git 
a/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveEntry.java 
b/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveEntry.java
index 5417b13..2e81a91 100644
--- 
a/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveEntry.java
+++ 
b/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveEntry.java
@@ -1595,7 +1595,7 @@ public class TarArchiveEntry implements ArchiveEntry, 
TarConstants, EntryStreamO
             final String xstarPrefix = oldStyle
                 ? TarUtils.parseName(header, offset, PREFIXLEN_XSTAR)
                 : TarUtils.parseName(header, offset, PREFIXLEN_XSTAR, 
encoding);
-            if (xstarPrefix.length() > 0) {
+            if (!xstarPrefix.isEmpty()) {
                 name = xstarPrefix + "/" + name;
             }
             break;
@@ -1610,7 +1610,7 @@ public class TarArchiveEntry implements ArchiveEntry, 
TarConstants, EntryStreamO
             if (isDirectory() && !name.endsWith("/")){
                 name = name + "/";
             }
-            if (prefix.length() > 0){
+            if (!prefix.isEmpty()){
                 name = prefix + "/" + name;
             }
         }
diff --git 
a/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveOutputStream.java
 
b/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveOutputStream.java
index ee84a66..21aed27 100644
--- 
a/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveOutputStream.java
+++ 
b/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveOutputStream.java
@@ -367,7 +367,7 @@ public class TarArchiveOutputStream extends 
ArchiveOutputStream {
                 TarConstants.LF_GNUTYPE_LONGNAME, "file name");
 
             final String linkName = entry.getLinkName();
-            final boolean paxHeaderContainsLinkPath = linkName != null && 
linkName.length() > 0
+            final boolean paxHeaderContainsLinkPath = linkName != null && 
!linkName.isEmpty()
                 && handleLongName(entry, linkName, paxHeaders, "linkpath",
                 TarConstants.LF_GNUTYPE_LONGLINK, "link name");
 
diff --git 
a/src/test/java/org/apache/commons/compress/archivers/tar/TarLister.java 
b/src/test/java/org/apache/commons/compress/archivers/tar/TarLister.java
index f0459b7..a4c8610 100644
--- a/src/test/java/org/apache/commons/compress/archivers/tar/TarLister.java
+++ b/src/test/java/org/apache/commons/compress/archivers/tar/TarLister.java
@@ -67,14 +67,14 @@ public final class TarLister {
         final StringBuilder sb = new 
StringBuilder(Integer.toOctalString(ae.getMode()))
             .append(" ");
         String name = ae.getUserName();
-        if (name != null && name.length() > 0) {
+        if (name != null && !name.isEmpty()) {
             sb.append(name);
         } else {
             sb.append(ae.getLongUserId());
         }
         sb.append("/");
         name = ae.getGroupName();
-        if (name != null && name.length() > 0) {
+        if (name != null && !name.isEmpty()) {
             sb.append(name);
         } else {
             sb.append(ae.getLongGroupId());

Reply via email to