[commons-cli] branch master updated: Use isEmpty().

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-cli.git


The following commit(s) were added to refs/heads/master by this push:
     new e20023d  Use isEmpty().
e20023d is described below

commit e20023d55962858ec6cd3d786686a00192959a9b
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Sun Jan 17 09:38:41 2021 -0500

    Use isEmpty().
---
 src/main/java/org/apache/commons/cli/DefaultParser.java | 2 +-
 src/main/java/org/apache/commons/cli/HelpFormatter.java | 4 ++--
 src/main/java/org/apache/commons/cli/Option.java        | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/main/java/org/apache/commons/cli/DefaultParser.java 
b/src/main/java/org/apache/commons/cli/DefaultParser.java
index 6298ce3..2116288 100644
--- a/src/main/java/org/apache/commons/cli/DefaultParser.java
+++ b/src/main/java/org/apache/commons/cli/DefaultParser.java
@@ -360,7 +360,7 @@ public class DefaultParser implements CommandLineParser
             return true;
         }
         // check for several concatenated short options
-        return optName.length() > 0 && 
options.hasShortOption(String.valueOf(optName.charAt(0)));
+        return !optName.isEmpty() && 
options.hasShortOption(String.valueOf(optName.charAt(0)));
     }
 
     /**
diff --git a/src/main/java/org/apache/commons/cli/HelpFormatter.java 
b/src/main/java/org/apache/commons/cli/HelpFormatter.java
index 18e084e..7796aec 100644
--- a/src/main/java/org/apache/commons/cli/HelpFormatter.java
+++ b/src/main/java/org/apache/commons/cli/HelpFormatter.java
@@ -553,14 +553,14 @@ public class HelpFormatter
             printUsage(pw, width, cmdLineSyntax);
         }
 
-        if (header != null && header.trim().length() > 0)
+        if (header != null && !header.trim().isEmpty())
         {
             printWrapped(pw, width, header);
         }
 
         printOptions(pw, width, options, leftPad, descPad);
 
-        if (footer != null && footer.trim().length() > 0)
+        if (footer != null && !footer.trim().isEmpty())
         {
             printWrapped(pw, width, footer);
         }
diff --git a/src/main/java/org/apache/commons/cli/Option.java 
b/src/main/java/org/apache/commons/cli/Option.java
index 65cdafc..7687e6f 100644
--- a/src/main/java/org/apache/commons/cli/Option.java
+++ b/src/main/java/org/apache/commons/cli/Option.java
@@ -356,7 +356,7 @@ public class Option implements Cloneable, Serializable
      */
     public boolean hasArgName()
     {
-        return argName != null && argName.length() > 0;
+        return argName != null && !argName.isEmpty();
     }
 
     /**