This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-net.git
The following commit(s) were added to refs/heads/master by this push:
new 4d4f05d Use isEmpty().
4d4f05d is described below
commit 4d4f05db33e4fa2ca2eb9e486d21d7eb0d1097ff
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Sun Jan 17 09:16:55 2021 -0500
Use isEmpty().
---
src/main/java/org/apache/commons/net/examples/mail/SMTPMail.java | 2 +-
src/main/java/org/apache/commons/net/examples/nntp/PostMessage.java | 2 +-
src/main/java/org/apache/commons/net/ftp/parser/MLSxEntryParser.java | 4 ++--
.../java/org/apache/commons/net/ftp/parser/OS400FTPEntryParser.java | 2 +-
src/main/java/org/apache/commons/net/io/CRLFLineReader.java | 2 +-
.../java/org/apache/commons/net/io/DotTerminatedMessageReader.java | 2 +-
src/main/java/org/apache/commons/net/nntp/Article.java | 2 +-
src/main/java/org/apache/commons/net/nntp/Threader.java | 4 ++--
src/main/java/org/apache/commons/net/ntp/TimeStamp.java | 2 +-
src/main/java/org/apache/commons/net/telnet/TelnetOption.java | 2 +-
10 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/src/main/java/org/apache/commons/net/examples/mail/SMTPMail.java
b/src/main/java/org/apache/commons/net/examples/mail/SMTPMail.java
index ec412cd..c7a1f38 100644
--- a/src/main/java/org/apache/commons/net/examples/mail/SMTPMail.java
+++ b/src/main/java/org/apache/commons/net/examples/mail/SMTPMail.java
@@ -94,7 +94,7 @@ public final class SMTPMail
cc = stdin.readLine();
- if (cc== null || cc.length() == 0) {
+ if (cc== null || cc.isEmpty()) {
break;
}
diff --git
a/src/main/java/org/apache/commons/net/examples/nntp/PostMessage.java
b/src/main/java/org/apache/commons/net/examples/nntp/PostMessage.java
index f97af16..ed4db38 100644
--- a/src/main/java/org/apache/commons/net/examples/nntp/PostMessage.java
+++ b/src/main/java/org/apache/commons/net/examples/nntp/PostMessage.java
@@ -97,7 +97,7 @@ public final class PostMessage
newsgroup = newsgroup.trim();
- if (newsgroup.length() == 0) {
+ if (newsgroup.isEmpty()) {
break;
}
diff --git
a/src/main/java/org/apache/commons/net/ftp/parser/MLSxEntryParser.java
b/src/main/java/org/apache/commons/net/ftp/parser/MLSxEntryParser.java
index 1c163d5..032001b 100644
--- a/src/main/java/org/apache/commons/net/ftp/parser/MLSxEntryParser.java
+++ b/src/main/java/org/apache/commons/net/ftp/parser/MLSxEntryParser.java
@@ -108,7 +108,7 @@ public class MLSxEntryParser extends FTPFileEntryParserImpl
}
final String parts[] = entry.split(" ",2); // Path may contain space
- if (parts.length != 2 || parts[1].length() == 0) {
+ if (parts.length != 2 || parts[1].isEmpty()) {
return null; // no space found or no file name
}
final String factList = parts[0];
@@ -130,7 +130,7 @@ public class MLSxEntryParser extends FTPFileEntryParserImpl
}
final String factname = factparts[0].toLowerCase(Locale.ENGLISH);
final String factvalue = factparts[1];
- if (factvalue.length() == 0) {
+ if (factvalue.isEmpty()) {
continue; // nothing to see here
}
final String valueLowerCase =
factvalue.toLowerCase(Locale.ENGLISH);
diff --git
a/src/main/java/org/apache/commons/net/ftp/parser/OS400FTPEntryParser.java
b/src/main/java/org/apache/commons/net/ftp/parser/OS400FTPEntryParser.java
index 83f992d..437ab0c 100644
--- a/src/main/java/org/apache/commons/net/ftp/parser/OS400FTPEntryParser.java
+++ b/src/main/java/org/apache/commons/net/ftp/parser/OS400FTPEntryParser.java
@@ -412,7 +412,7 @@ public class OS400FTPEntryParser extends
ConfigurableFTPFileEntryParserImpl
* else <code>false</code>.
*/
private boolean isNullOrEmpty(final String string) {
- if (string == null || string.length() == 0) {
+ if (string == null || string.isEmpty()) {
return true;
}
return false;
diff --git a/src/main/java/org/apache/commons/net/io/CRLFLineReader.java
b/src/main/java/org/apache/commons/net/io/CRLFLineReader.java
index 89c1a60..1081946 100644
--- a/src/main/java/org/apache/commons/net/io/CRLFLineReader.java
+++ b/src/main/java/org/apache/commons/net/io/CRLFLineReader.java
@@ -69,7 +69,7 @@ public final class CRLFLineReader extends BufferedReader
}
}
final String string = sb.toString();
- if (string.length() == 0) { // immediate EOF
+ if (string.isEmpty()) { // immediate EOF
return null;
}
return string;
diff --git
a/src/main/java/org/apache/commons/net/io/DotTerminatedMessageReader.java
b/src/main/java/org/apache/commons/net/io/DotTerminatedMessageReader.java
index 66a1dbd..78057e2 100644
--- a/src/main/java/org/apache/commons/net/io/DotTerminatedMessageReader.java
+++ b/src/main/java/org/apache/commons/net/io/DotTerminatedMessageReader.java
@@ -240,7 +240,7 @@ public final class DotTerminatedMessageReader extends
BufferedReader
}
}
final String string = sb.toString();
- if (string.length() == 0) { // immediate EOF
+ if (string.isEmpty()) { // immediate EOF
return null;
}
// Should not happen - EOF without CRLF
diff --git a/src/main/java/org/apache/commons/net/nntp/Article.java
b/src/main/java/org/apache/commons/net/nntp/Article.java
index 4c51fba..a11fd0c 100644
--- a/src/main/java/org/apache/commons/net/nntp/Article.java
+++ b/src/main/java/org/apache/commons/net/nntp/Article.java
@@ -46,7 +46,7 @@ public class Article implements Threadable {
* @param msgId the message id to add
*/
public void addReference(final String msgId) {
- if (msgId == null || msgId.length() == 0) {
+ if (msgId == null || msgId.isEmpty()) {
return;
}
if (references == null) {
diff --git a/src/main/java/org/apache/commons/net/nntp/Threader.java
b/src/main/java/org/apache/commons/net/nntp/Threader.java
index 1d21448..02a091b 100644
--- a/src/main/java/org/apache/commons/net/nntp/Threader.java
+++ b/src/main/java/org/apache/commons/net/nntp/Threader.java
@@ -324,7 +324,7 @@ public class Threader {
final String subj = threadable.simplifiedSubject();
- if (subj == null || subj.length() == 0) {
+ if (subj == null || subj.isEmpty()) {
continue;
}
@@ -369,7 +369,7 @@ public class Threader {
final String subj = threadable.simplifiedSubject();
// Dont thread together all subjectless messages
- if (subj == null || subj.length() == 0) {
+ if (subj == null || subj.isEmpty()) {
continue;
}
diff --git a/src/main/java/org/apache/commons/net/ntp/TimeStamp.java
b/src/main/java/org/apache/commons/net/ntp/TimeStamp.java
index fb4dde8..3472b16 100644
--- a/src/main/java/org/apache/commons/net/ntp/TimeStamp.java
+++ b/src/main/java/org/apache/commons/net/ntp/TimeStamp.java
@@ -251,7 +251,7 @@ public class TimeStamp implements java.io.Serializable,
Comparable<TimeStamp>
}
final int ind = hexString.indexOf('.');
if (ind == -1) {
- if (hexString.length() == 0) {
+ if (hexString.isEmpty()) {
return 0;
}
return Long.parseLong(hexString, 16) << 32; // no decimal
diff --git a/src/main/java/org/apache/commons/net/telnet/TelnetOption.java
b/src/main/java/org/apache/commons/net/telnet/TelnetOption.java
index 4d3aafc..8bc960d 100644
--- a/src/main/java/org/apache/commons/net/telnet/TelnetOption.java
+++ b/src/main/java/org/apache/commons/net/telnet/TelnetOption.java
@@ -164,7 +164,7 @@ public class TelnetOption
*/
public static final String getOption(final int code)
{
- if(optionString[code].length() == 0)
+ if(optionString[code].isEmpty())
{
return "UNASSIGNED";
}
