This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-text.git
The following commit(s) were added to refs/heads/master by this push:
new 0b66f44 Reuse constants.
0b66f44 is described below
commit 0b66f445e13ab3b88811120db9bf677f3ce9c2a5
Author: Gary Gregory <[email protected]>
AuthorDate: Sat Jan 16 14:44:50 2021 -0500
Reuse constants.
---
src/main/java/org/apache/commons/text/similarity/RegexTokenizer.java | 3 ++-
src/test/java/org/apache/commons/text/AlphabetConverterTest.java | 2 +-
.../java/org/apache/commons/text/StrBuilderAppendInsertTest.java | 2 +-
.../org/apache/commons/text/TextStringBuilderAppendInsertTest.java | 2 +-
src/test/java/org/apache/commons/text/TextStringBuilderTest.java | 2 +-
.../java/org/apache/commons/text/diff/ReplacementsFinderTest.java | 5 +++--
6 files changed, 9 insertions(+), 7 deletions(-)
diff --git
a/src/main/java/org/apache/commons/text/similarity/RegexTokenizer.java
b/src/main/java/org/apache/commons/text/similarity/RegexTokenizer.java
index f650c0c..84a424d 100644
--- a/src/main/java/org/apache/commons/text/similarity/RegexTokenizer.java
+++ b/src/main/java/org/apache/commons/text/similarity/RegexTokenizer.java
@@ -21,6 +21,7 @@ import java.util.List;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
+import org.apache.commons.lang3.ArrayUtils;
import org.apache.commons.lang3.StringUtils;
import org.apache.commons.lang3.Validate;
@@ -48,7 +49,7 @@ class RegexTokenizer implements Tokenizer<CharSequence> {
while (matcher.find()) {
tokens.add(matcher.group(0));
}
- return tokens.toArray(new String[0]);
+ return tokens.toArray(ArrayUtils.EMPTY_STRING_ARRAY);
}
}
diff --git a/src/test/java/org/apache/commons/text/AlphabetConverterTest.java
b/src/test/java/org/apache/commons/text/AlphabetConverterTest.java
index fb10493..bb703a4 100644
--- a/src/test/java/org/apache/commons/text/AlphabetConverterTest.java
+++ b/src/test/java/org/apache/commons/text/AlphabetConverterTest.java
@@ -263,7 +263,7 @@ public class AlphabetConverterTest {
@Test
public void testEqualsWithNull() {
- final Character[] characterArray = new Character[0];
+ final Character[] characterArray =
ArrayUtils.EMPTY_CHARACTER_OBJECT_ARRAY;
final AlphabetConverter alphabetConverter =
AlphabetConverter.createConverterFromChars(characterArray, null,
null);
diff --git
a/src/test/java/org/apache/commons/text/StrBuilderAppendInsertTest.java
b/src/test/java/org/apache/commons/text/StrBuilderAppendInsertTest.java
index 6247936..71bc757 100644
--- a/src/test/java/org/apache/commons/text/StrBuilderAppendInsertTest.java
+++ b/src/test/java/org/apache/commons/text/StrBuilderAppendInsertTest.java
@@ -1200,7 +1200,7 @@ public class StrBuilderAppendInsertTest {
assertThat(sb.toString()).isEqualTo("");
sb.clear();
- sb.appendWithSeparators(new Object[0], ",");
+ sb.appendWithSeparators(ArrayUtils.EMPTY_OBJECT_ARRAY, ",");
assertThat(sb.toString()).isEqualTo("");
sb.clear();
diff --git
a/src/test/java/org/apache/commons/text/TextStringBuilderAppendInsertTest.java
b/src/test/java/org/apache/commons/text/TextStringBuilderAppendInsertTest.java
index 5a91d30..03e3fe1 100644
---
a/src/test/java/org/apache/commons/text/TextStringBuilderAppendInsertTest.java
+++
b/src/test/java/org/apache/commons/text/TextStringBuilderAppendInsertTest.java
@@ -1065,7 +1065,7 @@ public class TextStringBuilderAppendInsertTest {
assertThat(sb.toString()).isEqualTo("");
sb.clear();
- sb.appendWithSeparators(new Object[0], ",");
+ sb.appendWithSeparators(ArrayUtils.EMPTY_OBJECT_ARRAY, ",");
assertThat(sb.toString()).isEqualTo("");
sb.clear();
diff --git a/src/test/java/org/apache/commons/text/TextStringBuilderTest.java
b/src/test/java/org/apache/commons/text/TextStringBuilderTest.java
index 14d9acf..cde1467 100644
--- a/src/test/java/org/apache/commons/text/TextStringBuilderTest.java
+++ b/src/test/java/org/apache/commons/text/TextStringBuilderTest.java
@@ -819,7 +819,7 @@ public class TextStringBuilderTest {
final TextStringBuilder sb = new TextStringBuilder();
// empty buffer
assertEquals(0, sb.drainChars(0, 5, array, 1));
- assertEquals(0, sb.drainChars(0, 5, new char[0], 1));
+ assertEquals(0, sb.drainChars(0, 5, ArrayUtils.EMPTY_CHAR_ARRAY, 1));
// empty buffer, 0 length request
assertEquals(0, sb.drainChars(5, 5, array, 1));
diff --git
a/src/test/java/org/apache/commons/text/diff/ReplacementsFinderTest.java
b/src/test/java/org/apache/commons/text/diff/ReplacementsFinderTest.java
index 70843c2..c79e9f5 100644
--- a/src/test/java/org/apache/commons/text/diff/ReplacementsFinderTest.java
+++ b/src/test/java/org/apache/commons/text/diff/ReplacementsFinderTest.java
@@ -23,6 +23,7 @@ import java.util.ArrayList;
import java.util.List;
import java.util.stream.Stream;
+import org.apache.commons.lang3.ArrayUtils;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.Arguments;
@@ -65,8 +66,8 @@ public class ReplacementsFinderTest {
final ReplacementsFinder<Character> replacementFinder = new
ReplacementsFinder<>(handler);
sc.getScript().visit(replacementFinder);
assertThat(handler.getSkipped()).as("Skipped characters do not
match").isEqualTo(skipped);
- assertArrayEquals(handler.getFrom().toArray(new Character[0]), from,
"From characters do not match");
- assertArrayEquals(to, handler.getTo().toArray(new Character[0]), "To
characters do not match");
+
assertArrayEquals(handler.getFrom().toArray(ArrayUtils.EMPTY_CHARACTER_OBJECT_ARRAY),
from, "From characters do not match");
+ assertArrayEquals(to,
handler.getTo().toArray(ArrayUtils.EMPTY_CHARACTER_OBJECT_ARRAY), "To
characters do not match");
}
// Helper ReplacementsHandler implementation for testing
