[commons-dbcp] branch master updated: Define and use constants for empty arrays.

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-dbcp.git


The following commit(s) were added to refs/heads/master by this push:
     new e24196a  Define and use constants for empty arrays.
e24196a is described below

commit e24196a95bbbc531eb3c5f1b19e1dc42fd78a783
Author: Gary Gregory <gardgreg...@gmail.com>
AuthorDate: Wed Jan 13 15:14:29 2021 -0500

    Define and use constants for empty arrays.
---
 src/main/java/org/apache/commons/dbcp2/PoolingDriver.java             | 4 +++-
 .../org/apache/commons/dbcp2/managed/LocalXAConnectionFactory.java    | 3 ++-
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/main/java/org/apache/commons/dbcp2/PoolingDriver.java 
b/src/main/java/org/apache/commons/dbcp2/PoolingDriver.java
index 8e88664..316c868 100644
--- a/src/main/java/org/apache/commons/dbcp2/PoolingDriver.java
+++ b/src/main/java/org/apache/commons/dbcp2/PoolingDriver.java
@@ -36,6 +36,8 @@ import org.apache.commons.pool2.ObjectPool;
  */
 public class PoolingDriver implements Driver {
 
+    private static final DriverPropertyInfo[] EMPTY_DRIVER_PROPERTY_INFO_ARRAY 
= new DriverPropertyInfo[0];
+
     /* Register myself with the {@link DriverManager}. */
     static {
         try {
@@ -209,7 +211,7 @@ public class PoolingDriver implements Driver {
 
     @Override
     public DriverPropertyInfo[] getPropertyInfo(final String url, final 
Properties info) {
-        return new DriverPropertyInfo[0];
+        return EMPTY_DRIVER_PROPERTY_INFO_ARRAY;
     }
 
     /** My URL prefix */
diff --git 
a/src/main/java/org/apache/commons/dbcp2/managed/LocalXAConnectionFactory.java 
b/src/main/java/org/apache/commons/dbcp2/managed/LocalXAConnectionFactory.java
index 996a4e7..44faba8 100644
--- 
a/src/main/java/org/apache/commons/dbcp2/managed/LocalXAConnectionFactory.java
+++ 
b/src/main/java/org/apache/commons/dbcp2/managed/LocalXAConnectionFactory.java
@@ -50,6 +50,7 @@ public class LocalXAConnectionFactory implements 
XAConnectionFactory {
      * @since 2.0
      */
     protected static class LocalXAResource implements XAResource {
+        private static final Xid[] EMPTY_XID_ARRAY = new Xid[0];
         private final Connection connection;
         private Xid currentXid; // @GuardedBy("this")
         private boolean originalAutoCommit; // @GuardedBy("this")
@@ -207,7 +208,7 @@ public class LocalXAConnectionFactory implements 
XAConnectionFactory {
          */
         @Override
         public Xid[] recover(final int flag) {
-            return new Xid[0];
+            return EMPTY_XID_ARRAY;
         }
 
         /**