This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-compress.git


The following commit(s) were added to refs/heads/master by this push:
     new b0df98a  Breaking binary compatibility should break the build instead 
of generating a report one might skip reading, especially for PRs.
b0df98a is described below

commit b0df98a2dcc3bed1f097101d7ba54563dda985b0
Author: Gary Gregory <[email protected]>
AuthorDate: Sat Jan 2 10:01:36 2021 -0500

    Breaking binary compatibility should break the build instead of
    generating a report one might skip reading, especially for PRs.
    
    Don't break BC.
---
 pom.xml                                                                | 3 ---
 .../apache/commons/compress/archivers/dump/DumpArchiveInputStream.java | 2 +-
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/pom.xml b/pom.xml
index d2d7382..2bcb367 100644
--- a/pom.xml
+++ b/pom.xml
@@ -67,9 +67,6 @@ Brotli, Zstandard and ar, cpio, jar, tar, zip, dump, 7z, arj.
     <!-- only show issues of the current version -->
     
<commons.changes.onlyCurrentVersion>true</commons.changes.onlyCurrentVersion>
 
-    <!-- generate report even if there are binary incompatible changes -->
-    
<commons.japicmp.breakBuildOnBinaryIncompatibleModifications>false</commons.japicmp.breakBuildOnBinaryIncompatibleModifications>
-
     <!-- definition uses commons.componentId starting with parent 47,
          this doesn't work for us -->
     
<commons.scmPubUrl>https://svn.apache.org/repos/infra/websites/production/commons/content/proper/${project.artifactId}</commons.scmPubUrl>
diff --git 
a/src/main/java/org/apache/commons/compress/archivers/dump/DumpArchiveInputStream.java
 
b/src/main/java/org/apache/commons/compress/archivers/dump/DumpArchiveInputStream.java
index a8dcac4..9eeae44 100644
--- 
a/src/main/java/org/apache/commons/compress/archivers/dump/DumpArchiveInputStream.java
+++ 
b/src/main/java/org/apache/commons/compress/archivers/dump/DumpArchiveInputStream.java
@@ -59,7 +59,7 @@ public class DumpArchiveInputStream extends 
ArchiveInputStream {
     private byte[] blockBuffer;
     private int recordOffset;
     private long filepos;
-    protected final TapeInputStream raw;
+    protected TapeInputStream raw;
 
     // map of ino -> dirent entry. We can use this to reconstruct full paths.
     private final Map<Integer, Dirent> names = new HashMap<>();

Reply via email to