This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-io.git
The following commit(s) were added to refs/heads/master by this push: new 2a66db6 Minor improvement: (#176) 2a66db6 is described below commit 2a66db600b034ba032f0df2a394f3b7fb217255e Author: Arturo Bernal <arturobern...@gmail.com> AuthorDate: Sun Dec 20 20:39:53 2020 +0100 Minor improvement: (#176) * Add Final * Unused import * Unnecessary semicolon --- src/main/java/org/apache/commons/io/FileUtils.java | 4 ++-- .../commons/io/comparator/SizeFileComparator.java | 4 ++-- .../commons/io/file/spi/FileSystemProviders.java | 2 +- .../commons/io/filefilter/AgeFileFilter.java | 2 +- .../io/output/AbstractByteArrayOutputStream.java | 2 +- .../apache/commons/io/DirectoryWalkerTestCase.java | 1 - .../io/FileUtilsCleanDirectoryTestCase.java | 2 +- .../commons/io/FileUtilsCleanSymlinksTestCase.java | 2 +- .../org/apache/commons/io/FileUtilsTestCase.java | 2 +- .../org/apache/commons/io/IOUtilsTestCase.java | 14 +++++------ .../apache/commons/io/LineIteratorTestCase.java | 16 ++++++------- .../commons/io/file/DirectoryStreamFilterTest.java | 4 ---- .../io/input/SwappedDataInputStreamTest.java | 2 +- .../commons/io/input/XmlStreamReaderTest.java | 2 +- .../io/input/XmlStreamReaderUtilitiesTest.java | 28 +++++++++++----------- .../buffer/CircularBufferInputStreamTest.java | 2 +- .../io/input/compatibility/XmlStreamReader.java | 4 ++-- .../io/output/FileWriterWithEncodingTest.java | 14 +++++------ 18 files changed, 51 insertions(+), 56 deletions(-) diff --git a/src/main/java/org/apache/commons/io/FileUtils.java b/src/main/java/org/apache/commons/io/FileUtils.java index d381159..9cc8b96 100644 --- a/src/main/java/org/apache/commons/io/FileUtils.java +++ b/src/main/java/org/apache/commons/io/FileUtils.java @@ -198,7 +198,7 @@ public class FileUtils { */ // See https://issues.apache.org/jira/browse/IO-226 - should the rounding be changed? public static String byteCountToDisplaySize(final BigInteger size) { - String displaySize; + final String displaySize; if (size.divide(ONE_EB_BI).compareTo(BigInteger.ZERO) > 0) { displaySize = String.valueOf(size.divide(ONE_EB_BI)) + " EB"; @@ -2711,7 +2711,7 @@ public class FileUtils { */ public static Stream<File> streamFiles(final File directory, final boolean recursive, final String... extensions) throws IOException { - IOFileFilter filter; + final IOFileFilter filter; if (extensions == null) { filter = FileFileFilter.INSTANCE; } else { diff --git a/src/main/java/org/apache/commons/io/comparator/SizeFileComparator.java b/src/main/java/org/apache/commons/io/comparator/SizeFileComparator.java index c6f3803..ce22d51 100644 --- a/src/main/java/org/apache/commons/io/comparator/SizeFileComparator.java +++ b/src/main/java/org/apache/commons/io/comparator/SizeFileComparator.java @@ -108,13 +108,13 @@ public class SizeFileComparator extends AbstractFileComparator implements Serial */ @Override public int compare(final File file1, final File file2) { - long size1; + final long size1; if (file1.isDirectory()) { size1 = sumDirectoryContents && file1.exists() ? FileUtils.sizeOfDirectory(file1) : 0; } else { size1 = file1.length(); } - long size2; + final long size2; if (file2.isDirectory()) { size2 = sumDirectoryContents && file2.exists() ? FileUtils.sizeOfDirectory(file2) : 0; } else { diff --git a/src/main/java/org/apache/commons/io/file/spi/FileSystemProviders.java b/src/main/java/org/apache/commons/io/file/spi/FileSystemProviders.java index bae8953..c87ac05 100644 --- a/src/main/java/org/apache/commons/io/file/spi/FileSystemProviders.java +++ b/src/main/java/org/apache/commons/io/file/spi/FileSystemProviders.java @@ -32,7 +32,7 @@ import java.util.Objects; */ public class FileSystemProviders { - private static FileSystemProviders INSTALLED = new FileSystemProviders(FileSystemProvider.installedProviders()); + private static final FileSystemProviders INSTALLED = new FileSystemProviders(FileSystemProvider.installedProviders()); /** * Gets the {@link FileSystemProvider} for the given Path. diff --git a/src/main/java/org/apache/commons/io/filefilter/AgeFileFilter.java b/src/main/java/org/apache/commons/io/filefilter/AgeFileFilter.java index 71facc5..80dd9ad 100644 --- a/src/main/java/org/apache/commons/io/filefilter/AgeFileFilter.java +++ b/src/main/java/org/apache/commons/io/filefilter/AgeFileFilter.java @@ -176,7 +176,7 @@ public class AgeFileFilter extends AbstractFileFilter implements Serializable { */ @Override public FileVisitResult accept(final Path file, final BasicFileAttributes attributes) { - boolean newer; + final boolean newer; try { newer = PathUtils.isNewer(file, cutoffMillis); } catch (final IOException e) { diff --git a/src/main/java/org/apache/commons/io/output/AbstractByteArrayOutputStream.java b/src/main/java/org/apache/commons/io/output/AbstractByteArrayOutputStream.java index 243b527..f827143 100644 --- a/src/main/java/org/apache/commons/io/output/AbstractByteArrayOutputStream.java +++ b/src/main/java/org/apache/commons/io/output/AbstractByteArrayOutputStream.java @@ -91,7 +91,7 @@ public abstract class AbstractByteArrayOutputStream extends OutputStream { currentBuffer = buffers.get(currentBufferIndex); } else { //Creating new buffer - int newBufferSize; + final int newBufferSize; if (currentBuffer == null) { newBufferSize = newcount; filledBufferSum = 0; diff --git a/src/test/java/org/apache/commons/io/DirectoryWalkerTestCase.java b/src/test/java/org/apache/commons/io/DirectoryWalkerTestCase.java index c316642..50b2181 100644 --- a/src/test/java/org/apache/commons/io/DirectoryWalkerTestCase.java +++ b/src/test/java/org/apache/commons/io/DirectoryWalkerTestCase.java @@ -31,7 +31,6 @@ import java.util.List; import org.apache.commons.io.filefilter.FileFilterUtils; import org.apache.commons.io.filefilter.IOFileFilter; import org.apache.commons.io.filefilter.NameFileFilter; -import org.apache.commons.io.filefilter.OrFileFilter; import org.junit.jupiter.api.Test; /** diff --git a/src/test/java/org/apache/commons/io/FileUtilsCleanDirectoryTestCase.java b/src/test/java/org/apache/commons/io/FileUtilsCleanDirectoryTestCase.java index 32ea023..e77c6e9 100644 --- a/src/test/java/org/apache/commons/io/FileUtilsCleanDirectoryTestCase.java +++ b/src/test/java/org/apache/commons/io/FileUtilsCleanDirectoryTestCase.java @@ -130,7 +130,7 @@ public class FileUtilsCleanDirectoryTestCase { args.add(Integer.toString(mode)); args.add(file.getAbsolutePath()); - Process proc; + final Process proc; try { proc = Runtime.getRuntime().exec(args.toArray(new String[args.size()])); diff --git a/src/test/java/org/apache/commons/io/FileUtilsCleanSymlinksTestCase.java b/src/test/java/org/apache/commons/io/FileUtilsCleanSymlinksTestCase.java index 27d61c5..bb2c146 100644 --- a/src/test/java/org/apache/commons/io/FileUtilsCleanSymlinksTestCase.java +++ b/src/test/java/org/apache/commons/io/FileUtilsCleanSymlinksTestCase.java @@ -253,7 +253,7 @@ public class FileUtilsCleanSymlinksTestCase { args.add(res.getAbsolutePath()); args.add(link.getAbsolutePath()); - Process proc; + final Process proc; proc = Runtime.getRuntime().exec(args.toArray(new String[args.size()])); return proc.waitFor() == 0; diff --git a/src/test/java/org/apache/commons/io/FileUtilsTestCase.java b/src/test/java/org/apache/commons/io/FileUtilsTestCase.java index e03df72..5c843ee 100644 --- a/src/test/java/org/apache/commons/io/FileUtilsTestCase.java +++ b/src/test/java/org/apache/commons/io/FileUtilsTestCase.java @@ -222,7 +222,7 @@ public class FileUtilsTestCase { private void iterateFilesAndDirs(final File dir, final IOFileFilter fileFilter, final IOFileFilter dirFilter, final Collection<File> expectedFilesAndDirs) { - Iterator<File> iterator; + final Iterator<File> iterator; int filesCount = 0; iterator = FileUtils.iterateFilesAndDirs(dir, fileFilter, dirFilter); try { diff --git a/src/test/java/org/apache/commons/io/IOUtilsTestCase.java b/src/test/java/org/apache/commons/io/IOUtilsTestCase.java index 98586c0..591f47b 100644 --- a/src/test/java/org/apache/commons/io/IOUtilsTestCase.java +++ b/src/test/java/org/apache/commons/io/IOUtilsTestCase.java @@ -733,7 +733,7 @@ public class IOUtilsTestCase { @Test public void testCopyLarge_CharSkipInvalid() throws IOException { try ( CharArrayReader is = new CharArrayReader(carr); - CharArrayWriter os = new CharArrayWriter(); + CharArrayWriter os = new CharArrayWriter() ) { assertThrows(EOFException.class, () -> IOUtils.copyLarge(is, os, 1000, 100)); } @@ -742,7 +742,7 @@ public class IOUtilsTestCase { @Test public void testCopyLarge_ExtraLength() throws IOException { try ( ByteArrayInputStream is = new ByteArrayInputStream(iarr); - ByteArrayOutputStream os = new ByteArrayOutputStream(); + ByteArrayOutputStream os = new ByteArrayOutputStream() ) { // Create streams @@ -763,7 +763,7 @@ public class IOUtilsTestCase { @Test public void testCopyLarge_FullLength() throws IOException { try ( ByteArrayInputStream is = new ByteArrayInputStream(iarr); - ByteArrayOutputStream os = new ByteArrayOutputStream(); + ByteArrayOutputStream os = new ByteArrayOutputStream() ) { // Test our copy method assertEquals(200, IOUtils.copyLarge(is, os, 0, -1)); @@ -781,8 +781,8 @@ public class IOUtilsTestCase { @Test public void testCopyLarge_NoSkip() throws IOException { try ( ByteArrayInputStream is = new ByteArrayInputStream(iarr); - ByteArrayOutputStream os = new ByteArrayOutputStream(); - ) { + ByteArrayOutputStream os = new ByteArrayOutputStream() + ) { // Test our copy method assertEquals(100, IOUtils.copyLarge(is, os, 0, 100)); final byte[] oarr = os.toByteArray(); @@ -799,7 +799,7 @@ public class IOUtilsTestCase { @Test public void testCopyLarge_Skip() throws IOException { try ( ByteArrayInputStream is = new ByteArrayInputStream(iarr); - ByteArrayOutputStream os = new ByteArrayOutputStream(); + ByteArrayOutputStream os = new ByteArrayOutputStream() ) { // Test our copy method assertEquals(100, IOUtils.copyLarge(is, os, 10, 100)); @@ -817,7 +817,7 @@ public class IOUtilsTestCase { @Test public void testCopyLarge_SkipInvalid() throws IOException { try ( ByteArrayInputStream is = new ByteArrayInputStream(iarr); - ByteArrayOutputStream os = new ByteArrayOutputStream(); + ByteArrayOutputStream os = new ByteArrayOutputStream() ) { // Test our copy method assertThrows(EOFException.class, () -> IOUtils.copyLarge(is, os, 1000, 100)); diff --git a/src/test/java/org/apache/commons/io/LineIteratorTestCase.java b/src/test/java/org/apache/commons/io/LineIteratorTestCase.java index 4d6dad4..0796460 100644 --- a/src/test/java/org/apache/commons/io/LineIteratorTestCase.java +++ b/src/test/java/org/apache/commons/io/LineIteratorTestCase.java @@ -113,7 +113,7 @@ public class LineIteratorTestCase { public void testConstructor() throws Exception { assertThrows(IllegalArgumentException.class, () -> { try ( - LineIterator li = new LineIterator(null); + LineIterator li = new LineIterator(null) ) { } }); } @@ -143,7 +143,7 @@ public class LineIteratorTestCase { final File testFile = new File(temporaryFolder, "dummy-missing-file.txt"); try ( - LineIterator iterator = FileUtils.lineIterator(testFile, "UTF-8"); + LineIterator iterator = FileUtils.lineIterator(testFile, "UTF-8") ){ fail("Expected FileNotFoundException"); } catch (final FileNotFoundException expected) { @@ -159,7 +159,7 @@ public class LineIteratorTestCase { createLinesFile(testFile, encoding, 3); try ( - final LineIterator iterator = FileUtils.lineIterator(testFile, encoding); + final LineIterator iterator = FileUtils.lineIterator(testFile, encoding) ){ int count = 0; while (iterator.hasNext()) { @@ -178,7 +178,7 @@ public class LineIteratorTestCase { createLinesFile(testFile, "UTF-8", 3); try ( - LineIterator iterator = FileUtils.lineIterator(testFile, encoding); + LineIterator iterator = FileUtils.lineIterator(testFile, encoding) ) { fail("Expected UnsupportedCharsetException"); } catch (final UnsupportedCharsetException expected) { @@ -225,7 +225,7 @@ public class LineIteratorTestCase { final List<String> lines = createLinesFile(testFile, encoding, 3); try ( - final LineIterator iterator = FileUtils.lineIterator(testFile, encoding); + final LineIterator iterator = FileUtils.lineIterator(testFile, encoding) ){ for (int i = 0; i < lines.size(); i++) { final String line = iterator.next(); @@ -244,7 +244,7 @@ public class LineIteratorTestCase { } }; try ( - LineIterator li = new LineIterator(reader); + LineIterator li = new LineIterator(reader) ) { assertThrows(IllegalStateException.class, () -> { li.hasNext(); @@ -260,7 +260,7 @@ public class LineIteratorTestCase { createLinesFile(testFile, encoding, 3); try ( - final LineIterator iterator = FileUtils.lineIterator(testFile, encoding); + final LineIterator iterator = FileUtils.lineIterator(testFile, encoding) ) { // get assertNotNull("Line expected", iterator.next()); @@ -314,7 +314,7 @@ public class LineIteratorTestCase { final List<String> lines = createLinesFile(testFile, encoding, lineCount); try ( - final LineIterator iterator = FileUtils.lineIterator(testFile, encoding); + final LineIterator iterator = FileUtils.lineIterator(testFile, encoding) ){ try { iterator.remove(); diff --git a/src/test/java/org/apache/commons/io/file/DirectoryStreamFilterTest.java b/src/test/java/org/apache/commons/io/file/DirectoryStreamFilterTest.java index 1146acc..70cb1a5 100644 --- a/src/test/java/org/apache/commons/io/file/DirectoryStreamFilterTest.java +++ b/src/test/java/org/apache/commons/io/file/DirectoryStreamFilterTest.java @@ -24,12 +24,8 @@ import static org.junit.jupiter.api.Assertions.assertNotEquals; import java.nio.file.DirectoryStream; import java.nio.file.Files; import java.nio.file.Path; -import java.nio.file.Paths; import java.util.Iterator; -import org.apache.commons.io.file.DirectoryStreamFilter; -import org.apache.commons.io.file.PathFilter; -import org.apache.commons.io.file.PathUtils; import org.apache.commons.io.filefilter.NameFileFilter; import org.junit.jupiter.api.Test; diff --git a/src/test/java/org/apache/commons/io/input/SwappedDataInputStreamTest.java b/src/test/java/org/apache/commons/io/input/SwappedDataInputStreamTest.java index 083a11d..c56c535 100644 --- a/src/test/java/org/apache/commons/io/input/SwappedDataInputStreamTest.java +++ b/src/test/java/org/apache/commons/io/input/SwappedDataInputStreamTest.java @@ -65,7 +65,7 @@ public class SwappedDataInputStreamTest { bytes = new byte[] {0x00, 0x01, 0x02,}; try ( final ByteArrayInputStream bais = new ByteArrayInputStream(bytes); - final SwappedDataInputStream sdis = new SwappedDataInputStream(bais); + final SwappedDataInputStream sdis = new SwappedDataInputStream(bais) ) { assertEquals(false, sdis.readBoolean()); assertEquals(true, sdis.readBoolean()); diff --git a/src/test/java/org/apache/commons/io/input/XmlStreamReaderTest.java b/src/test/java/org/apache/commons/io/input/XmlStreamReaderTest.java index 561b8d4..fcf2fc8 100644 --- a/src/test/java/org/apache/commons/io/input/XmlStreamReaderTest.java +++ b/src/test/java/org/apache/commons/io/input/XmlStreamReaderTest.java @@ -310,7 +310,7 @@ public class XmlStreamReaderTest { for (final String encoding : encodings) { final String xml = getXML("no-bom", XML3, encoding, encoding); try (final ByteArrayInputStream is = new ByteArrayInputStream(xml.getBytes(encoding)); - final XmlStreamReader xmlReader = new XmlStreamReader(is);) { + final XmlStreamReader xmlReader = new XmlStreamReader(is)) { assertTrue(encoding.equalsIgnoreCase(xmlReader.getEncoding()), "Check encoding : " + encoding); assertEquals(xml, IOUtils.toString(xmlReader), "Check content"); } diff --git a/src/test/java/org/apache/commons/io/input/XmlStreamReaderUtilitiesTest.java b/src/test/java/org/apache/commons/io/input/XmlStreamReaderUtilitiesTest.java index 33a6afd..54700f6 100644 --- a/src/test/java/org/apache/commons/io/input/XmlStreamReaderUtilitiesTest.java +++ b/src/test/java/org/apache/commons/io/input/XmlStreamReaderUtilitiesTest.java @@ -31,21 +31,21 @@ import org.junit.jupiter.api.Test; */ public class XmlStreamReaderUtilitiesTest { - private static String RAWMGS1 = "encoding mismatch"; - private static String RAWMGS2 = "unknown BOM"; - private static String HTTPMGS1 = "BOM must be NULL"; - private static String HTTPMGS2 = "encoding mismatch"; - private static String HTTPMGS3 = "Invalid MIME"; + private static final String RAWMGS1 = "encoding mismatch"; + private static final String RAWMGS2 = "unknown BOM"; + private static final String HTTPMGS1 = "BOM must be NULL"; + private static final String HTTPMGS2 = "encoding mismatch"; + private static final String HTTPMGS3 = "Invalid MIME"; - private static String APPXML = "application/xml"; - private static String APPXML_UTF8 = "application/xml;charset=UTF-8"; - private static String APPXML_UTF16 = "application/xml;charset=UTF-16"; - private static String APPXML_UTF32 = "application/xml;charset=UTF-32"; - private static String APPXML_UTF16BE = "application/xml;charset=UTF-16BE"; - private static String APPXML_UTF16LE = "application/xml;charset=UTF-16LE"; - private static String APPXML_UTF32BE = "application/xml;charset=UTF-32BE"; - private static String APPXML_UTF32LE = "application/xml;charset=UTF-32LE"; - private static String TXTXML = "text/xml"; + private static final String APPXML = "application/xml"; + private static final String APPXML_UTF8 = "application/xml;charset=UTF-8"; + private static final String APPXML_UTF16 = "application/xml;charset=UTF-16"; + private static final String APPXML_UTF32 = "application/xml;charset=UTF-32"; + private static final String APPXML_UTF16BE = "application/xml;charset=UTF-16BE"; + private static final String APPXML_UTF16LE = "application/xml;charset=UTF-16LE"; + private static final String APPXML_UTF32BE = "application/xml;charset=UTF-32BE"; + private static final String APPXML_UTF32LE = "application/xml;charset=UTF-32LE"; + private static final String TXTXML = "text/xml"; @Test public void testContentTypeEncoding() { diff --git a/src/test/java/org/apache/commons/io/input/buffer/CircularBufferInputStreamTest.java b/src/test/java/org/apache/commons/io/input/buffer/CircularBufferInputStreamTest.java index 8f2bd7c..e8f118f 100644 --- a/src/test/java/org/apache/commons/io/input/buffer/CircularBufferInputStreamTest.java +++ b/src/test/java/org/apache/commons/io/input/buffer/CircularBufferInputStreamTest.java @@ -82,7 +82,7 @@ public class CircularBufferInputStreamTest { final byte[] buffer = new byte[]{0,1,-2,-2,-1,4}; try ( final ByteArrayInputStream bais = new ByteArrayInputStream(buffer); - final CircularBufferInputStream cbis = new CircularBufferInputStream(bais); + final CircularBufferInputStream cbis = new CircularBufferInputStream(bais) ){ int b; int i = 0; diff --git a/src/test/java/org/apache/commons/io/input/compatibility/XmlStreamReader.java b/src/test/java/org/apache/commons/io/input/compatibility/XmlStreamReader.java index 1f79ad8..1b01e74 100644 --- a/src/test/java/org/apache/commons/io/input/compatibility/XmlStreamReader.java +++ b/src/test/java/org/apache/commons/io/input/compatibility/XmlStreamReader.java @@ -445,7 +445,7 @@ public class XmlStreamReader extends Reader { // InputStream is passed for XmlStreamReaderException creation only String calculateRawEncoding(final String bomEnc, final String xmlGuessEnc, final String xmlEnc, final InputStream is) throws IOException { - String encoding; + final String encoding; if (bomEnc == null) { if (xmlGuessEnc == null || xmlEnc == null) { encoding = defaultEncoding == null ? UTF_8 : defaultEncoding; @@ -508,7 +508,7 @@ public class XmlStreamReader extends Reader { String calculateHttpEncoding(final String cTMime, final String cTEnc, final String bomEnc, final String xmlGuessEnc, final String xmlEnc, final InputStream is, final boolean lenient) throws IOException { - String encoding; + final String encoding; if (lenient && (xmlEnc != null)) { encoding = xmlEnc; } else { diff --git a/src/test/java/org/apache/commons/io/output/FileWriterWithEncodingTest.java b/src/test/java/org/apache/commons/io/output/FileWriterWithEncodingTest.java index 84f1725..1e014db 100644 --- a/src/test/java/org/apache/commons/io/output/FileWriterWithEncodingTest.java +++ b/src/test/java/org/apache/commons/io/output/FileWriterWithEncodingTest.java @@ -101,7 +101,7 @@ public class FileWriterWithEncodingTest { private void successfulRun(final FileWriterWithEncoding fw21) throws Exception { try ( FileWriter fw1 = new FileWriter(file1); // default encoding - FileWriterWithEncoding fw2 = fw21; + FileWriterWithEncoding fw2 = fw21 ){ writeTestPayload(fw1, fw2); checkFile(file1, file2); @@ -115,7 +115,7 @@ public class FileWriterWithEncodingTest { if (Charset.isSupported("UTF-16BE")) { try ( FileWriter fw1 = new FileWriter(file1); // default encoding - FileWriterWithEncoding fw2 = new FileWriterWithEncoding(file2, defaultEncoding); + FileWriterWithEncoding fw2 = new FileWriterWithEncoding(file2, defaultEncoding) ){ writeTestPayload(fw1, fw2); try { @@ -132,7 +132,7 @@ public class FileWriterWithEncodingTest { if (Charset.isSupported("UTF-16LE")) { try ( FileWriter fw1 = new FileWriter(file1); // default encoding - FileWriterWithEncoding fw2 = new FileWriterWithEncoding(file2, defaultEncoding); + FileWriterWithEncoding fw2 = new FileWriterWithEncoding(file2, defaultEncoding) ){ writeTestPayload(fw1, fw2); try { @@ -171,7 +171,7 @@ public class FileWriterWithEncodingTest { public void constructor_File_encoding_badEncoding() { assertThrows(IOException.class, () -> { try ( - Writer writer = new FileWriterWithEncoding(file1, "BAD-ENCODE"); + Writer writer = new FileWriterWithEncoding(file1, "BAD-ENCODE") ){ } }); assertFalse(file1.exists()); @@ -181,7 +181,7 @@ public class FileWriterWithEncodingTest { public void constructor_File_directory() { assertThrows(IOException.class, () -> { try ( - Writer writer = new FileWriterWithEncoding(temporaryFolder, defaultEncoding); + Writer writer = new FileWriterWithEncoding(temporaryFolder, defaultEncoding) ){ } }); assertFalse(file1.exists()); @@ -191,7 +191,7 @@ public class FileWriterWithEncodingTest { public void constructor_File_nullFile() { assertThrows(NullPointerException.class, () -> { try ( - Writer writer = new FileWriterWithEncoding((File) null, defaultEncoding); + Writer writer = new FileWriterWithEncoding((File) null, defaultEncoding) ){ } }); assertFalse(file1.exists()); @@ -201,7 +201,7 @@ public class FileWriterWithEncodingTest { public void constructor_fileName_nullFile() { assertThrows(NullPointerException.class, () -> { try ( - Writer writer = new FileWriterWithEncoding((String) null, defaultEncoding); + Writer writer = new FileWriterWithEncoding((String) null, defaultEncoding) ){ } }); assertFalse(file1.exists());