This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-bcel.git
The following commit(s) were added to refs/heads/master by this push: new e7de6b0 Use final. e7de6b0 is described below commit e7de6b0cefc0f13b036fec9cacdfa65ca416e59c Author: Gary Gregory <gardgreg...@gmail.com> AuthorDate: Fri Nov 20 22:07:15 2020 -0500 Use final. --- src/examples/Mini/ASTExpr.java | 4 ++-- src/examples/Mini/ASTFunDecl.java | 8 ++++---- src/examples/Mini/ASTProgram.java | 10 +++++----- src/examples/Mini/MiniC.java | 2 +- src/examples/Mini/MiniParser.java | 4 ++-- src/examples/Mini/ParseException.java | 2 +- src/examples/Mini/SimpleNode.java | 2 +- src/examples/listclass.java | 4 ++-- 8 files changed, 18 insertions(+), 18 deletions(-) diff --git a/src/examples/Mini/ASTExpr.java b/src/examples/Mini/ASTExpr.java index 47c094f..3c91d31 100644 --- a/src/examples/Mini/ASTExpr.java +++ b/src/examples/Mini/ASTExpr.java @@ -177,7 +177,7 @@ implements MiniParserConstants, MiniParserTreeConstants, org.apache.bcel.Constan } // Get type of subexpressions - for (ASTExpr expr : exprs) { + for (final ASTExpr expr : exprs) { t = expr.eval(child_type); if(t != child_type) { @@ -322,7 +322,7 @@ implements MiniParserConstants, MiniParserTreeConstants, org.apache.bcel.Constan System.out.println(toString(prefix)); if(exprs != null) { - for (ASTExpr expr : exprs) { + for (final ASTExpr expr : exprs) { expr.dump(prefix + " "); } } diff --git a/src/examples/Mini/ASTFunDecl.java b/src/examples/Mini/ASTFunDecl.java index 682207d..46ed3a3 100644 --- a/src/examples/Mini/ASTFunDecl.java +++ b/src/examples/Mini/ASTFunDecl.java @@ -103,7 +103,7 @@ public class ASTFunDecl extends SimpleNode implements MiniParserTreeConstants, o this.env = env; // Put arguments into hash table aka environment - for (ASTIdent element : argv) { + for (final ASTIdent element : argv) { final EnvEntry entry = env.get(element.getName()); if (entry != null) { @@ -326,10 +326,10 @@ public class ASTFunDecl extends SimpleNode implements MiniParserTreeConstants, o System.err.println(targets[0]); - for (InstructionHandle target : targets) { + for (final InstructionHandle target : targets) { final InstructionTargeter[] targeters = target.getTargeters(); - for (InstructionTargeter targeter : targeters) { + for (final InstructionTargeter targeter : targeters) { if ((target != match[4]) || (targeter != match[2])) { System.err.println("Unexpected: " + e); } @@ -414,7 +414,7 @@ public class ASTFunDecl extends SimpleNode implements MiniParserTreeConstants, o public void dump(final String prefix) { System.out.println(toString(prefix)); - for (ASTIdent element : argv) { + for (final ASTIdent element : argv) { element.dump(prefix + " "); } diff --git a/src/examples/Mini/ASTProgram.java b/src/examples/Mini/ASTProgram.java index 498ef4a..5d19b1b 100644 --- a/src/examples/Mini/ASTProgram.java +++ b/src/examples/Mini/ASTProgram.java @@ -116,7 +116,7 @@ implements MiniParserConstants, MiniParserTreeConstants, org.apache.bcel.Constan if(fun_decls != null) { // Put function names into hash table aka. environment - for (ASTFunDecl fun_decl : fun_decls) { + for (final ASTFunDecl fun_decl : fun_decls) { f = fun_decl; name = f.getName(); fname = name.getName(); @@ -159,7 +159,7 @@ implements MiniParserConstants, MiniParserTreeConstants, org.apache.bcel.Constan */ public void eval(final int pass) { - for (ASTFunDecl fun_decl : fun_decls) { + for (final ASTFunDecl fun_decl : fun_decls) { fun_decl.eval(pass); if(pass == 3) { // Final check for unresolved types @@ -193,7 +193,7 @@ implements MiniParserConstants, MiniParserTreeConstants, org.apache.bcel.Constan out.println(" private static int _writeInt(int n) {\n" + " System.out.println(\"Result: \" + n);\n return 0;\n }\n"); - for (ASTFunDecl fun_decl : fun_decls) { + for (final ASTFunDecl fun_decl : fun_decls) { fun_decl.code(out); } @@ -321,7 +321,7 @@ implements MiniParserConstants, MiniParserTreeConstants, org.apache.bcel.Constan method.setMaxStack(5); class_gen.addMethod(method.getMethod()); - for (ASTFunDecl fun_decl : fun_decls) { + for (final ASTFunDecl fun_decl : fun_decls) { fun_decl.byte_code(class_gen, cp); } } @@ -330,7 +330,7 @@ implements MiniParserConstants, MiniParserTreeConstants, org.apache.bcel.Constan public void dump(final String prefix) { System.out.println(toString(prefix)); - for (ASTFunDecl fun_decl : fun_decls) { + for (final ASTFunDecl fun_decl : fun_decls) { fun_decl.dump(prefix + " "); } } diff --git a/src/examples/Mini/MiniC.java b/src/examples/Mini/MiniC.java index 57b18ca..2e73847 100644 --- a/src/examples/Mini/MiniC.java +++ b/src/examples/Mini/MiniC.java @@ -41,7 +41,7 @@ public class MiniC implements org.apache.bcel.Constants { try { /* Parse command line arguments. */ - for (String element : argv) { + for (final String element : argv) { if(element.charAt(0) == '-') { // command line switch if(element.equals("-java")) { byte_code=false; diff --git a/src/examples/Mini/MiniParser.java b/src/examples/Mini/MiniParser.java index 5342f4e..86c2228 100644 --- a/src/examples/Mini/MiniParser.java +++ b/src/examples/Mini/MiniParser.java @@ -956,7 +956,7 @@ public class MiniParser/*@bgen(jjtree)*/implements MiniParserTreeConstants, Mini jj_gen++; if (++jj_gc > 100) { jj_gc = 0; - for (JJCalls jj_2_rtn : jj_2_rtns) { + for (final JJCalls jj_2_rtn : jj_2_rtns) { JJCalls c = jj_2_rtn; while (c != null) { if (c.gen < jj_gen) { @@ -1043,7 +1043,7 @@ public class MiniParser/*@bgen(jjtree)*/implements MiniParserTreeConstants, Mini jj_expentry[i] = jj_lasttokens[i]; } boolean exists = false; - for (int[] j : jj_expentries) { + for (final int[] j : jj_expentries) { final int[] oldentry = (j); if (oldentry.length == jj_expentry.length) { exists = true; diff --git a/src/examples/Mini/ParseException.java b/src/examples/Mini/ParseException.java index 25fafd6..bdd2aed 100644 --- a/src/examples/Mini/ParseException.java +++ b/src/examples/Mini/ParseException.java @@ -117,7 +117,7 @@ public class ParseException extends Exception { } String expected = ""; int maxSize = 0; - for (int[] expectedTokenSequence : expectedTokenSequences) { + for (final int[] expectedTokenSequence : expectedTokenSequences) { if (maxSize < expectedTokenSequence.length) { maxSize = expectedTokenSequence.length; } diff --git a/src/examples/Mini/SimpleNode.java b/src/examples/Mini/SimpleNode.java index 81e9374..9dc3fe0 100644 --- a/src/examples/Mini/SimpleNode.java +++ b/src/examples/Mini/SimpleNode.java @@ -85,7 +85,7 @@ public abstract class SimpleNode implements Node { public void dump(final String prefix) { System.out.println(toString(prefix)); if (children != null) { - for (Node element : children) { + for (final Node element : children) { final SimpleNode n = (SimpleNode)element; if (n != null) { n.dump(prefix + " "); diff --git a/src/examples/listclass.java b/src/examples/listclass.java index eb41d4f..886d4d8 100644 --- a/src/examples/listclass.java +++ b/src/examples/listclass.java @@ -151,7 +151,7 @@ public class listclass { final listclass listClass = new listclass(code, constants, verbose, classdep, nocontents, recurse, exclude_name); - for (String element : file_name) { + for (final String element : file_name) { name = element; listClass.list(name); @@ -182,7 +182,7 @@ public class listclass { return; } - for (String element : exclude_name) { + for (final String element : exclude_name) { if (name.startsWith(element)) { return; }