This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-imaging.git
commit cff708e803bf88358e892251e61d0d9992ab443a Author: Gary Gregory <garydgreg...@gmail.com> AuthorDate: Fri Nov 20 21:34:35 2020 -0500 No need to initialize to default value. --- .../java/org/apache/commons/imaging/formats/jpeg/JpegImageParser.java | 4 +--- .../org/apache/commons/imaging/formats/jpeg/exif/ExifRewriter.java | 3 +-- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/src/main/java/org/apache/commons/imaging/formats/jpeg/JpegImageParser.java b/src/main/java/org/apache/commons/imaging/formats/jpeg/JpegImageParser.java index 4bd6d72..288c239 100644 --- a/src/main/java/org/apache/commons/imaging/formats/jpeg/JpegImageParser.java +++ b/src/main/java/org/apache/commons/imaging/formats/jpeg/JpegImageParser.java @@ -804,9 +804,7 @@ public class JpegImageParser extends ImageParser implements XmpEmbeddable { final List<String> comments = new ArrayList<>(commentSegments.size()); for (final Segment commentSegment : commentSegments) { final ComSegment comSegment = (ComSegment) commentSegment; - String comment = ""; - comment = new String(comSegment.getComment(), StandardCharsets.UTF_8); - comments.add(comment); + comments.add(new String(comSegment.getComment(), StandardCharsets.UTF_8)); } final int numberOfComponents = fSOFNSegment.numberOfComponents; diff --git a/src/main/java/org/apache/commons/imaging/formats/jpeg/exif/ExifRewriter.java b/src/main/java/org/apache/commons/imaging/formats/jpeg/exif/ExifRewriter.java index e292532..c40940d 100644 --- a/src/main/java/org/apache/commons/imaging/formats/jpeg/exif/ExifRewriter.java +++ b/src/main/java/org/apache/commons/imaging/formats/jpeg/exif/ExifRewriter.java @@ -392,8 +392,7 @@ public class ExifRewriter extends BinaryFileParser { // Just use first APP1 segment for now. // Multiple APP1 segments are rare and poorly supported. if (!jfifPieces.exifPieces.isEmpty()) { - JFIFPieceSegment exifPiece = null; - exifPiece = (JFIFPieceSegment) jfifPieces.exifPieces.get(0); + final JFIFPieceSegment exifPiece = (JFIFPieceSegment) jfifPieces.exifPieces.get(0); byte[] exifBytes = exifPiece.segmentData; exifBytes = remainingBytes("trimmed exif bytes", exifBytes, 6);