This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-dbutils.git
The following commit(s) were added to refs/heads/master by this push:
new 8ac08e4 No need to initialize to default value.
8ac08e4 is described below
commit 8ac08e48c0be14a6aee7626f666545eb8316f523
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Fri Nov 20 19:08:44 2020 -0500
No need to initialize to default value.
---
.../java/org/apache/commons/dbutils/BasicRowProcessorTest.java | 5 ++---
src/test/java/org/apache/commons/dbutils/BeanProcessorTest.java | 3 +--
.../java/org/apache/commons/dbutils/ResultSetIteratorTest.java | 3 +--
.../org/apache/commons/dbutils/handlers/ArrayListHandlerTest.java | 3 +--
.../org/apache/commons/dbutils/handlers/BeanListHandlerTest.java | 7 +++----
.../org/apache/commons/dbutils/handlers/MapListHandlerTest.java | 3 +--
6 files changed, 9 insertions(+), 15 deletions(-)
diff --git
a/src/test/java/org/apache/commons/dbutils/BasicRowProcessorTest.java
b/src/test/java/org/apache/commons/dbutils/BasicRowProcessorTest.java
index 349cd97..ae6bff2 100644
--- a/src/test/java/org/apache/commons/dbutils/BasicRowProcessorTest.java
+++ b/src/test/java/org/apache/commons/dbutils/BasicRowProcessorTest.java
@@ -41,7 +41,7 @@ public class BasicRowProcessorTest extends BaseTestCase {
public void testToArray() throws SQLException {
- Object[] a = null;
+ Object[] a;
assertTrue(this.rs.next());
a = processor.toArray(this.rs);
assertEquals(COLS, a.length);
@@ -62,9 +62,8 @@ public class BasicRowProcessorTest extends BaseTestCase {
public void testToBean() throws SQLException, ParseException {
- TestBean row = null;
assertTrue(this.rs.next());
- row = processor.toBean(this.rs, TestBean.class);
+ TestBean row = processor.toBean(this.rs, TestBean.class);
assertEquals("1", row.getOne());
assertEquals("2", row.getTwo());
assertEquals(TestBean.Ordinal.THREE, row.getThree());
diff --git a/src/test/java/org/apache/commons/dbutils/BeanProcessorTest.java
b/src/test/java/org/apache/commons/dbutils/BeanProcessorTest.java
index 52161b8..d909f75 100644
--- a/src/test/java/org/apache/commons/dbutils/BeanProcessorTest.java
+++ b/src/test/java/org/apache/commons/dbutils/BeanProcessorTest.java
@@ -30,9 +30,8 @@ public class BeanProcessorTest extends BaseTestCase {
private static final BeanProcessor beanProc = new BeanProcessor();
public void testProcessWithToBean() throws SQLException {
- TestBean b = null;
assertTrue(this.rs.next());
- b = beanProc.toBean(this.rs, TestBean.class);
+ TestBean b = beanProc.toBean(this.rs, TestBean.class);
assertEquals(13.0, b.getColumnProcessorDoubleTest(), 0);
assertEquals(b.getThree(), TestBean.Ordinal.THREE);
diff --git
a/src/test/java/org/apache/commons/dbutils/ResultSetIteratorTest.java
b/src/test/java/org/apache/commons/dbutils/ResultSetIteratorTest.java
index 23cda5c..491a378 100644
--- a/src/test/java/org/apache/commons/dbutils/ResultSetIteratorTest.java
+++ b/src/test/java/org/apache/commons/dbutils/ResultSetIteratorTest.java
@@ -33,9 +33,8 @@ public class ResultSetIteratorTest extends BaseTestCase {
final Iterator<Object[]> iter = new ResultSetIterator(this.rs);
- Object[] row = null;
assertTrue(iter.hasNext());
- row = iter.next();
+ Object[] row = iter.next();
assertEquals(COLS, row.length);
assertEquals("1", row[0]);
assertEquals("2", row[1]);
diff --git
a/src/test/java/org/apache/commons/dbutils/handlers/ArrayListHandlerTest.java
b/src/test/java/org/apache/commons/dbutils/handlers/ArrayListHandlerTest.java
index a8013ac..f832dc8 100644
---
a/src/test/java/org/apache/commons/dbutils/handlers/ArrayListHandlerTest.java
+++
b/src/test/java/org/apache/commons/dbutils/handlers/ArrayListHandlerTest.java
@@ -36,9 +36,8 @@ public class ArrayListHandlerTest extends BaseTestCase {
assertEquals(ROWS, results.size());
final Iterator<Object[]> iter = results.iterator();
- Object[] row = null;
assertTrue(iter.hasNext());
- row = iter.next();
+ Object[] row = iter.next();
assertEquals(COLS, row.length);
assertEquals("1", row[0]);
assertEquals("2", row[1]);
diff --git
a/src/test/java/org/apache/commons/dbutils/handlers/BeanListHandlerTest.java
b/src/test/java/org/apache/commons/dbutils/handlers/BeanListHandlerTest.java
index 0284cdf..1cca821 100644
--- a/src/test/java/org/apache/commons/dbutils/handlers/BeanListHandlerTest.java
+++ b/src/test/java/org/apache/commons/dbutils/handlers/BeanListHandlerTest.java
@@ -37,7 +37,7 @@ public class BeanListHandlerTest extends BaseTestCase {
assertEquals(ROWS, results.size());
final Iterator<TestBean> iter = results.iterator();
- TestBean row = null;
+ TestBean row;
assertTrue(iter.hasNext());
row = iter.next();
assertEquals("1", row.getOne());
@@ -72,9 +72,8 @@ public class BeanListHandlerTest extends BaseTestCase {
assertEquals(ROWS, results.size());
final Iterator<TestBean> iter = results.iterator();
- TestBean row = null;
assertTrue(iter.hasNext());
- row = iter.next();
+ TestBean row = iter.next();
assertSame(SubTestBean.class, row.getClass());
assertEquals("1", row.getOne());
@@ -102,7 +101,7 @@ public class BeanListHandlerTest extends BaseTestCase {
assertEquals(ROWS, results.size());
final Iterator<SubTestBeanInterface> iter = results.iterator();
- SubTestBeanInterface row = null;
+ SubTestBeanInterface row;
assertTrue(iter.hasNext());
row = iter.next();
assertSame(SubTestBean.class, row.getClass());
diff --git
a/src/test/java/org/apache/commons/dbutils/handlers/MapListHandlerTest.java
b/src/test/java/org/apache/commons/dbutils/handlers/MapListHandlerTest.java
index 2f29f26..0ed16a4 100644
--- a/src/test/java/org/apache/commons/dbutils/handlers/MapListHandlerTest.java
+++ b/src/test/java/org/apache/commons/dbutils/handlers/MapListHandlerTest.java
@@ -37,9 +37,8 @@ public class MapListHandlerTest extends BaseTestCase {
assertEquals(ROWS, results.size());
final Iterator<Map<String,Object>> iter = results.iterator();
- Map<String,Object> row = null;
assertTrue(iter.hasNext());
- row = iter.next();
+ Map<String,Object> row = iter.next();
assertEquals(COLS, row.size());
assertEquals("1", row.get("one"));
assertEquals("2", row.get("TWO"));
