[commons-compress] branch master updated: Modify some calls of method Collection.toArray

[peterlee]

This is an automated email from the ASF dual-hosted git repository.

peterlee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-compress.git


The following commit(s) were added to refs/heads/master by this push:
     new ef3cad0  Modify some calls of method Collection.toArray
ef3cad0 is described below

commit ef3cad07da846a9a0a2b9112c4f8859e10926e3d
Author: PeterAlfredLee <peteralfred...@gmail.com>
AuthorDate: Fri Oct 30 15:02:05 2020 +0800

    Modify some calls of method Collection.toArray
    
    Use method with empty array instead of pre size array, cause it's thread
    safe and faster.
---
 .../org/apache/commons/compress/archivers/zip/ExtraFieldUtils.java  | 3 +--
 .../java/org/apache/commons/compress/archivers/zip/ZipFile.java     | 2 +-
 .../compress/archivers/zip/ZipSplitReadOnlySeekableByteChannel.java | 6 ++----
 3 files changed, 4 insertions(+), 7 deletions(-)

diff --git 
a/src/main/java/org/apache/commons/compress/archivers/zip/ExtraFieldUtils.java 
b/src/main/java/org/apache/commons/compress/archivers/zip/ExtraFieldUtils.java
index dd22f03..a1600bc 100644
--- 
a/src/main/java/org/apache/commons/compress/archivers/zip/ExtraFieldUtils.java
+++ 
b/src/main/java/org/apache/commons/compress/archivers/zip/ExtraFieldUtils.java
@@ -219,8 +219,7 @@ public class ExtraFieldUtils {
             }
         }
 
-        final ZipExtraField[] result = new ZipExtraField[v.size()];
-        return v.toArray(result);
+        return v.toArray(new ZipExtraField[0]);
     }
 
     /**
diff --git 
a/src/main/java/org/apache/commons/compress/archivers/zip/ZipFile.java 
b/src/main/java/org/apache/commons/compress/archivers/zip/ZipFile.java
index 0b1e27b..f46ae5b 100644
--- a/src/main/java/org/apache/commons/compress/archivers/zip/ZipFile.java
+++ b/src/main/java/org/apache/commons/compress/archivers/zip/ZipFile.java
@@ -439,7 +439,7 @@ public class ZipFile implements Closeable {
      * @since 1.1
      */
     public Enumeration<ZipArchiveEntry> getEntriesInPhysicalOrder() {
-        final ZipArchiveEntry[] allEntries = entries.toArray(new 
ZipArchiveEntry[entries.size()]);
+        final ZipArchiveEntry[] allEntries = entries.toArray(new 
ZipArchiveEntry[0]);
         Arrays.sort(allEntries, offsetComparator);
         return Collections.enumeration(Arrays.asList(allEntries));
     }
diff --git 
a/src/main/java/org/apache/commons/compress/archivers/zip/ZipSplitReadOnlySeekableByteChannel.java
 
b/src/main/java/org/apache/commons/compress/archivers/zip/ZipSplitReadOnlySeekableByteChannel.java
index 7c98584..3756198 100644
--- 
a/src/main/java/org/apache/commons/compress/archivers/zip/ZipSplitReadOnlySeekableByteChannel.java
+++ 
b/src/main/java/org/apache/commons/compress/archivers/zip/ZipSplitReadOnlySeekableByteChannel.java
@@ -143,8 +143,7 @@ public class ZipSplitReadOnlySeekableByteChannel extends 
MultiReadOnlySeekableBy
         }
         channelsList.add(lastSegmentChannel);
 
-        final SeekableByteChannel[] channelArray = new 
SeekableByteChannel[channelsList.size()];
-        return 
forOrderedSeekableByteChannels(channelsList.toArray(channelArray));
+        return forOrderedSeekableByteChannels(channelsList.toArray(new 
SeekableByteChannel[0]));
     }
 
     /**
@@ -226,8 +225,7 @@ public class ZipSplitReadOnlySeekableByteChannel extends 
MultiReadOnlySeekableBy
         }
         filesList.add(lastSegmentFile);
 
-        final File[] filesArray = new File[filesList.size()];
-        return forFiles(filesList.toArray(filesArray));
+        return forFiles(filesList.toArray(new File[0]));
     }
 
     private static class ZipSplitSegmentComparator implements 
Comparator<File>, Serializable {