This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-validator.git


The following commit(s) were added to refs/heads/master by this push:
     new 94bb3fc  Must validate schemes here
94bb3fc is described below

commit 94bb3fc9ae646c6128a1d34e07910a48b5c5b64f
Author: Sebb <s...@apache.org>
AuthorDate: Tue Jul 28 13:23:37 2020 +0100

    Must validate schemes here
---
 src/main/java/org/apache/commons/validator/routines/UrlValidator.java | 1 -
 1 file changed, 1 deletion(-)

diff --git 
a/src/main/java/org/apache/commons/validator/routines/UrlValidator.java 
b/src/main/java/org/apache/commons/validator/routines/UrlValidator.java
index 526b14f..4104ff2 100644
--- a/src/main/java/org/apache/commons/validator/routines/UrlValidator.java
+++ b/src/main/java/org/apache/commons/validator/routines/UrlValidator.java
@@ -331,7 +331,6 @@ public class UrlValidator implements Serializable {
             return false;
         }
 
-        // TODO could be removed if external schemes were checked in the ctor 
before being stored
         if (!SCHEME_PATTERN.matcher(scheme).matches()) {
             return false;
         }

Reply via email to