[commons-text] branch master updated: Remove new toString(int, int) method in favor of existing midString(int, int).

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-text.git


The following commit(s) were added to refs/heads/master by this push:
     new d983bac  Remove new toString(int,int) method in favor of existing 
midString(int,int).
d983bac is described below

commit d983baceee6d1a9c1ae0327a8ff4872938b36187
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Tue Jul 21 10:49:01 2020 -0400

    Remove new toString(int,int) method in favor of existing
    midString(int,int).
---
 .../java/org/apache/commons/text/StringSubstitutor.java    |  4 ++--
 .../java/org/apache/commons/text/TextStringBuilder.java    | 14 --------------
 .../org/apache/commons/text/TextStringBuilderTest.java     | 13 -------------
 3 files changed, 2 insertions(+), 29 deletions(-)

diff --git a/src/main/java/org/apache/commons/text/StringSubstitutor.java 
b/src/main/java/org/apache/commons/text/StringSubstitutor.java
index 098d7bb..53194ac 100644
--- a/src/main/java/org/apache/commons/text/StringSubstitutor.java
+++ b/src/main/java/org/apache/commons/text/StringSubstitutor.java
@@ -1385,7 +1385,7 @@ public class StringSubstitutor {
                                 continue outer;
                             }
                             // get var name
-                            String varNameExpr = builder.toString(startPos + 
startMatchLen,
+                            String varNameExpr = builder.midString(startPos + 
startMatchLen,
                                 pos - startPos - startMatchLen);
                             if (substitutionInVariablesEnabled) {
                                 final TextStringBuilder bufName = new 
TextStringBuilder(varNameExpr);
@@ -1422,7 +1422,7 @@ public class StringSubstitutor {
                             // on the first call initialize priorVariables
                             if (priorVariables == null) {
                                 priorVariables = new ArrayList<>();
-                                priorVariables.add(builder.toString(offset, 
length));
+                                priorVariables.add(builder.midString(offset, 
length));
                             }
 
                             // handle cyclic substitution
diff --git a/src/main/java/org/apache/commons/text/TextStringBuilder.java 
b/src/main/java/org/apache/commons/text/TextStringBuilder.java
index 89c2f01..6c0301d 100644
--- a/src/main/java/org/apache/commons/text/TextStringBuilder.java
+++ b/src/main/java/org/apache/commons/text/TextStringBuilder.java
@@ -3037,20 +3037,6 @@ public class TextStringBuilder implements CharSequence, 
Appendable, Serializable
     }
 
     /**
-     * Extracts a portion of this string builder as a string.
-     *
-     * @param startIndex The initial offset
-     * @param count the desired length
-     * @return The new string
-     * @throws IndexOutOfBoundsException if the index is invalid
-     * @since 1.9
-     */
-    public String toString(final int startIndex, final int count) {
-        validateIndices(startIndex, startIndex + count);
-        return new String(buffer, startIndex, count);
-    }
-
-    /**
      * Gets a StringBuffer version of the string builder, creating a new 
instance each time the method is called.
      *
      * @return The builder as a StringBuffer
diff --git a/src/test/java/org/apache/commons/text/TextStringBuilderTest.java 
b/src/test/java/org/apache/commons/text/TextStringBuilderTest.java
index 3f1eff1..8e47b43 100644
--- a/src/test/java/org/apache/commons/text/TextStringBuilderTest.java
+++ b/src/test/java/org/apache/commons/text/TextStringBuilderTest.java
@@ -2186,19 +2186,6 @@ public class TextStringBuilderTest {
     }
 
     @Test
-    public void testToStringIntInt() {
-        final TextStringBuilder sb = new TextStringBuilder("hello goodbye");
-        assertEquals("hello", sb.substring(0, 5));
-        assertEquals("hello goodbye".substring(0, 6), sb.toString(0, 6));
-
-        assertEquals("goodbye", sb.toString(6, 7));
-
-        assertThrows(IndexOutOfBoundsException.class, () -> sb.toString(-1, 
5));
-
-        assertThrows(IndexOutOfBoundsException.class, () -> sb.toString(15, 
20));
-    }
-
-    @Test
     public void testTrim() {
         final TextStringBuilder sb = new TextStringBuilder();
         assertEquals("", sb.reverse().toString());