[commons-numbers] 03/08: Fix SonarCloud: Remove nested ternary

[aherbert]

This is an automated email from the ASF dual-hosted git repository.

aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git

commit 7ab58cc1d403611d1869847260953d0302154acc
Author: aherbert <aherb...@apache.org>
AuthorDate: Mon Jun 29 15:52:45 2020 +0100

    Fix SonarCloud: Remove nested ternary
---
 .../apache/commons/numbers/combinatorics/FactorialDouble.java | 11 ++++++++---
 .../apache/commons/numbers/combinatorics/LogFactorial.java    | 11 ++++++++---
 2 files changed, 16 insertions(+), 6 deletions(-)

diff --git 
a/commons-numbers-combinatorics/src/main/java/org/apache/commons/numbers/combinatorics/FactorialDouble.java
 
b/commons-numbers-combinatorics/src/main/java/org/apache/commons/numbers/combinatorics/FactorialDouble.java
index 32cd5d1..f3c34dc 100644
--- 
a/commons-numbers-combinatorics/src/main/java/org/apache/commons/numbers/combinatorics/FactorialDouble.java
+++ 
b/commons-numbers-combinatorics/src/main/java/org/apache/commons/numbers/combinatorics/FactorialDouble.java
@@ -54,9 +54,14 @@ public final class FactorialDouble {
         }
 
         final int beginCopy = 2;
-        final int endCopy = cache == null || cache.length <= beginCopy ?
-            beginCopy : cache.length <= numValues ?
-            cache.length : numValues;
+        int endCopy;
+        if (cache == null || cache.length <= beginCopy) {
+            endCopy = beginCopy;
+        } else if (cache.length <= numValues) {
+            endCopy = cache.length;
+        } else {
+            endCopy = numValues;
+        }
 
         // Copy available values.
         for (int i = beginCopy; i < endCopy; i++) {
diff --git 
a/commons-numbers-combinatorics/src/main/java/org/apache/commons/numbers/combinatorics/LogFactorial.java
 
b/commons-numbers-combinatorics/src/main/java/org/apache/commons/numbers/combinatorics/LogFactorial.java
index 00b6813..76af8a2 100644
--- 
a/commons-numbers-combinatorics/src/main/java/org/apache/commons/numbers/combinatorics/LogFactorial.java
+++ 
b/commons-numbers-combinatorics/src/main/java/org/apache/commons/numbers/combinatorics/LogFactorial.java
@@ -52,9 +52,14 @@ public final class LogFactorial {
         logFactorials = new double[numValues];
 
         final int beginCopy = 2;
-        final int endCopy = cache == null || cache.length <= beginCopy ?
-            beginCopy : cache.length <= numValues ?
-            cache.length : numValues;
+        int endCopy;
+        if (cache == null || cache.length <= beginCopy) {
+            endCopy = beginCopy;
+        } else if (cache.length <= numValues) {
+            endCopy = cache.length;
+        } else {
+            endCopy = numValues;
+        }
 
         // Copy available values.
         for (int i = beginCopy; i < endCopy; i++) {