This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-crypto.git
The following commit(s) were added to refs/heads/master by this push:
new 1ac73be Need double quote when JAVA_HOME contains spaces.
1ac73be is described below
commit 1ac73be93c01070fcd177d847a9077968f19d991
Author: Gary Gregory <[email protected]>
AuthorDate: Sat Jun 13 09:51:05 2020 -0400
Need double quote when JAVA_HOME contains spaces.
---
Makefile.common | 60 ++++++++++++++++++++++++++++-----------------------------
1 file changed, 30 insertions(+), 30 deletions(-)
diff --git a/Makefile.common b/Makefile.common
index f0f99c5..1cba294 100644
--- a/Makefile.common
+++ b/Makefile.common
@@ -68,8 +68,8 @@ CROSS_PREFIX :=
Default_CC := $(CROSS_PREFIX)gcc
Default_CXX := $(CROSS_PREFIX)g++
Default_STRIP := $(CROSS_PREFIX)strip
-Default_CFLAGS := -I$(JAVA_HOME)/include -Ilib/inc_mac -O2 -fPIC
-fvisibility=hidden
-Default_CXXFLAGS := -I$(JAVA_HOME)/include -Ilib/inc_mac -O2 -fPIC
-fvisibility=hidden
+Default_CFLAGS := -I"$(JAVA_HOME)/include" -Ilib/inc_mac -O2 -fPIC
-fvisibility=hidden
+Default_CXXFLAGS := -I"$(JAVA_HOME)/include" -Ilib/inc_mac -O2 -fPIC
-fvisibility=hidden
Default_LINKFLAGS := -shared -static
Default_LIBNAME := libcommons-crypto.so
Default_COMMONS_CRYPTO_FLAGS :=
@@ -77,8 +77,8 @@ Default_COMMONS_CRYPTO_FLAGS :=
Linux-x86_CC := $(CROSS_PREFIX)gcc
Linux-x86_CXX := $(CROSS_PREFIX)g++
Linux-x86_STRIP := $(CROSS_PREFIX)strip
-Linux-x86_CXXFLAGS := -I$(JAVA_HOME)/include -O2 -fPIC -fvisibility=hidden
-m32
-Linux-x86_CFLAGS := -I$(JAVA_HOME)/include -O2 -fPIC -fvisibility=hidden
-m32
+Linux-x86_CXXFLAGS := -I"$(JAVA_HOME)/include" -O2 -fPIC -fvisibility=hidden
-m32
+Linux-x86_CFLAGS := -I"$(JAVA_HOME)/include" -O2 -fPIC -fvisibility=hidden
-m32
Linux-x86_LINKFLAGS := -shared -static-libgcc -static-libstdc++
Linux-x86_LIBNAME := libcommons-crypto.so
Linux-x86_COMMONS_CRYPTO_FLAGS:=
@@ -86,8 +86,8 @@ Linux-x86_COMMONS_CRYPTO_FLAGS:=
Linux-x86_64_CC := $(CROSS_PREFIX)gcc
Linux-x86_64_CXX := $(CROSS_PREFIX)g++
Linux-x86_64_STRIP := $(CROSS_PREFIX)strip
-Linux-x86_64_CXXFLAGS := -Ilib/inc_linux -I$(JAVA_HOME)/include -Ilib/inc_mac
-O2 -fPIC -fvisibility=hidden -m64 -Wall -Werror
-Linux-x86_64_CFLAGS := -Ilib/inc_linux -I$(JAVA_HOME)/include -Ilib/inc_mac
-O2 -fPIC -fvisibility=hidden -m64 -Wall -Werror
+Linux-x86_64_CXXFLAGS := -Ilib/inc_linux -I"$(JAVA_HOME)/include"
-Ilib/inc_mac -O2 -fPIC -fvisibility=hidden -m64 -Wall -Werror
+Linux-x86_64_CFLAGS := -Ilib/inc_linux -I"$(JAVA_HOME)/include"
-Ilib/inc_mac -O2 -fPIC -fvisibility=hidden -m64 -Wall -Werror
Linux-x86_64_LINKFLAGS := -shared -static-libgcc
Linux-x86_64_LIBNAME := libcommons-crypto.so
Linux-x86_64_COMMONS_CRYPTO_FLAGS :=
@@ -95,8 +95,8 @@ Linux-x86_64_COMMONS_CRYPTO_FLAGS :=
Linux-ppc_CC := gcc
Linux-ppc_CXX := g++
Linux-ppc_STRIP := strip
-Linux-ppc_CXXFLAGS := -DHAVE_CONFIG_H -Ilib/inc_linux
-I$(JAVA_HOME)/include -Ilib/inc_mac -O2 -fPIC -fvisibility=hidden -m32
-Linux-ppc_CFLAGS := -DHAVE_CONFIG_H -Ilib/inc_linux
-I$(JAVA_HOME)/include -Ilib/inc_mac -O2 -fPIC -fvisibility=hidden -m32
+Linux-ppc_CXXFLAGS := -DHAVE_CONFIG_H -Ilib/inc_linux
-I"$(JAVA_HOME)/include" -Ilib/inc_mac -O2 -fPIC -fvisibility=hidden -m32
+Linux-ppc_CFLAGS := -DHAVE_CONFIG_H -Ilib/inc_linux
-I"$(JAVA_HOME)/include" -Ilib/inc_mac -O2 -fPIC -fvisibility=hidden -m32
Linux-ppc_LINKFLAGS := -shared -static-libgcc -static-libstdc++
Linux-ppc_LIBNAME := libcommons-crypto.so
Linux-ppc_COMMONS_CRYPTO_FLAGS :=
@@ -104,8 +104,8 @@ Linux-ppc_COMMONS_CRYPTO_FLAGS :=
Linux-ppc64_CC := gcc
Linux-ppc64_CXX := g++
Linux-ppc64_STRIP := strip
-Linux-ppc64_CXXFLAGS := -DHAVE_CONFIG_H -Ilib/inc_linux
-I$(JAVA_HOME)/include -Ilib/inc_mac -O2 -fPIC -fvisibility=hidden -m64
-Linux-ppc64_CFLAGS := -DHAVE_CONFIG_H -Ilib/inc_linux
-I$(JAVA_HOME)/include -Ilib/inc_mac -O2 -fPIC -fvisibility=hidden -m64
+Linux-ppc64_CXXFLAGS := -DHAVE_CONFIG_H -Ilib/inc_linux
-I"$(JAVA_HOME)/include" -Ilib/inc_mac -O2 -fPIC -fvisibility=hidden -m64
+Linux-ppc64_CFLAGS := -DHAVE_CONFIG_H -Ilib/inc_linux
-I"$(JAVA_HOME)/include" -Ilib/inc_mac -O2 -fPIC -fvisibility=hidden -m64
Linux-ppc64_LINKFLAGS := -shared -static-libgcc -static-libstdc++
Linux-ppc64_LIBNAME := libcommons-crypto.so
Linux-ppc64_COMMONS_CRYPTO_FLAGS :=
@@ -114,16 +114,16 @@ AIX-ppc64_CC := gcc
AIX-ppc64_CXX := g++
AIX-ppc64_STRIP := strip -X64
AIX-ppc64_LIBNAME := libcommons-crypto.a
-AIX-ppc64_CXXFLAGS := -DHAVE_CONFIG_H -Ilib/inc_linux
-I$(JAVA_HOME)/include -Ilib/inc_mac -O2 -fPIC -fvisibility=hidden -m64
-AIX-ppc64_CFLAGS := -DHAVE_CONFIG_H -Ilib/inc_linux
-I$(JAVA_HOME)/include -Ilib/inc_mac -O2 -fPIC -fvisibility=hidden -m64
+AIX-ppc64_CXXFLAGS := -DHAVE_CONFIG_H -Ilib/inc_linux
-I"$(JAVA_HOME)/include" -Ilib/inc_mac -O2 -fPIC -fvisibility=hidden -m64
+AIX-ppc64_CFLAGS := -DHAVE_CONFIG_H -Ilib/inc_linux
-I"$(JAVA_HOME)/include" -Ilib/inc_mac -O2 -fPIC -fvisibility=hidden -m64
AIX-ppc64_LINKFLAGS := -shared -static-libgcc -static-libstdc++ -lcrypt
AIX-ppc64_COMMONS_CRYPTO_FLAGS :=
SunOS-x86_CC := gcc
SunOS-x86_CXX := g++
SunOS-x86_STRIP := strip
-SunOS-x86_CFLAGS := -include lib/inc_linux/jni_md.h -I$(JAVA_HOME)/include
-O2 -fPIC -fvisibility=hidden
-SunOS-x86_CXXFLAGS := -include lib/inc_linux/jni_md.h -I$(JAVA_HOME)/include
-O2 -fPIC -fvisibility=hidden
+SunOS-x86_CFLAGS := -include lib/inc_linux/jni_md.h
-I"$(JAVA_HOME)/include" -O2 -fPIC -fvisibility=hidden
+SunOS-x86_CXXFLAGS := -include lib/inc_linux/jni_md.h
-I"$(JAVA_HOME)/include" -O2 -fPIC -fvisibility=hidden
SunOS-x86_LINKFLAGS := -shared -static-libgcc -static-libstdc++
SunOS-x86_LIBNAME := libcommons-crypto.so
SunOS-x86_COMMONS_CRYPTO_FLAGS :=
@@ -131,8 +131,8 @@ SunOS-x86_COMMONS_CRYPTO_FLAGS :=
SunOS-sparc_CC := gcc
SunOS-sparc_CXX := g++
SunOS-sparc_STRIP := strip
-SunOS-sparc_CFLAGS := -include lib/inc_linux/jni_md.h
-I$(JAVA_HOME)/include -O2 -fPIC -fvisibility=hidden
-SunOS-sparc_CXXFLAGS := -include lib/inc_linux/jni_md.h
-I$(JAVA_HOME)/include -O2 -fPIC -fvisibility=hidden
+SunOS-sparc_CFLAGS := -include lib/inc_linux/jni_md.h
-I"$(JAVA_HOME)/include" -O2 -fPIC -fvisibility=hidden
+SunOS-sparc_CXXFLAGS := -include lib/inc_linux/jni_md.h
-I"$(JAVA_HOME)/include" -O2 -fPIC -fvisibility=hidden
SunOS-sparc_LINKFLAGS := -shared -static-libgcc -static-libstdc++
SunOS-sparc_LIBNAME := libcommons-crypto.so
SunOS-sparc_COMMONS_CRYPTO_FLAGS :=
@@ -140,8 +140,8 @@ SunOS-sparc_COMMONS_CRYPTO_FLAGS :=
SunOS-x86_64_CC := gcc
SunOS-x86_64_CXX := g++
SunOS-x86_64_STRIP := strip
-SunOS-x86_64_CFLAGS := -include lib/inc_linux/jni_md.h
-I$(JAVA_HOME)/include -O2 -fPIC -fvisibility=hidden -m64
-SunOS-x86_64_CXXFLAGS := -include lib/inc_linux/jni_md.h
-I$(JAVA_HOME)/include -O2 -fPIC -fvisibility=hidden -m64
+SunOS-x86_64_CFLAGS := -include lib/inc_linux/jni_md.h
-I"$(JAVA_HOME)/include" -O2 -fPIC -fvisibility=hidden -m64
+SunOS-x86_64_CXXFLAGS := -include lib/inc_linux/jni_md.h
-I"$(JAVA_HOME)/include" -O2 -fPIC -fvisibility=hidden -m64
SunOS-x86_64_LINKFLAGS := -shared -static-libgcc -static-libstdc++
SunOS-x86_64_LIBNAME := libcommons-crypto.so
SunOS-x86_64_COMMONS_CRYPTO_FLAGS :=
@@ -154,8 +154,8 @@ SunOS-x86_64_COMMONS_CRYPTO_FLAGS :=
Linux-arm_CC := $(CROSS_PREFIX)gcc
Linux-arm_CXX := $(CROSS_PREFIX)g++
Linux-arm_STRIP := $(CROSS_PREFIX)strip
-Linux-arm_CFLAGS := -include lib/inc_linux/jni_md.h -I$(JAVA_HOME)/include
-O2 -fPIC -fvisibility=hidden -mfloat-abi=softfp
-Linux-arm_CXXFLAGS := -include lib/inc_linux/jni_md.h -I$(JAVA_HOME)/include
-O2 -fPIC -fvisibility=hidden -mfloat-abi=softfp
+Linux-arm_CFLAGS := -include lib/inc_linux/jni_md.h
-I"$(JAVA_HOME)/include" -O2 -fPIC -fvisibility=hidden -mfloat-abi=softfp
+Linux-arm_CXXFLAGS := -include lib/inc_linux/jni_md.h
-I"$(JAVA_HOME)/include" -O2 -fPIC -fvisibility=hidden -mfloat-abi=softfp
Linux-arm_LINKFLAGS := -shared -static-libgcc
Linux-arm_LIBNAME := libcommons-crypto.so
Linux-arm_COMMONS_CRYPTO_FLAGS:=
@@ -163,8 +163,8 @@ Linux-arm_COMMONS_CRYPTO_FLAGS:=
Linux-armhf_CC := $(CROSS_PREFIX)gcc
Linux-armhf_CXX := $(CROSS_PREFIX)g++
Linux-armhf_STRIP := $(CROSS_PREFIX)strip
-Linux-armhf_CFLAGS := -include lib/inc_linux/jni_md.h
-I$(JAVA_HOME)/include -O2 -fPIC -fvisibility=hidden -mfloat-abi=hard
-Linux-armhf_CXXFLAGS := -include lib/inc_linux/jni_md.h
-I$(JAVA_HOME)/include -O2 -fPIC -fvisibility=hidden -mfloat-abi=hard
+Linux-armhf_CFLAGS := -include lib/inc_linux/jni_md.h
-I"$(JAVA_HOME)/include" -O2 -fPIC -fvisibility=hidden -mfloat-abi=hard
+Linux-armhf_CXXFLAGS := -include lib/inc_linux/jni_md.h
-I"$(JAVA_HOME)/include" -O2 -fPIC -fvisibility=hidden -mfloat-abi=hard
Linux-armhf_LINKFLAGS := -shared -static-libgcc
Linux-armhf_LIBNAME := libcommons-crypto.so
Linux-armhf_COMMONS_CRYPTO_FLAGS:=
@@ -172,8 +172,8 @@ Linux-armhf_COMMONS_CRYPTO_FLAGS:=
Linux-aarch64_CC := $(CROSS_PREFIX)gcc
Linux-aarch64_CXX := $(CROSS_PREFIX)g++
Linux-aarch64_STRIP := $(CROSS_PREFIX)strip
-Linux-aarch64_CXXFLAGS := -Ilib/inc_linux -I$(JAVA_HOME)/include
-Ilib/inc_mac -O2 -fPIC -fvisibility=hidden -Wall -Werror
-Linux-aarch64_CFLAGS := -Ilib/inc_linux -I$(JAVA_HOME)/include
-Ilib/inc_mac -O2 -fPIC -fvisibility=hidden -Wall -Werror
+Linux-aarch64_CXXFLAGS := -Ilib/inc_linux -I"$(JAVA_HOME)/include"
-Ilib/inc_mac -O2 -fPIC -fvisibility=hidden -Wall -Werror
+Linux-aarch64_CFLAGS := -Ilib/inc_linux -I"$(JAVA_HOME)/include"
-Ilib/inc_mac -O2 -fPIC -fvisibility=hidden -Wall -Werror
Linux-aarch64_LINKFLAGS := -shared -static-libgcc
Linux-aarch64_LIBNAME := libcommons-crypto.so
Linux-aarch64_COMMONS_CRYPTO_FLAGS :=
@@ -181,8 +181,8 @@ Linux-aarch64_COMMONS_CRYPTO_FLAGS :=
Mac-x86_CC := gcc -arch i386
Mac-x86_CXX := g++ -arch i386
Mac-x86_STRIP := strip -x
-Mac-x86_CFLAGS := -Ilib/inc_mac -I$(JAVA_HOME)/include -O2 -fPIC
-mmacosx-version-min=10.4 -fvisibility=hidden -I/usr/local/include
-I/usr/local/opt/openssl/include
-Mac-x86_CXXFLAGS := -Ilib/inc_mac -I$(JAVA_HOME)/include -O2 -fPIC
-mmacosx-version-min=10.4 -fvisibility=hidden -I/usr/local/include
-I/usr/local/opt/openssl/include
+Mac-x86_CFLAGS := -Ilib/inc_mac -I"$(JAVA_HOME)/include" -O2 -fPIC
-mmacosx-version-min=10.4 -fvisibility=hidden -I/usr/local/include
-I/usr/local/opt/openssl/include
+Mac-x86_CXXFLAGS := -Ilib/inc_mac -I"$(JAVA_HOME)/include" -O2 -fPIC
-mmacosx-version-min=10.4 -fvisibility=hidden -I/usr/local/include
-I/usr/local/opt/openssl/include
Mac-x86_LINKFLAGS := -dynamiclib -static-libgcc -L/usr/local/lib
Mac-x86_LIBNAME := libcommons-crypto.jnilib
Mac-x86_COMMONS_CRYPTO_FLAGS :=
@@ -190,8 +190,8 @@ Mac-x86_COMMONS_CRYPTO_FLAGS :=
Mac-x86_64_CC := gcc -arch $(OS_ARCH)
Mac-x86_64_CXX := gcc -arch $(OS_ARCH)
Mac-x86_64_STRIP := strip -x
-Mac-x86_64_CFLAGS := -Ilib/inc_mac -I$(JAVA_HOME)/include -O2 -fPIC
-mmacosx-version-min=10.7 -fvisibility=hidden -I/usr/local/include
-I/usr/local/opt/openssl/include
-Mac-x86_64_CXXFLAGS := -Ilib/inc_mac -I$(JAVA_HOME)/include -O2 -fPIC
-mmacosx-version-min=10.7 -fvisibility=hidden -I/usr/local/include
-I/usr/local/opt/openssl/include
+Mac-x86_64_CFLAGS := -Ilib/inc_mac -I"$(JAVA_HOME)/include" -O2 -fPIC
-mmacosx-version-min=10.7 -fvisibility=hidden -I/usr/local/include
-I/usr/local/opt/openssl/include
+Mac-x86_64_CXXFLAGS := -Ilib/inc_mac -I"$(JAVA_HOME)/include" -O2 -fPIC
-mmacosx-version-min=10.7 -fvisibility=hidden -I/usr/local/include
-I/usr/local/opt/openssl/include
Mac-x86_64_LINKFLAGS := -dynamiclib -L/usr/local/lib
Mac-x86_64_LIBNAME := libcommons-crypto.jnilib
Mac-x86_64_COMMONS_CRYPTO_FLAGS :=
@@ -199,8 +199,8 @@ Mac-x86_64_COMMONS_CRYPTO_FLAGS :=
FreeBSD-x86_64_CC := $(CROSS_PREFIX)gcc
FreeBSD-x86_64_CXX := $(CROSS_PREFIX)g++
FreeBSD-x86_64_STRIP := $(CROSS_PREFIX)strip
-FreeBSD-x86_64_CFLAGS := -I$(JAVA_HOME)/include -Ilib/inc_mac -O2 -fPIC
-fvisibility=hidden
-FreeBSD-x86_64_CXXFLAGS := -I$(JAVA_HOME)/include -Ilib/inc_mac -O2 -fPIC
-fvisibility=hidden
+FreeBSD-x86_64_CFLAGS := -I"$(JAVA_HOME)/include" -Ilib/inc_mac -O2
-fPIC -fvisibility=hidden
+FreeBSD-x86_64_CXXFLAGS := -I"$(JAVA_HOME)/include" -Ilib/inc_mac -O2
-fPIC -fvisibility=hidden
FreeBSD-x86_64_LINKFLAGS := -shared -static-libgcc
FreeBSD-x86_64_LIBNAME := libcommons-crypto.so
FreeBSD-x86_64_COMMONS_CRYPTO_FLAGS :=
