[commons-math] 05/05: MATH-1541: Loop early exit.

[erans]

This is an automated email from the ASF dual-hosted git repository.

erans pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-math.git

commit bfa5b60eff89ef75fabd5fbd53e61c56b4b65566
Author: XenoAmess <xenoam...@gmail.com>
AuthorDate: Sun Jun 7 17:53:14 2020 +0800

    MATH-1541: Loop early exit.
    
    Closes #147.
---
 src/main/java/org/apache/commons/math4/dfp/Dfp.java                    | 1 +
 .../commons/math4/optim/BaseMultiStartMultivariateOptimizer.java       | 1 +
 .../org/apache/commons/math4/stat/regression/SimpleRegression.java     | 3 ++-
 3 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/main/java/org/apache/commons/math4/dfp/Dfp.java 
b/src/main/java/org/apache/commons/math4/dfp/Dfp.java
index de1d4a0..841ec2f 100644
--- a/src/main/java/org/apache/commons/math4/dfp/Dfp.java
+++ b/src/main/java/org/apache/commons/math4/dfp/Dfp.java
@@ -1830,6 +1830,7 @@ public class Dfp implements RealFieldElement<Dfp> {
                 for (int i = mant.length - 1; i >= 0; i--) {
                     if (divisor.mant[i] > remainder[i]) {
                         trialgood = true;
+                        break;
                     }
                     if (divisor.mant[i] < remainder[i]) {
                         break;
diff --git 
a/src/main/java/org/apache/commons/math4/optim/BaseMultiStartMultivariateOptimizer.java
 
b/src/main/java/org/apache/commons/math4/optim/BaseMultiStartMultivariateOptimizer.java
index 937ff50..f411a18 100644
--- 
a/src/main/java/org/apache/commons/math4/optim/BaseMultiStartMultivariateOptimizer.java
+++ 
b/src/main/java/org/apache/commons/math4/optim/BaseMultiStartMultivariateOptimizer.java
@@ -190,6 +190,7 @@ public abstract class 
BaseMultiStartMultivariateOptimizer<PAIR>
                             if ((min != null && s[k] < min[k]) || (max != null 
&& s[k] > max[k])) {
                                 // reject the vector
                                 s = null;
+                                break;
                             }
                         }
                     }
diff --git 
a/src/main/java/org/apache/commons/math4/stat/regression/SimpleRegression.java 
b/src/main/java/org/apache/commons/math4/stat/regression/SimpleRegression.java
index 7fc823d..a002f9c 100644
--- 
a/src/main/java/org/apache/commons/math4/stat/regression/SimpleRegression.java
+++ 
b/src/main/java/org/apache/commons/math4/stat/regression/SimpleRegression.java
@@ -300,10 +300,11 @@ public class SimpleRegression implements Serializable, 
UpdatingMultipleLinearReg
                   (x == null) ? 0 : x.length,
                   (y == null) ? 0 : y.length);
         }
-        boolean obsOk=true;
+        boolean obsOk = true;
         for( int i = 0 ; i < x.length; i++){
             if( x[i] == null || x[i].length == 0 ){
                 obsOk = false;
+                break;
             }
         }
         if( !obsOk ){