This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-bcel.git


The following commit(s) were added to refs/heads/master by this push:
     new f1b16c3  Better local var names.
f1b16c3 is described below

commit f1b16c36f6c1bd1ef6e27b227c5fdf7479107a0f
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Wed Jun 3 21:34:35 2020 -0400

    Better local var names.
---
 .../bcel/generic/JdkGenericDumpTestCase.java       | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/src/test/java/org/apache/bcel/generic/JdkGenericDumpTestCase.java 
b/src/test/java/org/apache/bcel/generic/JdkGenericDumpTestCase.java
index 291bc1e..15fcf91 100644
--- a/src/test/java/org/apache/bcel/generic/JdkGenericDumpTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/JdkGenericDumpTestCase.java
@@ -90,9 +90,9 @@ public class JdkGenericDumpTestCase {
             final Path name = path.getFileName();
             if (name != null && matcher.matches(name)) {
                 try (final InputStream inputStream = 
Files.newInputStream(path)) {
-                    final ClassParser parser = new ClassParser(inputStream, 
name.toAbsolutePath().toString());
-                    final JavaClass jc = parser.parse();
-                    Assert.assertNotNull(jc);
+                    final ClassParser classParser = new 
ClassParser(inputStream, name.toAbsolutePath().toString());
+                    final JavaClass javaClass = classParser.parse();
+                    Assert.assertNotNull(javaClass);
                 }
 
             }
@@ -204,23 +204,23 @@ public class JdkGenericDumpTestCase {
         this.javaHome = javaHome;
     }
 
-    private void compare(final String name, final Method m) {
+    private void compare(final String name, final Method method) {
         // System.out.println("Method: " + m);
-        final Code code = m.getCode();
+        final Code code = method.getCode();
         if (code == null) {
             return; // e.g. abstract method
         }
         final byte[] src = code.getCode();
-        final InstructionList il = new InstructionList(src);
-        final byte[] out = il.getByteCode();
+        final InstructionList instructionList = new InstructionList(src);
+        final byte[] out = instructionList.getByteCode();
         if (src.length == out.length) {
-            assertArrayEquals(name + ": " + m.toString(), src, out);
+            assertArrayEquals(name + ": " + method.toString(), src, out);
         } else {
-            System.out.println(name + ": " + m.toString() + " " + src.length + 
" " + out.length);
+            System.out.println(name + ": " + method.toString() + " " + 
src.length + " " + out.length);
             System.out.println(bytesToHex(src));
             System.out.println(bytesToHex(out));
-            for (final InstructionHandle ih : il) {
-                System.out.println(ih.toString(false));
+            for (final InstructionHandle instructionHandle : instructionList) {
+                System.out.println(instructionHandle.toString(false));
             }
             fail("Array comparison failure");
         }

Reply via email to