[commons-bcel] 02/04: Use final.

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-bcel.git

commit 62f3cc347f8cfffa50be527bd67e35d5de5672a0
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Mon Jun 1 19:06:44 2020 -0400

    Use final.
---
 src/main/java/org/apache/bcel/generic/MethodGen.java                | 6 +++---
 src/test/java/org/apache/bcel/classfile/CodeExceptionTestCase.java  | 1 +
 src/test/java/org/apache/bcel/classfile/LocalVariableTestCase.java  | 1 +
 src/test/java/org/apache/bcel/generic/MethodGenTestCase.java        | 4 ++--
 src/test/java/org/apache/bcel/util/Class2HTMLTestCase.java          | 1 +
 .../org/apache/bcel/verifier/statics/Pass2VerifierTestCase.java     | 1 +
 .../bcel/verifier/structurals/UninitializedObjectTypeTestCase.java  | 1 +
 7 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/src/main/java/org/apache/bcel/generic/MethodGen.java 
b/src/main/java/org/apache/bcel/generic/MethodGen.java
index 67a1766..915a23c 100644
--- a/src/main/java/org/apache/bcel/generic/MethodGen.java
+++ b/src/main/java/org/apache/bcel/generic/MethodGen.java
@@ -654,7 +654,7 @@ public class MethodGen extends FieldGenOrMethodGen {
      * using BCEL version 6.5.0 or later that contains fix for BCEL-329.
      * @since 6.5.0
      */
-    public void removeRuntimeAttributes(Attribute[] attrs) {
+    public void removeRuntimeAttributes(final Attribute[] attrs) {
         for (final Attribute attr : attrs) {
             removeAttribute(attr);
         }
@@ -720,8 +720,8 @@ public class MethodGen extends FieldGenOrMethodGen {
                     max_stack, max_locals, byte_code, c_exc, code_attrs, 
_cp.getConstantPool());
             addAttribute(code);
         }
-        Attribute[] annotations = addRuntimeAnnotationsAsAttribute(_cp);
-        Attribute[] parameterAnnotations = 
addRuntimeParameterAnnotationsAsAttribute(_cp);
+        final Attribute[] annotations = addRuntimeAnnotationsAsAttribute(_cp);
+        final Attribute[] parameterAnnotations = 
addRuntimeParameterAnnotationsAsAttribute(_cp);
         ExceptionTable et = null;
         if (throws_vec.size() > 0) {
             addAttribute(et = getExceptionTable(_cp));
diff --git a/src/test/java/org/apache/bcel/classfile/CodeExceptionTestCase.java 
b/src/test/java/org/apache/bcel/classfile/CodeExceptionTestCase.java
index 141cc06..4600897 100644
--- a/src/test/java/org/apache/bcel/classfile/CodeExceptionTestCase.java
+++ b/src/test/java/org/apache/bcel/classfile/CodeExceptionTestCase.java
@@ -27,6 +27,7 @@ public class CodeExceptionTestCase {
     @Test
     public void testReferenceToConstant() {
         @SuppressWarnings("unused")
+        final
         short referenceToConstant = CodeException.AALOAD;
     }
 }
diff --git a/src/test/java/org/apache/bcel/classfile/LocalVariableTestCase.java 
b/src/test/java/org/apache/bcel/classfile/LocalVariableTestCase.java
index ac03a44..5a8e1eb 100644
--- a/src/test/java/org/apache/bcel/classfile/LocalVariableTestCase.java
+++ b/src/test/java/org/apache/bcel/classfile/LocalVariableTestCase.java
@@ -27,6 +27,7 @@ public class LocalVariableTestCase {
     @Test
     public void testReferenceToConstant() {
         @SuppressWarnings("unused")
+        final
         short referenceToConstant = LocalVariable.AALOAD;
     }
 }
diff --git a/src/test/java/org/apache/bcel/generic/MethodGenTestCase.java 
b/src/test/java/org/apache/bcel/generic/MethodGenTestCase.java
index c116ff7..733106d 100644
--- a/src/test/java/org/apache/bcel/generic/MethodGenTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/MethodGenTestCase.java
@@ -132,8 +132,8 @@ public class MethodGenTestCase {
 
     private void testInvalidNullMethodBody(final String className) throws 
ClassNotFoundException {
         final JavaClass jc = Repository.lookupClass(className);
-        ClassGen classGen = new ClassGen(jc);
-        for (Method method : jc.getMethods()) {
+        final ClassGen classGen = new ClassGen(jc);
+        for (final Method method : jc.getMethods()) {
             new MethodGen(method, jc.getClassName(), 
classGen.getConstantPool());
         }
     }
diff --git a/src/test/java/org/apache/bcel/util/Class2HTMLTestCase.java 
b/src/test/java/org/apache/bcel/util/Class2HTMLTestCase.java
index 8377317..c6731fc 100644
--- a/src/test/java/org/apache/bcel/util/Class2HTMLTestCase.java
+++ b/src/test/java/org/apache/bcel/util/Class2HTMLTestCase.java
@@ -48,6 +48,7 @@ public class Class2HTMLTestCase extends TestCase {
     @Test
     public void testReferenceToConstant() {
         @SuppressWarnings("unused")
+        final
         short referenceToConstant = Class2HTML.AALOAD;
     }
 
diff --git 
a/src/test/java/org/apache/bcel/verifier/statics/Pass2VerifierTestCase.java 
b/src/test/java/org/apache/bcel/verifier/statics/Pass2VerifierTestCase.java
index e336a73..f681c1e 100644
--- a/src/test/java/org/apache/bcel/verifier/statics/Pass2VerifierTestCase.java
+++ b/src/test/java/org/apache/bcel/verifier/statics/Pass2VerifierTestCase.java
@@ -27,6 +27,7 @@ public class Pass2VerifierTestCase {
     @Test
     public void testReferenceToConstant() {
         @SuppressWarnings("unused")
+        final
         short referenceToConstant = Pass2Verifier.AALOAD;
     }
 }
diff --git 
a/src/test/java/org/apache/bcel/verifier/structurals/UninitializedObjectTypeTestCase.java
 
b/src/test/java/org/apache/bcel/verifier/structurals/UninitializedObjectTypeTestCase.java
index 43028ca..e63fe48 100644
--- 
a/src/test/java/org/apache/bcel/verifier/structurals/UninitializedObjectTypeTestCase.java
+++ 
b/src/test/java/org/apache/bcel/verifier/structurals/UninitializedObjectTypeTestCase.java
@@ -27,6 +27,7 @@ public class UninitializedObjectTypeTestCase {
     @Test
     public void testReferenceToConstant() {
         @SuppressWarnings("unused")
+        final
         short referenceToConstant = UninitializedObjectType.AALOAD;
     }
 }