[commons-numbers] 02/04: Add test for signum to fraction constructor tests

[aherbert]

This is an automated email from the ASF dual-hosted git repository.

aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git

commit 1dad4a176279a608a655d8c4473463139f833c67
Author: aherbert <aherb...@apache.org>
AuthorDate: Wed Apr 8 12:11:12 2020 +0100

    Add test for signum to fraction constructor tests
---
 .../java/org/apache/commons/numbers/fraction/BigFractionTest.java     | 3 +++
 .../java/org/apache/commons/numbers/fraction/CommonTestCases.java     | 1 +
 .../test/java/org/apache/commons/numbers/fraction/FractionTest.java   | 4 ++++
 3 files changed, 8 insertions(+)

diff --git 
a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/BigFractionTest.java
 
b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/BigFractionTest.java
index a24a801..e3a611b 100644
--- 
a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/BigFractionTest.java
+++ 
b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/BigFractionTest.java
@@ -31,6 +31,9 @@ public class BigFractionTest {
     private static void assertFraction(long expectedNumerator, long 
expectedDenominator, BigFraction actual) {
         Assertions.assertEquals(BigInteger.valueOf(expectedNumerator), 
actual.getNumerator());
         Assertions.assertEquals(BigInteger.valueOf(expectedDenominator), 
actual.getDenominator());
+        Assertions.assertEquals(
+            Long.signum(expectedNumerator) * Long.signum(expectedDenominator),
+            actual.signum());
     }
 
     private static void assertFraction(BigInteger expectedNumerator, 
BigInteger expectedDenominator, BigFraction actual) {
diff --git 
a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/CommonTestCases.java
 
b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/CommonTestCases.java
index 0938bcf..a421421 100644
--- 
a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/CommonTestCases.java
+++ 
b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/CommonTestCases.java
@@ -104,6 +104,7 @@ final class CommonTestCases {
         testCases.add(new UnaryOperatorTestCase(1, -2, 1, -2));
         testCases.add(new UnaryOperatorTestCase(-2, 4, -1, 2));
         testCases.add(new UnaryOperatorTestCase(2, -4, 1, -2));
+        testCases.add(new UnaryOperatorTestCase(-2, -4, -1, -2));
 
         testCases.add(new UnaryOperatorTestCase(2, Integer.MIN_VALUE, 1, 
Integer.MIN_VALUE / 2));
         testCases.add(new UnaryOperatorTestCase(Integer.MIN_VALUE, -2, 
-Integer.MIN_VALUE / 2, -1));
diff --git 
a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/FractionTest.java
 
b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/FractionTest.java
index cf6e747..0888a75 100644
--- 
a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/FractionTest.java
+++ 
b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/FractionTest.java
@@ -30,6 +30,9 @@ public class FractionTest {
     private void assertFraction(int expectedNumerator, int 
expectedDenominator, Fraction actual) {
         Assertions.assertEquals(expectedNumerator, actual.getNumerator());
         Assertions.assertEquals(expectedDenominator, actual.getDenominator());
+        Assertions.assertEquals(
+            Integer.signum(expectedNumerator) * 
Integer.signum(expectedDenominator),
+            actual.signum());
     }
 
     @Test
@@ -45,6 +48,7 @@ public class FractionTest {
         // Special cases.
         assertFraction(Integer.MIN_VALUE, -1, Fraction.of(Integer.MIN_VALUE, 
-1));
         assertFraction(1, Integer.MIN_VALUE, Fraction.of(1, 
Integer.MIN_VALUE));
+        assertFraction(-1, Integer.MIN_VALUE, Fraction.of(-1, 
Integer.MIN_VALUE));
         assertFraction(1, 1, Fraction.of(Integer.MIN_VALUE, 
Integer.MIN_VALUE));
     }