This is an automated email from the ASF dual-hosted git repository.

erans pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git

commit 74a4d3353600d3099e15ba26257344d7c5296f87
Author: Gilles Sadowski <gil...@harfang.homelinux.org>
AuthorDate: Wed Nov 6 16:08:28 2019 +0100

    Use "final".
---
 .../java/org/apache/commons/numbers/fraction/Fraction.java     | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git 
a/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/Fraction.java
 
b/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/Fraction.java
index 5568bff..1f99079 100644
--- 
a/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/Fraction.java
+++ 
b/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/Fraction.java
@@ -116,7 +116,7 @@ public class Fraction
                 throw new 
FractionException(FractionException.ERROR_CONVERSION, value, p2, q2);
             }
 
-            double convergent = (double)p2 / (double)q2;
+            final double convergent = (double)p2 / (double)q2;
             if (n < maxIterations &&
                 Math.abs(convergent - value) > epsilon &&
                 q2 < maxDenominator) {
@@ -280,8 +280,8 @@ public class Fraction
      */
     @Override
     public int compareTo(Fraction object) {
-        long nOd = ((long) numerator) * object.denominator;
-        long dOn = ((long) denominator) * object.numerator;
+        final long nOd = ((long) numerator) * object.denominator;
+        final long dOn = ((long) denominator) * object.numerator;
         return nOd < dOn ? -1 :
             nOd > dOn ? 1 :
             0;
@@ -541,8 +541,8 @@ public class Fraction
 
         // knuth 4.5.1
         // Make sure we don't overflow unless the result *must* overflow.
-        int d1 = ArithmeticUtils.gcd(numerator, fraction.denominator);
-        int d2 = ArithmeticUtils.gcd(fraction.numerator, denominator);
+        final int d1 = ArithmeticUtils.gcd(numerator, fraction.denominator);
+        final int d2 = ArithmeticUtils.gcd(fraction.numerator, denominator);
         return of(Math.multiplyExact(numerator / d1, fraction.numerator / d2),
                   Math.multiplyExact(denominator / d2, fraction.denominator / 
d1));
     }

Reply via email to