This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-beanutils.git
commit c603d875db8dd09bde378aab458ae14eca8a956c Author: Gary Gregory <gardgreg...@gmail.com> AuthorDate: Mon Oct 21 09:58:57 2019 -0400 Use final. --- src/main/java/org/apache/commons/beanutils2/BeanPredicate.java | 2 +- .../java/org/apache/commons/beanutils2/BeanPredicateTestCase.java | 8 ++++---- .../java/org/apache/commons/beanutils2/bugs/Jira157TestCase.java | 2 +- .../java/org/apache/commons/beanutils2/bugs/Jira520TestCase.java | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/main/java/org/apache/commons/beanutils2/BeanPredicate.java b/src/main/java/org/apache/commons/beanutils2/BeanPredicate.java index 6be8d12..e894b5b 100644 --- a/src/main/java/org/apache/commons/beanutils2/BeanPredicate.java +++ b/src/main/java/org/apache/commons/beanutils2/BeanPredicate.java @@ -61,7 +61,7 @@ public class BeanPredicate<T> implements Predicate<T> { * @throws IllegalArgumentException when the property cannot be evaluated */ @Override - public boolean test(Object object) { + public boolean test(final Object object) { boolean evaluation = false; try { diff --git a/src/test/java/org/apache/commons/beanutils2/BeanPredicateTestCase.java b/src/test/java/org/apache/commons/beanutils2/BeanPredicateTestCase.java index 0972174..bba384f 100644 --- a/src/test/java/org/apache/commons/beanutils2/BeanPredicateTestCase.java +++ b/src/test/java/org/apache/commons/beanutils2/BeanPredicateTestCase.java @@ -32,28 +32,28 @@ public class BeanPredicateTestCase extends TestCase { } public void testEqual() { - Predicate<String> p = (s) -> s.equals("foo"); + final Predicate<String> p = (s) -> s.equals("foo"); final BeanPredicate<String> predicate = new BeanPredicate<>("stringProperty", p); assertTrue(predicate.test(new TestBean("foo"))); assertTrue(!predicate.test(new TestBean("bar"))); } public void testNotEqual() { - Predicate<String> p = (s) -> !s.equals("foo"); + final Predicate<String> p = (s) -> !s.equals("foo"); final BeanPredicate<String> predicate = new BeanPredicate<>("stringProperty", p); assertTrue(!predicate.test(new TestBean("foo"))); assertTrue(predicate.test(new TestBean("bar"))); } public void testInstanceOf() { - Predicate<String> p = (s) -> (s instanceof String); + final Predicate<String> p = (s) -> (s instanceof String); final BeanPredicate<String> predicate = new BeanPredicate<>("stringProperty", p); assertTrue(predicate.test(new TestBean("foo"))); assertTrue(predicate.test(new TestBean("bar"))); } public void testNull() { - Predicate<String> p = (s) -> s == null; + final Predicate<String> p = (s) -> s == null; final BeanPredicate<String> predicate = new BeanPredicate<>("stringProperty", p); final String nullString = null; assertTrue(predicate.test(new TestBean(nullString))); diff --git a/src/test/java/org/apache/commons/beanutils2/bugs/Jira157TestCase.java b/src/test/java/org/apache/commons/beanutils2/bugs/Jira157TestCase.java index 81875e5..f100a2a 100644 --- a/src/test/java/org/apache/commons/beanutils2/bugs/Jira157TestCase.java +++ b/src/test/java/org/apache/commons/beanutils2/bugs/Jira157TestCase.java @@ -77,7 +77,7 @@ public class Jira157TestCase extends TestCase { protected void setUp() throws Exception { super.setUp(); - BeanUtilsBean custom = new BeanUtilsBean(); + final BeanUtilsBean custom = new BeanUtilsBean(); custom.getPropertyUtils().removeBeanIntrospector(SuppressPropertiesBeanIntrospector.SUPPRESS_CLASS); BeanUtilsBean.setInstance(custom); } diff --git a/src/test/java/org/apache/commons/beanutils2/bugs/Jira520TestCase.java b/src/test/java/org/apache/commons/beanutils2/bugs/Jira520TestCase.java index a440912..e3bec4f 100644 --- a/src/test/java/org/apache/commons/beanutils2/bugs/Jira520TestCase.java +++ b/src/test/java/org/apache/commons/beanutils2/bugs/Jira520TestCase.java @@ -49,7 +49,7 @@ public class Jira520TestCase extends TestCase { final BeanUtilsBean bub = new BeanUtilsBean(); bub.getPropertyUtils().removeBeanIntrospector(SuppressPropertiesBeanIntrospector.SUPPRESS_CLASS); final AlphaBean bean = new AlphaBean(); - String result = bub.getProperty(bean, "class"); + final String result = bub.getProperty(bean, "class"); assertEquals("Class property should have been accessed", "class org.apache.commons.beanutils2.AlphaBean", result); } }