This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-vfs.git
The following commit(s) were added to refs/heads/master by this push: new 3fac2f2 Use final. 3fac2f2 is described below commit 3fac2f2e9bf64a8a3f4532e777a2c94bb2ccf53a Author: Gary Gregory <gardgreg...@gmail.com> AuthorDate: Thu Oct 17 12:10:28 2019 -0400 Use final. --- .../org/apache/commons/vfs2/example/Shell.java | 2 +- .../vfs2/example/filter/AgeFileFilterExample.java | 12 +++++------ .../example/filter/CanReadFileFilterExample.java | 20 +++++++++--------- .../example/filter/CanWriteFileFilterExample.java | 14 ++++++------- .../example/filter/DirectoryFileFilterExample.java | 8 ++++---- .../example/filter/EmptyFileFilterExample.java | 14 ++++++------- .../vfs2/example/filter/FileFileFilterExample.java | 8 ++++---- .../example/filter/HiddenFileFilterExample.java | 14 ++++++------- .../vfs2/example/filter/NameFileFilterExample.java | 8 ++++---- .../example/filter/PrefixFileFilterExample.java | 8 ++++---- .../example/filter/RegexFileFilterExample.java | 8 ++++---- .../vfs2/example/filter/SizeFileFilterExample.java | 10 ++++----- .../example/filter/SuffixFileFilterExample.java | 8 ++++---- .../example/filter/WildcardFileFilterExample.java | 8 ++++---- .../webdav4/test/Webdav4ProviderTestCase.java | 2 +- .../commons/vfs2/provider/mime/MimeFileObject.java | 2 +- .../commons/vfs2/provider/smb/SmbFileObject.java | 2 +- .../java/org/apache/commons/vfs2/FileContent.java | 6 +++--- .../apache/commons/vfs2/function/VfsConsumer.java | 4 ++-- .../commons/vfs2/provider/AbstractFileSystem.java | 2 +- .../commons/vfs2/provider/ftp/FtpClient.java | 4 ++-- .../commons/vfs2/provider/local/LocalFile.java | 4 ++-- .../vfs2/provider/local/LocalFileNameParser.java | 2 +- .../commons/vfs2/provider/ram/RamFileObject.java | 2 +- .../vfs2/provider/sftp/BytesIdentityInfo.java | 6 +++--- .../provider/sftp/SftpFileSystemConfigBuilder.java | 2 +- .../commons/vfs2/provider/tar/TarFileObject.java | 2 +- .../commons/vfs2/provider/url/UrlFileObject.java | 2 +- .../commons/vfs2/provider/zip/ZipFileObject.java | 2 +- .../commons/vfs2/util/RawMonitorInputStream.java | 2 +- .../vfs2/filter/SymbolicLinkFileFilterTest.java | 2 +- .../commons/vfs2/function/VfsConsumerTest.java | 2 +- .../vfs2/provider/AbstractFileNameTest.java | 6 +++--- .../provider/ram/test/CustomRamProviderTest.java | 2 +- .../vfs2/provider/res/test/Vfs444TestCase.java | 24 +++++++++++----------- .../commons/vfs2/provider/zip/Jira733TestCase.java | 1 + .../commons/vfs2/util/FileObjectUtilsTest.java | 4 ++-- 37 files changed, 115 insertions(+), 114 deletions(-) diff --git a/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/Shell.java b/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/Shell.java index f4b5327..f73f2ee 100644 --- a/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/Shell.java +++ b/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/Shell.java @@ -142,7 +142,7 @@ public final class Shell { final String[] schemes = mgr.getSchemes(); final List<String> virtual = new ArrayList<>(); final List<String> physical = new ArrayList<>(); - for (String scheme : schemes) { + for (final String scheme : schemes) { final Collection<Capability> caps = mgr.getProviderCapabilities(scheme); if (caps != null) { if (caps.contains(Capability.VIRTUAL) || caps.contains(Capability.COMPRESS) diff --git a/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/AgeFileFilterExample.java b/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/AgeFileFilterExample.java index b366299..6d18e72 100644 --- a/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/AgeFileFilterExample.java +++ b/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/AgeFileFilterExample.java @@ -30,16 +30,16 @@ import org.apache.commons.vfs2.filter.AgeFileFilter; // CHECKSTYLE:OFF Example code public class AgeFileFilterExample { - public static void main(String[] args) throws Exception { + public static void main(final String[] args) throws Exception { - FileSystemManager fsManager = VFS.getManager(); - FileObject dir = fsManager.toFileObject(new File(".")); + final FileSystemManager fsManager = VFS.getManager(); + final FileObject dir = fsManager.toFileObject(new File(".")); // We are interested in files older than one day - long cutoff = System.currentTimeMillis() - (24 * 60 * 60 * 1000); - AgeFileFilter filter = new AgeFileFilter(cutoff); + final long cutoff = System.currentTimeMillis() - (24 * 60 * 60 * 1000); + final AgeFileFilter filter = new AgeFileFilter(cutoff); - FileObject[] files = dir.findFiles(new FileFilterSelector(filter)); + final FileObject[] files = dir.findFiles(new FileFilterSelector(filter)); for (int i = 0; i < files.length; i++) { System.out.println(files[i]); } diff --git a/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/CanReadFileFilterExample.java b/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/CanReadFileFilterExample.java index 1cf8c63..7c2a0e3 100644 --- a/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/CanReadFileFilterExample.java +++ b/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/CanReadFileFilterExample.java @@ -30,15 +30,15 @@ import org.apache.commons.vfs2.filter.CanReadFileFilter; // CHECKSTYLE:OFF Example code public class CanReadFileFilterExample { - public static void main(String[] args) throws Exception { + public static void main(final String[] args) throws Exception { // Example, showing how to print out a list of the current directory's // readable files: { System.out.println("---CAN_READ---"); - FileSystemManager fsManager = VFS.getManager(); - FileObject dir = fsManager.toFileObject(new File(".")); - FileObject[] files = dir.findFiles(new FileFilterSelector(CanReadFileFilter.CAN_READ)); + final FileSystemManager fsManager = VFS.getManager(); + final FileObject dir = fsManager.toFileObject(new File(".")); + final FileObject[] files = dir.findFiles(new FileFilterSelector(CanReadFileFilter.CAN_READ)); for (int i = 0; i < files.length; i++) { System.out.println(files[i]); } @@ -48,9 +48,9 @@ public class CanReadFileFilterExample { // un-readable files: { System.out.println("---CANNOT_READ---"); - FileSystemManager fsManager = VFS.getManager(); - FileObject dir = fsManager.toFileObject(new File(".")); - FileObject[] files = dir + final FileSystemManager fsManager = VFS.getManager(); + final FileObject dir = fsManager.toFileObject(new File(".")); + final FileObject[] files = dir .findFiles(new FileFilterSelector(CanReadFileFilter.CANNOT_READ)); for (int i = 0; i < files.length; i++) { System.out.println(files[i]); @@ -61,9 +61,9 @@ public class CanReadFileFilterExample { // read-only files: { System.out.println("---READ_ONLY---"); - FileSystemManager fsManager = VFS.getManager(); - FileObject dir = fsManager.toFileObject(new File(".")); - FileObject[] files = dir.findFiles(new FileFilterSelector(CanReadFileFilter.READ_ONLY)); + final FileSystemManager fsManager = VFS.getManager(); + final FileObject dir = fsManager.toFileObject(new File(".")); + final FileObject[] files = dir.findFiles(new FileFilterSelector(CanReadFileFilter.READ_ONLY)); for (int i = 0; i < files.length; i++) { System.out.println(files[i]); } diff --git a/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/CanWriteFileFilterExample.java b/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/CanWriteFileFilterExample.java index 0c58886..3de2bc7 100644 --- a/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/CanWriteFileFilterExample.java +++ b/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/CanWriteFileFilterExample.java @@ -30,15 +30,15 @@ import org.apache.commons.vfs2.filter.CanWriteFileFilter; // CHECKSTYLE:OFF Example code public class CanWriteFileFilterExample { - public static void main(String[] args) throws Exception { + public static void main(final String[] args) throws Exception { // Example, showing how to print out a list of the current directory's // writable files: { System.out.println("---CAN_WRITE---"); - FileSystemManager fsManager = VFS.getManager(); - FileObject dir = fsManager.toFileObject(new File(".")); - FileObject[] files = dir + final FileSystemManager fsManager = VFS.getManager(); + final FileObject dir = fsManager.toFileObject(new File(".")); + final FileObject[] files = dir .findFiles(new FileFilterSelector(CanWriteFileFilter.CAN_WRITE)); for (int i = 0; i < files.length; i++) { System.out.println(files[i]); @@ -49,9 +49,9 @@ public class CanWriteFileFilterExample { // un-writable files: { System.out.println("---CANNOT_WRITE---"); - FileSystemManager fsManager = VFS.getManager(); - FileObject dir = fsManager.toFileObject(new File(".")); - FileObject[] files = dir.findFiles(new FileFilterSelector( + final FileSystemManager fsManager = VFS.getManager(); + final FileObject dir = fsManager.toFileObject(new File(".")); + final FileObject[] files = dir.findFiles(new FileFilterSelector( CanWriteFileFilter.CANNOT_WRITE)); for (int i = 0; i < files.length; i++) { System.out.println(files[i]); diff --git a/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/DirectoryFileFilterExample.java b/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/DirectoryFileFilterExample.java index 51657ce..890774f 100644 --- a/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/DirectoryFileFilterExample.java +++ b/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/DirectoryFileFilterExample.java @@ -30,13 +30,13 @@ import org.apache.commons.vfs2.filter.DirectoryFileFilter; // CHECKSTYLE:OFF Example code public class DirectoryFileFilterExample { - public static void main(String[] args) throws Exception { + public static void main(final String[] args) throws Exception { // Example, how to print out a list of the current directory's // subdirectories - FileSystemManager fsManager = VFS.getManager(); - FileObject dir = fsManager.toFileObject(new File(".")); - FileObject[] files = dir.findFiles(new FileFilterSelector(DirectoryFileFilter.DIRECTORY)); + final FileSystemManager fsManager = VFS.getManager(); + final FileObject dir = fsManager.toFileObject(new File(".")); + final FileObject[] files = dir.findFiles(new FileFilterSelector(DirectoryFileFilter.DIRECTORY)); for (int i = 0; i < files.length; i++) { System.out.println(files[i]); } diff --git a/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/EmptyFileFilterExample.java b/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/EmptyFileFilterExample.java index da5f155..43536c4 100644 --- a/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/EmptyFileFilterExample.java +++ b/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/EmptyFileFilterExample.java @@ -30,15 +30,15 @@ import org.apache.commons.vfs2.filter.EmptyFileFilter; // CHECKSTYLE:OFF Example code public class EmptyFileFilterExample { - public static void main(String[] args) throws Exception { + public static void main(final String[] args) throws Exception { // Example, showing how to print out a list of the current directory's // empty files/directories { System.out.println("---EMPTY---"); - FileSystemManager fsManager = VFS.getManager(); - FileObject dir = fsManager.toFileObject(new File(".")); - FileObject[] files = dir.findFiles(new FileFilterSelector(EmptyFileFilter.EMPTY)); + final FileSystemManager fsManager = VFS.getManager(); + final FileObject dir = fsManager.toFileObject(new File(".")); + final FileObject[] files = dir.findFiles(new FileFilterSelector(EmptyFileFilter.EMPTY)); for (int i = 0; i < files.length; i++) { System.out.println(files[i]); } @@ -48,9 +48,9 @@ public class EmptyFileFilterExample { // non-empty files/directories { System.out.println("---NOT_EMPTY---"); - FileSystemManager fsManager = VFS.getManager(); - FileObject dir = fsManager.toFileObject(new File(".")); - FileObject[] files = dir.findFiles(new FileFilterSelector(EmptyFileFilter.NOT_EMPTY)); + final FileSystemManager fsManager = VFS.getManager(); + final FileObject dir = fsManager.toFileObject(new File(".")); + final FileObject[] files = dir.findFiles(new FileFilterSelector(EmptyFileFilter.NOT_EMPTY)); for (int i = 0; i < files.length; i++) { System.out.println(files[i]); } diff --git a/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/FileFileFilterExample.java b/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/FileFileFilterExample.java index fb792c3..2eeb0c3 100644 --- a/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/FileFileFilterExample.java +++ b/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/FileFileFilterExample.java @@ -30,13 +30,13 @@ import org.apache.commons.vfs2.filter.FileFileFilter; // CHECKSTYLE:OFF Example code public class FileFileFilterExample { - public static void main(String[] args) throws Exception { + public static void main(final String[] args) throws Exception { // Example, how to print out a list of the real files within the current // directory - FileSystemManager fsManager = VFS.getManager(); - FileObject dir = fsManager.toFileObject(new File(".")); - FileObject[] files = dir.findFiles(new FileFilterSelector(FileFileFilter.FILE)); + final FileSystemManager fsManager = VFS.getManager(); + final FileObject dir = fsManager.toFileObject(new File(".")); + final FileObject[] files = dir.findFiles(new FileFilterSelector(FileFileFilter.FILE)); for (int i = 0; i < files.length; i++) { System.out.println(files[i]); } diff --git a/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/HiddenFileFilterExample.java b/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/HiddenFileFilterExample.java index 507f524..13beac4 100644 --- a/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/HiddenFileFilterExample.java +++ b/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/HiddenFileFilterExample.java @@ -30,15 +30,15 @@ import org.apache.commons.vfs2.filter.HiddenFileFilter; // CHECKSTYLE:OFF Example code public class HiddenFileFilterExample { - public static void main(String[] args) throws Exception { + public static void main(final String[] args) throws Exception { // Example, showing how to print out a list of the current directory's // hidden files { System.out.println("---HIDDEN---"); - FileSystemManager fsManager = VFS.getManager(); - FileObject dir = fsManager.toFileObject(new File(".")); - FileObject[] files = dir.findFiles(new FileFilterSelector(HiddenFileFilter.HIDDEN)); + final FileSystemManager fsManager = VFS.getManager(); + final FileObject dir = fsManager.toFileObject(new File(".")); + final FileObject[] files = dir.findFiles(new FileFilterSelector(HiddenFileFilter.HIDDEN)); for (int i = 0; i < files.length; i++) { System.out.println(files[i]); } @@ -48,9 +48,9 @@ public class HiddenFileFilterExample { // visible (i.e. not hidden) files { System.out.println("---VISIBLE---"); - FileSystemManager fsManager = VFS.getManager(); - FileObject dir = fsManager.toFileObject(new File(".")); - FileObject[] files = dir.findFiles(new FileFilterSelector(HiddenFileFilter.VISIBLE)); + final FileSystemManager fsManager = VFS.getManager(); + final FileObject dir = fsManager.toFileObject(new File(".")); + final FileObject[] files = dir.findFiles(new FileFilterSelector(HiddenFileFilter.VISIBLE)); for (int i = 0; i < files.length; i++) { System.out.println(files[i]); } diff --git a/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/NameFileFilterExample.java b/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/NameFileFilterExample.java index 010e531..8869a28 100644 --- a/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/NameFileFilterExample.java +++ b/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/NameFileFilterExample.java @@ -30,13 +30,13 @@ import org.apache.commons.vfs2.filter.NameFileFilter; // CHECKSTYLE:OFF Example code public class NameFileFilterExample { - public static void main(String[] args) throws Exception { + public static void main(final String[] args) throws Exception { // Example, to print all files and directories in the current directory // whose name is Test - FileSystemManager fsManager = VFS.getManager(); - FileObject dir = fsManager.toFileObject(new File(".")); - FileObject[] files = dir.findFiles(new FileFilterSelector(new NameFileFilter("Test"))); + final FileSystemManager fsManager = VFS.getManager(); + final FileObject dir = fsManager.toFileObject(new File(".")); + final FileObject[] files = dir.findFiles(new FileFilterSelector(new NameFileFilter("Test"))); for (int i = 0; i < files.length; i++) { System.out.println(files[i]); } diff --git a/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/PrefixFileFilterExample.java b/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/PrefixFileFilterExample.java index 1247a0c..cc3f9ad 100644 --- a/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/PrefixFileFilterExample.java +++ b/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/PrefixFileFilterExample.java @@ -30,13 +30,13 @@ import org.apache.commons.vfs2.filter.PrefixFileFilter; // CHECKSTYLE:OFF Example code public class PrefixFileFilterExample { - public static void main(String[] args) throws Exception { + public static void main(final String[] args) throws Exception { // Example, to print all files and directories in the current directory // whose name starts with a <code>.</code> - FileSystemManager fsManager = VFS.getManager(); - FileObject dir = fsManager.toFileObject(new File(".")); - FileObject[] files = dir.findFiles(new FileFilterSelector(new PrefixFileFilter("."))); + final FileSystemManager fsManager = VFS.getManager(); + final FileObject dir = fsManager.toFileObject(new File(".")); + final FileObject[] files = dir.findFiles(new FileFilterSelector(new PrefixFileFilter("."))); for (int i = 0; i < files.length; i++) { System.out.println(files[i]); } diff --git a/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/RegexFileFilterExample.java b/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/RegexFileFilterExample.java index 1e5550a..7bcbc16 100644 --- a/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/RegexFileFilterExample.java +++ b/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/RegexFileFilterExample.java @@ -30,13 +30,13 @@ import org.apache.commons.vfs2.filter.RegexFileFilter; // CHECKSTYLE:OFF Example code public class RegexFileFilterExample { - public static void main(String[] args) throws Exception { + public static void main(final String[] args) throws Exception { // Example, to retrieve and print all java files where the name matched // the regular expression in the current directory - FileSystemManager fsManager = VFS.getManager(); - FileObject dir = fsManager.toFileObject(new File(".")); - FileObject[] files = dir.findFiles(new FileFilterSelector(new RegexFileFilter( + final FileSystemManager fsManager = VFS.getManager(); + final FileObject dir = fsManager.toFileObject(new File(".")); + final FileObject[] files = dir.findFiles(new FileFilterSelector(new RegexFileFilter( "ˆ.*[tT]est(-\\d+)?\\.java$"))); for (int i = 0; i < files.length; i++) { System.out.println(files[i]); diff --git a/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/SizeFileFilterExample.java b/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/SizeFileFilterExample.java index 7e10314..599f9a1 100644 --- a/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/SizeFileFilterExample.java +++ b/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/SizeFileFilterExample.java @@ -30,14 +30,14 @@ import org.apache.commons.vfs2.filter.SizeFileFilter; // CHECKSTYLE:OFF Example code public class SizeFileFilterExample { - public static void main(String[] args) throws Exception { + public static void main(final String[] args) throws Exception { // Example, to print all files and directories in the current directory // whose size is greater than 1 MB - FileSystemManager fsManager = VFS.getManager(); - FileObject dir = fsManager.toFileObject(new File(".")); - SizeFileFilter filter = new SizeFileFilter(1024 * 1024); - FileObject[] files = dir.findFiles(new FileFilterSelector(filter)); + final FileSystemManager fsManager = VFS.getManager(); + final FileObject dir = fsManager.toFileObject(new File(".")); + final SizeFileFilter filter = new SizeFileFilter(1024 * 1024); + final FileObject[] files = dir.findFiles(new FileFilterSelector(filter)); for (int i = 0; i < files.length; i++) { System.out.println(files[i]); } diff --git a/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/SuffixFileFilterExample.java b/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/SuffixFileFilterExample.java index 34f07ad..d9f2041 100644 --- a/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/SuffixFileFilterExample.java +++ b/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/SuffixFileFilterExample.java @@ -30,13 +30,13 @@ import org.apache.commons.vfs2.filter.SuffixFileFilter; // CHECKSTYLE:OFF Example code public class SuffixFileFilterExample { - public static void main(String[] args) throws Exception { + public static void main(final String[] args) throws Exception { // Example, to retrieve and print all *.java files in the current // directory - FileSystemManager fsManager = VFS.getManager(); - FileObject dir = fsManager.toFileObject(new File(".")); - FileObject[] files = dir.findFiles(new FileFilterSelector(new SuffixFileFilter(".java"))); + final FileSystemManager fsManager = VFS.getManager(); + final FileObject dir = fsManager.toFileObject(new File(".")); + final FileObject[] files = dir.findFiles(new FileFilterSelector(new SuffixFileFilter(".java"))); for (int i = 0; i < files.length; i++) { System.out.println(files[i]); } diff --git a/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/WildcardFileFilterExample.java b/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/WildcardFileFilterExample.java index c150f3d..b5ab33b 100644 --- a/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/WildcardFileFilterExample.java +++ b/commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/example/filter/WildcardFileFilterExample.java @@ -30,13 +30,13 @@ import org.apache.commons.vfs2.filter.WildcardFileFilter; // CHECKSTYLE:OFF Example code public class WildcardFileFilterExample { - public static void main(String[] args) throws Exception { + public static void main(final String[] args) throws Exception { // Example, to retrieve and print all java files that have the // expression test in the name in the current directory - FileSystemManager fsManager = VFS.getManager(); - FileObject dir = fsManager.toFileObject(new File(".")); - FileObject[] files = dir.findFiles(new FileFilterSelector(new WildcardFileFilter( + final FileSystemManager fsManager = VFS.getManager(); + final FileObject dir = fsManager.toFileObject(new File(".")); + final FileObject[] files = dir.findFiles(new FileFilterSelector(new WildcardFileFilter( "*test*.java"))); for (int i = 0; i < files.length; i++) { System.out.println(files[i]); diff --git a/commons-vfs2-jackrabbit2/src/test/java/org/apache/commons/vfs2/provider/webdav4/test/Webdav4ProviderTestCase.java b/commons-vfs2-jackrabbit2/src/test/java/org/apache/commons/vfs2/provider/webdav4/test/Webdav4ProviderTestCase.java index 4871255..739e845 100644 --- a/commons-vfs2-jackrabbit2/src/test/java/org/apache/commons/vfs2/provider/webdav4/test/Webdav4ProviderTestCase.java +++ b/commons-vfs2-jackrabbit2/src/test/java/org/apache/commons/vfs2/provider/webdav4/test/Webdav4ProviderTestCase.java @@ -249,7 +249,7 @@ public class Webdav4ProviderTestCase extends AbstractProviderTestConfig { manager.addProvider("webdav4", new Webdav4FileProvider()); } super.setUp(); - } catch (Exception e) { + } catch (final Exception e) { e.printStackTrace(); } } diff --git a/commons-vfs2-sandbox/src/main/java/org/apache/commons/vfs2/provider/mime/MimeFileObject.java b/commons-vfs2-sandbox/src/main/java/org/apache/commons/vfs2/provider/mime/MimeFileObject.java index 64314b7..cc72b20 100644 --- a/commons-vfs2-sandbox/src/main/java/org/apache/commons/vfs2/provider/mime/MimeFileObject.java +++ b/commons-vfs2-sandbox/src/main/java/org/apache/commons/vfs2/provider/mime/MimeFileObject.java @@ -204,7 +204,7 @@ public class MimeFileObject extends AbstractFileObject<MimeFileSystem> implement * Creates an input stream to read the file content from. */ @Override - protected InputStream doGetInputStream(int bufferSize) throws Exception { + protected InputStream doGetInputStream(final int bufferSize) throws Exception { if (isMultipart()) { // deliver the preamble as the only content diff --git a/commons-vfs2-sandbox/src/main/java/org/apache/commons/vfs2/provider/smb/SmbFileObject.java b/commons-vfs2-sandbox/src/main/java/org/apache/commons/vfs2/provider/smb/SmbFileObject.java index 88d488f..6634914 100644 --- a/commons-vfs2-sandbox/src/main/java/org/apache/commons/vfs2/provider/smb/SmbFileObject.java +++ b/commons-vfs2-sandbox/src/main/java/org/apache/commons/vfs2/provider/smb/SmbFileObject.java @@ -187,7 +187,7 @@ public class SmbFileObject extends AbstractFileObject<SmbFileSystem> { * Creates an input stream to read the file content from. */ @Override - protected InputStream doGetInputStream(int bufferSize) throws Exception { + protected InputStream doGetInputStream(final int bufferSize) throws Exception { try { return new SmbFileInputStream(file); } catch (final SmbException e) { diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/FileContent.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/FileContent.java index 3a3f719..0162f3c 100644 --- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/FileContent.java +++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/FileContent.java @@ -152,7 +152,7 @@ public interface FileContent extends Closeable { * opening the stream. * @since 2.4 */ - default InputStream getInputStream(int bufferSize) throws FileSystemException { + default InputStream getInputStream(final int bufferSize) throws FileSystemException { return getInputStream(); } @@ -218,7 +218,7 @@ public interface FileContent extends Closeable { * and the implementation does not support it, or on error opening the stream. * @since 2.4 */ - default OutputStream getOutputStream(boolean bAppend, int bufferSize) throws FileSystemException { + default OutputStream getOutputStream(final boolean bAppend, final int bufferSize) throws FileSystemException { return getOutputStream(bAppend); } @@ -239,7 +239,7 @@ public interface FileContent extends Closeable { * and the implementation does not support it, or on error opening the stream. * @since 2.4 */ - default OutputStream getOutputStream(int bufferSize) throws FileSystemException { + default OutputStream getOutputStream(final int bufferSize) throws FileSystemException { return getOutputStream(); } diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/function/VfsConsumer.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/function/VfsConsumer.java index 075f619..e1100e5 100644 --- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/function/VfsConsumer.java +++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/function/VfsConsumer.java @@ -49,9 +49,9 @@ public interface VfsConsumer<T> { * operation * @throws NullPointerException if {@code after} is null */ - default VfsConsumer<T> andThen(VfsConsumer<? super T> after) { + default VfsConsumer<T> andThen(final VfsConsumer<? super T> after) { Objects.requireNonNull(after); - return (T t) -> { + return (final T t) -> { accept(t); after.accept(t); }; diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/AbstractFileSystem.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/AbstractFileSystem.java index a48ea38..65dbd31 100644 --- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/AbstractFileSystem.java +++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/AbstractFileSystem.java @@ -70,7 +70,7 @@ public abstract class AbstractFileSystem extends AbstractVfsComponent implements private final Collection<Capability> caps = new HashSet<>(); - private FileObject parentLayer; + private final FileObject parentLayer; /** * Map from FileName to an ArrayList of listeners for that file. diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/ftp/FtpClient.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/ftp/FtpClient.java index 4afce34..b02f7a2 100644 --- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/ftp/FtpClient.java +++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/ftp/FtpClient.java @@ -57,14 +57,14 @@ public interface FtpClient { InputStream retrieveFileStream(String relPath) throws IOException; - default InputStream retrieveFileStream(String relPath, int bufferSize) throws IOException { + default InputStream retrieveFileStream(final String relPath, final int bufferSize) throws IOException { // Backward compatibility: no buffer size. return retrieveFileStream(relPath); } InputStream retrieveFileStream(String relPath, long restartOffset) throws IOException; - default void setBufferSize(int bufferSize) throws FileSystemException { + default void setBufferSize(final int bufferSize) throws FileSystemException { // Backward compatibility: do nothing. } diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/local/LocalFile.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/local/LocalFile.java index 9985f8c..05c9f2a 100644 --- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/local/LocalFile.java +++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/local/LocalFile.java @@ -103,7 +103,7 @@ public class LocalFile extends AbstractFileObject<LocalFileSystem> { * Creates an input stream to read the content from. */ @Override - protected InputStream doGetInputStream(int bufferSize) throws Exception { + protected InputStream doGetInputStream(final int bufferSize) throws Exception { return new FileInputStream(file); } @@ -116,7 +116,7 @@ public class LocalFile extends AbstractFileObject<LocalFileSystem> { // https://bugs.openjdk.java.net/browse/JDK-8177809 try { return Files.getLastModifiedTime(file.toPath()).toMillis(); - } catch (IOException e) { + } catch (final IOException e) { throw new FileSystemException(file.toString(), e); } } diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/local/LocalFileNameParser.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/local/LocalFileNameParser.java index 90abfeb..46fba3f 100644 --- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/local/LocalFileNameParser.java +++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/local/LocalFileNameParser.java @@ -90,7 +90,7 @@ public abstract class LocalFileNameParser extends AbstractFileNameParser { return createFileName(scheme, rootFile, path, fileType); } - private String[] getSchemes(final VfsComponentContext context, FileName base, String uri) { + private String[] getSchemes(final VfsComponentContext context, final FileName base, final String uri) { if (context == null) { return new String[] { base != null ? base.getScheme() : URI.create(uri).getScheme() }; } diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/ram/RamFileObject.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/ram/RamFileObject.java index d7a7373..cd82261 100644 --- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/ram/RamFileObject.java +++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/ram/RamFileObject.java @@ -91,7 +91,7 @@ public class RamFileObject extends AbstractFileObject<RamFileSystem> { * @see org.apache.commons.vfs2.provider.AbstractFileObject#doGetInputStream() */ @Override - protected InputStream doGetInputStream(int bufferSize) throws Exception { + protected InputStream doGetInputStream(final int bufferSize) throws Exception { // VFS-210: ram allows to gather an input stream even from a directory. So we need to check the type anyway. if (!getType().hasContent()) { throw new FileSystemException("vfs.provider/read-not-file.error", getName()); diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/sftp/BytesIdentityInfo.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/sftp/BytesIdentityInfo.java index f0eae7a..ac3048e 100644 --- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/sftp/BytesIdentityInfo.java +++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/sftp/BytesIdentityInfo.java @@ -39,7 +39,7 @@ public class BytesIdentityInfo implements IdentityProvider { * @param privateKey Private key bytes * @param passPhrase The passphrase to decrypt the private key (can be {@code null} if no passphrase is used) */ - public BytesIdentityInfo(byte[] privateKey, byte[] passPhrase) { + public BytesIdentityInfo(final byte[] privateKey, final byte[] passPhrase) { super(); this.privateKey = privateKey; this.publicKey = null; @@ -53,7 +53,7 @@ public class BytesIdentityInfo implements IdentityProvider { * @param publicKey The public key part used for connections with exchange of certificates (can be {@code null}) * @param passPhrase The passphrase to decrypt the private key (can be {@code null} if no passphrase is used) */ - public BytesIdentityInfo(byte[] privateKey, byte[] publicKey, byte[] passPhrase) { + public BytesIdentityInfo(final byte[] privateKey, final byte[] publicKey, final byte[] passPhrase) { super(); this.privateKey = privateKey; this.publicKey = publicKey; @@ -61,7 +61,7 @@ public class BytesIdentityInfo implements IdentityProvider { } @Override - public void addIdentity(JSch jsch) throws JSchException { + public void addIdentity(final JSch jsch) throws JSchException { jsch.addIdentity("PrivateKey", privateKey, publicKey, passPhrase); } diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/sftp/SftpFileSystemConfigBuilder.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/sftp/SftpFileSystemConfigBuilder.java index 83e8823..f41c397 100644 --- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/sftp/SftpFileSystemConfigBuilder.java +++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/sftp/SftpFileSystemConfigBuilder.java @@ -215,7 +215,7 @@ public final class SftpFileSystemConfigBuilder extends FileSystemConfigBuilder { final IdentityProvider[] infos = getIdentityProvider(opts); if (infos != null) { final List<IdentityInfo> list = new ArrayList<>(infos.length); - for (IdentityProvider identityProvider : infos) { + for (final IdentityProvider identityProvider : infos) { if (identityProvider instanceof IdentityInfo) { list.add((IdentityInfo) identityProvider); } diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/tar/TarFileObject.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/tar/TarFileObject.java index b7c750a..790673b 100644 --- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/tar/TarFileObject.java +++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/tar/TarFileObject.java @@ -142,7 +142,7 @@ public class TarFileObject extends AbstractFileObject<TarFileSystem> { * called again. */ @Override - protected InputStream doGetInputStream(int bufferSize) throws Exception { + protected InputStream doGetInputStream(final int bufferSize) throws Exception { // VFS-210: zip allows to gather an input stream even from a directory and will // return -1 on the first read. getType should not be expensive and keeps the tests // running diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/url/UrlFileObject.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/url/UrlFileObject.java index 013b16d..0a7fea8 100644 --- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/url/UrlFileObject.java +++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/url/UrlFileObject.java @@ -136,7 +136,7 @@ public class UrlFileObject extends AbstractFileObject<UrlFileSystem> { * Creates an input stream to read the file content from. */ @Override - protected InputStream doGetInputStream(int bufferSize) throws Exception { + protected InputStream doGetInputStream(final int bufferSize) throws Exception { return url.openStream(); } } diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/zip/ZipFileObject.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/zip/ZipFileObject.java index 52b9dd1..97d6a6c 100644 --- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/zip/ZipFileObject.java +++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/zip/ZipFileObject.java @@ -136,7 +136,7 @@ public class ZipFileObject extends AbstractFileObject<ZipFileSystem> { * called again. */ @Override - protected InputStream doGetInputStream(int bufferSize) throws Exception { + protected InputStream doGetInputStream(final int bufferSize) throws Exception { // VFS-210: zip allows to gather an input stream even from a directory and will // return -1 on the first read. getType should not be expensive and keeps the tests // running diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/util/RawMonitorInputStream.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/util/RawMonitorInputStream.java index c031b46..80973f5 100644 --- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/util/RawMonitorInputStream.java +++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/util/RawMonitorInputStream.java @@ -168,7 +168,7 @@ public class RawMonitorInputStream extends FilterInputStream { } @Override - public synchronized void mark(int readlimit) { + public synchronized void mark(final int readlimit) { // TODO Auto-generated method stub super.mark(readlimit); } diff --git a/commons-vfs2/src/test/java/org/apache/commons/vfs2/filter/SymbolicLinkFileFilterTest.java b/commons-vfs2/src/test/java/org/apache/commons/vfs2/filter/SymbolicLinkFileFilterTest.java index bce8c29..e23d51d 100644 --- a/commons-vfs2/src/test/java/org/apache/commons/vfs2/filter/SymbolicLinkFileFilterTest.java +++ b/commons-vfs2/src/test/java/org/apache/commons/vfs2/filter/SymbolicLinkFileFilterTest.java @@ -133,7 +133,7 @@ public class SymbolicLinkFileFilterTest extends BaseFilterTest { @Test public void testZipFile() throws FileSystemException { - FileObject[] files = zipFileObject.findFiles(new FileFilterSelector(SymbolicLinkFileFilter.SYMBOLIC)); + final FileObject[] files = zipFileObject.findFiles(new FileFilterSelector(SymbolicLinkFileFilter.SYMBOLIC)); Assert.assertEquals(0, files.length); } diff --git a/commons-vfs2/src/test/java/org/apache/commons/vfs2/function/VfsConsumerTest.java b/commons-vfs2/src/test/java/org/apache/commons/vfs2/function/VfsConsumerTest.java index 43df4c1..227470c 100644 --- a/commons-vfs2/src/test/java/org/apache/commons/vfs2/function/VfsConsumerTest.java +++ b/commons-vfs2/src/test/java/org/apache/commons/vfs2/function/VfsConsumerTest.java @@ -39,7 +39,7 @@ public class VfsConsumerTest { test(fileObject -> fileObject.exists()); } - private void test(VfsConsumer<FileObject> consumer) throws FileSystemException { + private void test(final VfsConsumer<FileObject> consumer) throws FileSystemException { try (FileObject fileObject = VFS.getManager().resolveFile(Paths.get("DoesNotExist.not)").toUri())) { consumer.accept(fileObject); } diff --git a/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/AbstractFileNameTest.java b/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/AbstractFileNameTest.java index f107589..cfbe24d 100644 --- a/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/AbstractFileNameTest.java +++ b/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/AbstractFileNameTest.java @@ -24,14 +24,14 @@ import org.junit.Test; public class AbstractFileNameTest { @Test public void testHashSignEncoded() { - AbstractFileName fileName = new AbstractFileName("file", "/foo/bar/file#name.txt", FileType.FILE) { + final AbstractFileName fileName = new AbstractFileName("file", "/foo/bar/file#name.txt", FileType.FILE) { @Override - public FileName createName(String absolutePath, FileType fileType) { + public FileName createName(final String absolutePath, final FileType fileType) { return null; } @Override - protected void appendRootUri(StringBuilder buffer, boolean addPassword) { + protected void appendRootUri(final StringBuilder buffer, final boolean addPassword) { if (addPassword) { buffer.append("pass"); } diff --git a/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/ram/test/CustomRamProviderTest.java b/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/ram/test/CustomRamProviderTest.java index 7609dc7..6bdc1b1 100644 --- a/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/ram/test/CustomRamProviderTest.java +++ b/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/ram/test/CustomRamProviderTest.java @@ -94,7 +94,7 @@ public class CustomRamProviderTest { } /** Create directory structure for {@link #testSpecialName()} and {@link #testSchemePrefix()} */ - private FileObject prepareSpecialFile(String dirname, String testFileName) throws FileSystemException + private FileObject prepareSpecialFile(final String dirname, final String testFileName) throws FileSystemException { // set up a folder containing an filename with special characters: final FileObject dir = manager.resolveFile("ram:" + dirname); diff --git a/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/res/test/Vfs444TestCase.java b/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/res/test/Vfs444TestCase.java index 6617688..8b681ce 100644 --- a/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/res/test/Vfs444TestCase.java +++ b/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/res/test/Vfs444TestCase.java @@ -37,7 +37,7 @@ import junit.framework.Test; */ public class Vfs444TestCase extends AbstractProviderTestConfig { public static Test suite() throws Exception { - ProviderTestSuite suite = new ProviderTestSuite(new Vfs444TestCase(), true); + final ProviderTestSuite suite = new ProviderTestSuite(new Vfs444TestCase(), true); suite.addTests(Vfs444Tests.class); return suite; } @@ -63,45 +63,45 @@ public class Vfs444TestCase extends AbstractProviderTestConfig { public static class Vfs444Tests extends AbstractProviderTestCase { public void testResolveFullPathURI0() throws FileSystemException { - FileName result = getManager().resolveURI("res:test-data/test.zip"); + final FileName result = getManager().resolveURI("res:test-data/test.zip"); Assert.assertTrue(result.isFile()); } public void testResolveFullPathFile0() throws FileSystemException { - FileObject result = getManager().resolveFile("res:test-data/test.zip"); + final FileObject result = getManager().resolveFile("res:test-data/test.zip"); Assert.assertTrue(result.exists()); } public void testResolveFullPathURI1() throws FileSystemException { - FileName result = getManager().resolveURI("res:/test-data/test.zip"); + final FileName result = getManager().resolveURI("res:/test-data/test.zip"); Assert.assertTrue(result.isFile()); } public void testResolveFullPathFile1() throws FileSystemException { - FileObject result = getManager().resolveFile("res:/test-data/test.zip"); + final FileObject result = getManager().resolveFile("res:/test-data/test.zip"); Assert.assertTrue(result.exists()); } public void testResolveFullPathURI2() throws FileSystemException { - FileName result = getManager().resolveURI("res://test-data/test.zip"); + final FileName result = getManager().resolveURI("res://test-data/test.zip"); Assert.assertTrue(result.isFile()); } public void testResolveFullPathFile2() throws FileSystemException { - FileObject result = getManager().resolveFile("res://test-data/test.zip"); + final FileObject result = getManager().resolveFile("res://test-data/test.zip"); Assert.assertTrue(result.exists()); } public void testResolvePartialPath1() throws FileSystemException { - FileName result = getManager().resolveURI("res:test-data"); + final FileName result = getManager().resolveURI("res:test-data"); Assert.assertTrue(result.isFile()); } public void testResolvePartialPath2() throws FileSystemException { - FileName root = getManager().resolveURI("res:test-data"); - FileName file = getManager().resolveName(root, "test.zip"); - String uri = file.getURI(); - FileObject result = getManager().resolveFile(uri); + final FileName root = getManager().resolveURI("res:test-data"); + final FileName file = getManager().resolveName(root, "test.zip"); + final String uri = file.getURI(); + final FileObject result = getManager().resolveFile(uri); Assert.assertNotNull(result); Assert.assertTrue(result.exists()); } diff --git a/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/zip/Jira733TestCase.java b/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/zip/Jira733TestCase.java index ad9b1f3..d75502f 100644 --- a/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/zip/Jira733TestCase.java +++ b/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/zip/Jira733TestCase.java @@ -60,6 +60,7 @@ public class Jira733TestCase { final FileObject wrappedFileObject = new OnCallRefreshFileObject(fileObject)) { Assert.assertTrue(fileObject instanceof ZipFileObject); @SuppressWarnings({ "unused", "resource" }) + final ZipFileObject zipFileObject = (ZipFileObject) fileObject; Assert.assertNotNull("getParentLayer() 1", wrappedFileObject.getFileSystem().getParentLayer()); consumer.accept(wrappedFileObject); diff --git a/commons-vfs2/src/test/java/org/apache/commons/vfs2/util/FileObjectUtilsTest.java b/commons-vfs2/src/test/java/org/apache/commons/vfs2/util/FileObjectUtilsTest.java index c9d02cc..8094b89 100644 --- a/commons-vfs2/src/test/java/org/apache/commons/vfs2/util/FileObjectUtilsTest.java +++ b/commons-vfs2/src/test/java/org/apache/commons/vfs2/util/FileObjectUtilsTest.java @@ -36,7 +36,7 @@ import org.junit.Test; */ public class FileObjectUtilsTest { - private void assertProperties(Properties p) { + private void assertProperties(final Properties p) { Assert.assertNotNull(p); Assert.assertEquals("1", p.getProperty("one")); Assert.assertEquals("2", p.getProperty("two")); @@ -96,7 +96,7 @@ public class FileObjectUtilsTest { @Test public void testReadPropertiesInto() throws FileSystemException, IOException { - Properties p = new Properties(); + final Properties p = new Properties(); p.setProperty("extraKey", "extraValue"); assertProperties(FileObjectUtils .readProperties(VFS.getManager().toFileObject(new File("src/test/resources/test.properties")), p));