This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-pool.git
commit c5328f9ab2ec04af98aa3eac9a7bb5c35f75da87 Author: Gary Gregory <gardgreg...@gmail.com> AuthorDate: Sun Oct 6 19:07:54 2019 -0400 Use final. --- src/main/java/org/apache/commons/pool2/PooledObject.java | 2 +- .../org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java | 6 +++--- .../java/org/apache/commons/pool2/impl/TestGenericObjectPool.java | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/main/java/org/apache/commons/pool2/PooledObject.java b/src/main/java/org/apache/commons/pool2/PooledObject.java index 142deca..9cac096 100644 --- a/src/main/java/org/apache/commons/pool2/PooledObject.java +++ b/src/main/java/org/apache/commons/pool2/PooledObject.java @@ -188,7 +188,7 @@ public interface PooledObject<T> extends Comparable<PooledObject<T>> { * @param requireFullStackTrace the new configuration setting for abandoned object logging * @since 2.7.0 */ - default void setRequireFullStackTrace(boolean requireFullStackTrace) { + default void setRequireFullStackTrace(final boolean requireFullStackTrace) { // noop } diff --git a/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java b/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java index 9357e3d..509fbb6 100644 --- a/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java +++ b/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java @@ -2318,7 +2318,7 @@ public class TestGenericKeyedObjectPool extends TestKeyedObjectPool { gkoPool.setEvictionPolicy(new SlowEvictionPolicy<String>(1000)); // Borrow an instance - String val = gkoPool.borrowObject("foo"); + final String val = gkoPool.borrowObject("foo"); // Add another idle one gkoPool.addObject("foo"); @@ -2352,7 +2352,7 @@ public class TestGenericKeyedObjectPool extends TestKeyedObjectPool { * * @param delay number of ms of latency to inject in evict */ - public SlowEvictionPolicy(long delay) { + public SlowEvictionPolicy(final long delay) { super(); this.delay = delay; } @@ -2362,7 +2362,7 @@ public class TestGenericKeyedObjectPool extends TestKeyedObjectPool { final int idleCount) { try { Thread.sleep(delay); - } catch (InterruptedException e) { + } catch (final InterruptedException e) { // ignore } return super.evict(config, underTest, idleCount); diff --git a/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPool.java b/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPool.java index e93cc58..fa61f9f 100644 --- a/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPool.java +++ b/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPool.java @@ -2134,7 +2134,7 @@ public class TestGenericObjectPool extends TestBaseObjectPool { genericObjectPool.setMaxTotal(1); genericObjectPool.setTestOnCreate(true); genericObjectPool.setMaxWaitMillis(-1); - String obj = genericObjectPool.borrowObject(); + final String obj = genericObjectPool.borrowObject(); // Make validation fail - this will cause create() to return null simpleFactory.setValid(false); // Create a take waiter