[commons-numbers] 13/18: NUMBERS-120: Simplify roundAndRightShift(BigInteger, int, boolean)

[erans]

This is an automated email from the ASF dual-hosted git repository.

erans pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git

commit e6de6fc654b0fba45e838b35787a8fa46a8b9f4f
Author: Schamschi <heinrich.bo...@gmx.at>
AuthorDate: Wed Jul 3 01:01:55 2019 +0200

    NUMBERS-120: Simplify roundAndRightShift(BigInteger, int, boolean)
---
 .../java/org/apache/commons/numbers/fraction/BigFraction.java     | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git 
a/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/BigFraction.java
 
b/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/BigFraction.java
index 7737228..a73a643 100644
--- 
a/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/BigFraction.java
+++ 
b/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/BigFraction.java
@@ -836,16 +836,12 @@ public class BigFraction extends Number implements 
Comparable<BigFraction>, Seri
         if (bits <= 0) {
             throw new IllegalArgumentException();
         }
-        boolean roundUp = false;
+        BigInteger result = value.shiftRight(bits);
         if (value.testBit(bits - 1) &&
                 (hasFractionalBits ||
                 (value.getLowestSetBit() < bits - 1) ||
                 value.testBit(bits))) {
-            roundUp = true;
-        }
-        BigInteger result = value.shiftRight(bits);
-        if (roundUp) {
-            result = result.add(BigInteger.ONE);
+            result = result.add(BigInteger.ONE); //round up
         }
         return result;
     }