This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-dbcp.git
commit 43ec6a924be1fb22b21c40b82f1a4ddc101313a8 Author: Gary Gregory <gardgreg...@gmail.com> AuthorDate: Tue Jul 30 09:56:48 2019 -0400 Better lvar names. --- .../apache/commons/dbcp2/DelegatingConnection.java | 30 +++++++++++----------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/src/main/java/org/apache/commons/dbcp2/DelegatingConnection.java b/src/main/java/org/apache/commons/dbcp2/DelegatingConnection.java index 546e6a8..fc09b23 100644 --- a/src/main/java/org/apache/commons/dbcp2/DelegatingConnection.java +++ b/src/main/java/org/apache/commons/dbcp2/DelegatingConnection.java @@ -89,17 +89,17 @@ public class DelegatingConnection<C extends Connection> extends AbandonedTrace i */ @Override public synchronized String toString() { - String s = null; + String str = null; - final Connection c = this.getInnermostDelegateInternal(); - if (c != null) { + final Connection conn = this.getInnermostDelegateInternal(); + if (conn != null) { try { - if (c.isClosed()) { - s = "connection is closed"; + if (conn.isClosed()) { + str = "connection is closed"; } else { final StringBuffer sb = new StringBuffer(); sb.append(hashCode()); - final DatabaseMetaData meta = c.getMetaData(); + final DatabaseMetaData meta = conn.getMetaData(); if (meta != null) { sb.append(", URL="); sb.append(meta.getURL()); @@ -107,7 +107,7 @@ public class DelegatingConnection<C extends Connection> extends AbandonedTrace i sb.append(meta.getUserName()); sb.append(", "); sb.append(meta.getDriverName()); - s = sb.toString(); + str = sb.toString(); } } } catch (final SQLException ex) { @@ -115,11 +115,11 @@ public class DelegatingConnection<C extends Connection> extends AbandonedTrace i } } - if (s == null) { - s = super.toString(); + if (str == null) { + str = super.toString(); } - return s; + return str; } /** @@ -175,14 +175,14 @@ public class DelegatingConnection<C extends Connection> extends AbandonedTrace i * @return innermost delegate. */ public final Connection getInnermostDelegateInternal() { - Connection c = connection; - while (c != null && c instanceof DelegatingConnection) { - c = ((DelegatingConnection<?>) c).getDelegateInternal(); - if (this == c) { + Connection conn = connection; + while (conn != null && conn instanceof DelegatingConnection) { + conn = ((DelegatingConnection<?>) conn).getDelegateInternal(); + if (this == conn) { return null; } } - return c; + return conn; } /**