[commons-bcel] branch master updated: Javadoc.

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-bcel.git


The following commit(s) were added to refs/heads/master by this push:
     new 47109d0  Javadoc.
47109d0 is described below

commit 47109d0b4a673f40e067d8916f4c683efda5dcc7
Author: Gary Gregory <gardgreg...@gmail.com>
AuthorDate: Fri Jul 5 19:07:43 2019 -0400

    Javadoc.
---
 .../bcel/generic/JdkGenericDumpTestCase.java       | 32 ++++++++++++++--------
 1 file changed, 20 insertions(+), 12 deletions(-)

diff --git a/src/test/java/org/apache/bcel/generic/JdkGenericDumpTestCase.java 
b/src/test/java/org/apache/bcel/generic/JdkGenericDumpTestCase.java
index 468e782..dbf9ab1 100644
--- a/src/test/java/org/apache/bcel/generic/JdkGenericDumpTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/JdkGenericDumpTestCase.java
@@ -62,8 +62,16 @@ import com.sun.jna.platform.win32.Advapi32Util;
  * Test that the generic dump() methods work on the JDK classes Reads each 
class into an instruction list and then dumps
  * the instructions. The output bytes should be the same as the input.
  * <p>
- * Set the property {@value #EXTRA_JAVA_HOMES} to a comma-sepaarted list of 
JRE/JDK paths for additional testing.
+ * Set the property {@value #EXTRA_JAVA_HOMES} to a {@link 
File#pathSeparator}-separated list of JRE/JDK paths for
+ * additional testing.
  * </p>
+ * <p>
+ * For example:
+ * </p>
+ * 
+ * <pre>
+ * mvn test -Dtest=JdkGenericDumpTestCase -DExtraJavaHomes="C:\Program 
Files\Java\openjdk\jdk-13;C:\Program Files\Java\openjdk\jdk-14"
+ * </pre>
  */
 @RunWith(Parameterized.class)
 public class JdkGenericDumpTestCase {
@@ -162,21 +170,21 @@ public class JdkGenericDumpTestCase {
     }
 
     private static void addAllJavaHomes(String extraJavaHomesProp, Set<String> 
javaHomes) {
-               String path = System.getProperty(extraJavaHomesProp);
-               if (StringUtils.isEmpty(path)) {
-                       return;
-               }
-               String[] paths = path.split(File.pathSeparator);
-               javaHomes.addAll(Arrays.asList(paths));
-               
-       }
-
-       private static Set<String> findJavaHomesOnWindows(final String 
keyJavaHome, final String[] keys) {
+        String path = System.getProperty(extraJavaHomesProp);
+        if (StringUtils.isEmpty(path)) {
+            return;
+        }
+        String[] paths = path.split(File.pathSeparator);
+        javaHomes.addAll(Arrays.asList(paths));
+
+    }
+
+    private static Set<String> findJavaHomesOnWindows(final String 
keyJavaHome, final String[] keys) {
         final Set<String> javaHomes = new HashSet<>(keys.length);
         for (final String key : keys) {
             if (Advapi32Util.registryKeyExists(HKEY_LOCAL_MACHINE, keyJavaHome 
+ "\\" + key)) {
                 final String javaHome = 
Advapi32Util.registryGetStringValue(HKEY_LOCAL_MACHINE,
-                        keyJavaHome + "\\" + key, "JavaHome");
+                    keyJavaHome + "\\" + key, "JavaHome");
                 if (StringUtils.isNoneBlank(javaHome)) {
                     if (new File(javaHome).exists()) {
                         javaHomes.add(javaHome);