This is an automated email from the ASF dual-hosted git repository. erans pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-numbers.git
commit 12a73b0eebd7ddade7e2370a40e219d8d9d0dca0 Author: Schamschi <heinrich.bo...@gmx.at> AuthorDate: Thu Jun 20 12:02:54 2019 +0200 NUMBERS-118: Collect stray test cases for double constructor --- .../java/org/apache/commons/numbers/fraction/BigFractionTest.java | 4 ---- .../java/org/apache/commons/numbers/fraction/CommonTestCases.java | 4 ++++ .../test/java/org/apache/commons/numbers/fraction/FractionTest.java | 4 ---- 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/BigFractionTest.java b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/BigFractionTest.java index ab79b07..6e050d2 100644 --- a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/BigFractionTest.java +++ b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/BigFractionTest.java @@ -52,10 +52,6 @@ public class BigFractionTest { assertFraction(11, 1, BigFraction.of(11l)); assertFraction(11, 1, BigFraction.of(new BigInteger("11"))); - assertFraction(0, 1, BigFraction.from(0.00000000000001, 1.0e-5, 100)); - assertFraction(2, 5, BigFraction.from(0.40000000000001, 1.0e-5, 100)); - assertFraction(15, 1, BigFraction.from(15.0000000000001, 1.0e-5, 100)); - Assertions.assertEquals(0.00000000000001, BigFraction.from(0.00000000000001).doubleValue(), 0.0); Assertions.assertEquals(0.40000000000001, BigFraction.from(0.40000000000001).doubleValue(), 0.0); Assertions.assertEquals(15.0000000000001, BigFraction.from(15.0000000000001).doubleValue(), 0.0); diff --git a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/CommonTestCases.java b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/CommonTestCases.java index cd68373..0a82549 100644 --- a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/CommonTestCases.java +++ b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/CommonTestCases.java @@ -81,6 +81,10 @@ public class CommonTestCases { testCases.add(new DoubleToFractionTestCase(9d/11d, 9, 11)); testCases.add(new DoubleToFractionTestCase(10d/11d, 10, 11)); + testCases.add(new DoubleToFractionTestCase(0.00000000000001, 0, 1)); + testCases.add(new DoubleToFractionTestCase(0.40000000000001, 2, 5)); + testCases.add(new DoubleToFractionTestCase(15.0000000000001, 15, 1)); + return testCases; } diff --git a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/FractionTest.java b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/FractionTest.java index c47d51a..510e4c3 100644 --- a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/FractionTest.java +++ b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/FractionTest.java @@ -48,10 +48,6 @@ public class FractionTest { Assertions.assertThrows(ArithmeticException.class, () -> Fraction.of(1, Integer.MIN_VALUE) ); - - assertFraction(0, 1, Fraction.from(0.00000000000001)); - assertFraction(2, 5, Fraction.from(0.40000000000001)); - assertFraction(15, 1, Fraction.from(15.0000000000001)); } @Test