This is an automated email from the ASF dual-hosted git repository. erans pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-numbers.git
commit b4356bd53bdab7cb73ba7594a6594310c233d08d Author: Gilles Sadowski <gil...@harfang.homelinux.org> AuthorDate: Fri Jun 7 23:48:58 2019 +0200 Implement ValJO convention. --- .../src/main/java/org/apache/commons/numbers/field/FP64.java | 12 +++++++++++- .../java/org/apache/commons/numbers/field/FP64Field.java | 4 ++-- .../java/org/apache/commons/numbers/field/FieldsList.java | 6 +++--- 3 files changed, 16 insertions(+), 6 deletions(-) diff --git a/commons-numbers-field/src/main/java/org/apache/commons/numbers/field/FP64.java b/commons-numbers-field/src/main/java/org/apache/commons/numbers/field/FP64.java index f0a2c92..764b51c 100644 --- a/commons-numbers-field/src/main/java/org/apache/commons/numbers/field/FP64.java +++ b/commons-numbers-field/src/main/java/org/apache/commons/numbers/field/FP64.java @@ -36,10 +36,20 @@ public class FP64 extends Number /** * @param value Value. */ - public FP64(double value) { + private FP64(double value) { this.value = value; } + /** + * Factory. + * + * @param value Value. + * @return a new instance. + */ + public static FP64 of(double value) { + return new FP64(value); + } + /** {@inheritDoc} */ @Override public FP64 add(FP64 a) { diff --git a/commons-numbers-field/src/main/java/org/apache/commons/numbers/field/FP64Field.java b/commons-numbers-field/src/main/java/org/apache/commons/numbers/field/FP64Field.java index fe7e921..491c8d4 100644 --- a/commons-numbers-field/src/main/java/org/apache/commons/numbers/field/FP64Field.java +++ b/commons-numbers-field/src/main/java/org/apache/commons/numbers/field/FP64Field.java @@ -21,9 +21,9 @@ package org.apache.commons.numbers.field; */ public class FP64Field extends AbstractField<FP64> { /** 0d */ - private static final FP64 ZERO = new FP64(0.); + private static final FP64 ZERO = FP64.of(0d); /** 1d */ - private static final FP64 ONE = new FP64(1.); + private static final FP64 ONE = FP64.of(1d); /** {@inheritDoc} */ @Override diff --git a/commons-numbers-field/src/test/java/org/apache/commons/numbers/field/FieldsList.java b/commons-numbers-field/src/test/java/org/apache/commons/numbers/field/FieldsList.java index ec68123..a341171 100644 --- a/commons-numbers-field/src/test/java/org/apache/commons/numbers/field/FieldsList.java +++ b/commons-numbers-field/src/test/java/org/apache/commons/numbers/field/FieldsList.java @@ -39,9 +39,9 @@ public class FieldsList { Fraction.of(5, 29), Fraction.of(-279, 11)); add(new FP64Field(), - new FP64(23.45678901), - new FP64(-543.2109876), - new FP64(-234.5678901)); + FP64.of(23.45678901), + FP64.of(-543.2109876), + FP64.of(-234.5678901)); } catch (Exception e) { System.err.println("Unexpected exception while creating the list of fields: " + e);