[commons-release-plugin] branch master updated: Fix compiler warnings.

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-release-plugin.git


The following commit(s) were added to refs/heads/master by this push:
     new d0bf57f  Fix compiler warnings.
d0bf57f is described below

commit d0bf57f2a122d2a8b4a5309cc65d4ea47ad49c21
Author: Gary Gregory <gardgreg...@gmail.com>
AuthorDate: Sun Apr 7 10:15:31 2019 -0400

    Fix compiler warnings.
---
 .../velocity/HeaderHtmlVelocityDelegateTest.java   | 10 ++++---
 .../velocity/ReadmeHtmlVelocityDelegateTest.java   | 31 +++++++++++-----------
 2 files changed, 22 insertions(+), 19 deletions(-)

diff --git 
a/src/test/java/org/apache/commons/release/plugin/velocity/HeaderHtmlVelocityDelegateTest.java
 
b/src/test/java/org/apache/commons/release/plugin/velocity/HeaderHtmlVelocityDelegateTest.java
index 0158311..a758c6a 100755
--- 
a/src/test/java/org/apache/commons/release/plugin/velocity/HeaderHtmlVelocityDelegateTest.java
+++ 
b/src/test/java/org/apache/commons/release/plugin/velocity/HeaderHtmlVelocityDelegateTest.java
@@ -18,8 +18,10 @@ package org.apache.commons.release.plugin.velocity;
 
 import static junit.framework.TestCase.assertTrue;
 
+import java.io.IOException;
 import java.io.StringWriter;
 import java.io.Writer;
+
 import org.junit.Test;
 
 /**
@@ -28,11 +30,11 @@ import org.junit.Test;
 public class HeaderHtmlVelocityDelegateTest {
 
     @Test
-    public void testSuccess() {
+    public void testSuccess() throws IOException {
         final HeaderHtmlVelocityDelegate subject = 
HeaderHtmlVelocityDelegate.builder().build();
-        Writer writer = new StringWriter();
-        writer = subject.render(writer);
-        assertTrue(writer.toString().contains("<h2>Apache Commons Project 
Distributions</h2>"));
+        try (Writer writer = subject.render(new StringWriter())) {
+            assertTrue(writer.toString().contains("<h2>Apache Commons Project 
Distributions</h2>"));
+        }
     }
 
 }
diff --git 
a/src/test/java/org/apache/commons/release/plugin/velocity/ReadmeHtmlVelocityDelegateTest.java
 
b/src/test/java/org/apache/commons/release/plugin/velocity/ReadmeHtmlVelocityDelegateTest.java
index 6e5fd8a..b9b6cd0 100755
--- 
a/src/test/java/org/apache/commons/release/plugin/velocity/ReadmeHtmlVelocityDelegateTest.java
+++ 
b/src/test/java/org/apache/commons/release/plugin/velocity/ReadmeHtmlVelocityDelegateTest.java
@@ -18,6 +18,7 @@ package org.apache.commons.release.plugin.velocity;
 
 import org.junit.Test;
 
+import java.io.IOException;
 import java.io.StringWriter;
 import java.io.Writer;
 
@@ -31,43 +32,43 @@ import static junit.framework.TestCase.assertTrue;
 public class ReadmeHtmlVelocityDelegateTest {
 
     @Test
-    public void testSuccessfulRun() {
+    public void testSuccessfulRun() throws IOException {
         final ReadmeHtmlVelocityDelegate delegate = 
ReadmeHtmlVelocityDelegate.builder()
                 .withArtifactId("commons-text")
                 .withVersion("1.4")
                 .withSiteUrl("http://commons.apache.org/text";)
                 .build();
-        Writer writer = new StringWriter();
-        writer = delegate.render(writer);
-        final String filledOutTemplate = writer.toString();
-        assertTrue(filledOutTemplate.contains("<h1>Commons-TEXT v1.4.</h1>"));
+        try (Writer writer = delegate.render(new StringWriter())) {
+            final String filledOutTemplate = writer.toString();
+            assertTrue(filledOutTemplate.contains("<h1>Commons-TEXT 
v1.4.</h1>"));
+        }
     }
 
     @Test
-    public void testSuccessfulRunLang3() {
+    public void testSuccessfulRunLang3() throws IOException {
         final ReadmeHtmlVelocityDelegate delegate = 
ReadmeHtmlVelocityDelegate.builder()
                 .withArtifactId("commons-lang3")
                 .withVersion("3.8.1")
                 .withSiteUrl("http://commons.apache.org/text";)
                 .build();
-        Writer writer = new StringWriter();
-        writer = delegate.render(writer);
-        final String filledOutTemplate = writer.toString();
-        assertTrue(filledOutTemplate.contains("<h1>Commons-LANG 
v3.8.1.</h1>"));
+        try (Writer writer = delegate.render(new StringWriter())) {
+            final String filledOutTemplate = writer.toString();
+            assertTrue(filledOutTemplate.contains("<h1>Commons-LANG 
v3.8.1.</h1>"));
+        }
     }
 
 
 
     @Test
-    public void testSuccessfulRunBcel() {
+    public void testSuccessfulRunBcel() throws IOException {
         final ReadmeHtmlVelocityDelegate delegate = 
ReadmeHtmlVelocityDelegate.builder()
                 .withArtifactId("bcel")
                 .withVersion("1.5")
                 .withSiteUrl("http://commons.apache.org/text";)
                 .build();
-        Writer writer = new StringWriter();
-        writer = delegate.render(writer);
-        final String filledOutTemplate = writer.toString();
-        assertTrue(filledOutTemplate.contains("<h1>Commons-BCEL v1.5.</h1>"));
+        try (Writer writer = delegate.render(new StringWriter())) {
+            final String filledOutTemplate = writer.toString();
+            assertTrue(filledOutTemplate.contains("<h1>Commons-BCEL 
v1.5.</h1>"));
+        }
     }
 }